archive mirror
 help / color / mirror / Atom feed
From: Pierre Ossman <>
To: Christoph Hellwig <>
Cc: Geert Uytterhoeven <>,
	LKML <>,
Subject: Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA
Date: Sat, 29 Jan 2005 16:31:16 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Christoph Hellwig wrote:

>>>Russell, please undo this patch. isa_virt_to_bus() is not dependent on 
>>>CONFIG_ISA. It causes problems on x86_64 platforms which cannot enable 
>>>ISA support.
>Actually it is, x86_64 just refuses to set CONFIG_ISA despite having
>isa-like devices.
>Either way a new driver shouldn't use isa_virt_to_bus at all but rather
>use the proper DMA API and all those problems go away.
The problem was that the DMA API didn't work for x86_64 when I wrote the 
driver. I see now that it has been fixed.
isa_virt_to_bus still works even though CONFIG_ISA is not configured. So 
I still think that the ISA dependency should be removed.
I'll move to the new API when I have the time to properly test it.


  parent reply	other threads:[~2005-01-29 15:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-07 22:50 [PATCH 540] MMC_WBSD depends on ISA Geert Uytterhoeven
2005-01-10  7:14 ` [Wbsd-devel] " Pierre Ossman
2005-01-29 13:37   ` Pierre Ossman
2005-01-29 13:57     ` Christoph Hellwig
2005-01-29 14:54       ` Russell King
2005-01-29 15:00         ` Christoph Hellwig
2005-01-29 15:13           ` Russell King
2005-01-29 15:16             ` Christoph Hellwig
2005-01-29 15:31           ` Pierre Ossman [this message]
2005-01-29 15:57             ` Christoph Hellwig
2005-01-29 16:08               ` Pierre Ossman
2005-01-29 16:13                 ` Christoph Hellwig
2005-01-29 16:27                   ` Pierre Ossman
2005-01-30  9:37             ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).