From: Geert Uytterhoeven <firstname.lastname@example.org>
To: Pierre Ossman <email@example.com>
Cc: Christoph Hellwig <firstname.lastname@example.org>,
Subject: Re: [Wbsd-devel] [PATCH 540] MMC_WBSD depends on ISA
Date: Sun, 30 Jan 2005 10:37:42 +0100 (MET) [thread overview]
Message-ID: <Pine.GSO.email@example.com> (raw)
On Sat, 29 Jan 2005, Pierre Ossman wrote:
> Christoph Hellwig wrote:
> > > > Russell, please undo this patch. isa_virt_to_bus() is not dependent on
> > > > CONFIG_ISA. It causes problems on x86_64 platforms which cannot enable
> > > > ISA support.
> > Actually it is, x86_64 just refuses to set CONFIG_ISA despite having
> > isa-like devices.
> > Either way a new driver shouldn't use isa_virt_to_bus at all but rather
> > use the proper DMA API and all those problems go away.
> The problem was that the DMA API didn't work for x86_64 when I wrote the
> driver. I see now that it has been fixed.
> isa_virt_to_bus still works even though CONFIG_ISA is not configured. So I
> still think that the ISA dependency should be removed.
... which makes it selectable again on all platforms that don't have ISA and
don't provide isa_virt_to_bus(), where it still breaks.
Please don't remove the dependency...
> I'll move to the new API when I have the time to properly test it.
.. but change it to e.g. `depends on ISA || X86_64', until you have moved it to
the new API.
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- firstname.lastname@example.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2005-01-30 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-07 22:50 [PATCH 540] MMC_WBSD depends on ISA Geert Uytterhoeven
2005-01-10 7:14 ` [Wbsd-devel] " Pierre Ossman
2005-01-29 13:37 ` Pierre Ossman
2005-01-29 13:57 ` Christoph Hellwig
2005-01-29 14:54 ` Russell King
2005-01-29 15:00 ` Christoph Hellwig
2005-01-29 15:13 ` Russell King
2005-01-29 15:16 ` Christoph Hellwig
2005-01-29 15:31 ` Pierre Ossman
2005-01-29 15:57 ` Christoph Hellwig
2005-01-29 16:08 ` Pierre Ossman
2005-01-29 16:13 ` Christoph Hellwig
2005-01-29 16:27 ` Pierre Ossman
2005-01-30 9:37 ` Geert Uytterhoeven [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).