From: Matthew Dobson <colpatch@us.ibm.com>
To: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Cc: Greg KH <gregkh@suse.de>, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [RFC/PATCH] unregister_node() for hotplug use
Date: Mon, 09 May 2005 15:44:03 -0700 [thread overview]
Message-ID: <427FE7B3.8080200@us.ibm.com> (raw)
In-Reply-To: <20050507211141.4829d4c0.tokunaga.keiich@jp.fujitsu.com>
Keiichiro Tokunaga wrote:
> I updated the patch for 2.6.12-rc3-mm3 based on my
> previous comments. Please apply.
>
> Thanks,
> Keiichiro Tokunaga
>
>
>
> This adds a generic function 'unregister_node()'.
> It is used to remove objects of a node going away
> for hotplug.
>
> Signed-off-by: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>
> ---
>
> linux-2.6.12-rc3-mm3-kei/drivers/base/node.c | 15 +++++++++++++--
> linux-2.6.12-rc3-mm3-kei/include/linux/node.h | 1 +
> 2 files changed, 14 insertions(+), 2 deletions(-)
>
> diff -puN drivers/base/node.c~numa_hp_base drivers/base/node.c
> --- linux-2.6.12-rc3-mm3/drivers/base/node.c~numa_hp_base 2005-05-07 19:58:15.000000000 +0900
> +++ linux-2.6.12-rc3-mm3-kei/drivers/base/node.c 2005-05-07 19:58:15.000000000 +0900
> @@ -136,7 +136,7 @@ static SYSDEV_ATTR(distance, S_IRUGO, no
> *
> * Initialize and register the node device.
> */
> -int __init register_node(struct node *node, int num, struct node *parent)
> +int register_node(struct node *node, int num, struct node *parent)
> {
> int error;
>
> @@ -153,8 +153,19 @@ int __init register_node(struct node *no
> return error;
> }
>
> +void unregister_node(struct node *node)
> +{
> + sysdev_remove_file(&node->sysdev, &attr_cpumap);
> + sysdev_remove_file(&node->sysdev, &attr_meminfo);
> + sysdev_remove_file(&node->sysdev, &attr_numastat);
> + sysdev_remove_file(&node->sysdev, &attr_distance);
> +
> + sysdev_unregister(&node->sysdev);
> +}
Is there a reason to not make both register_node() and unregister_node()
__devinit? If a user has CONFIG_HOTPLUG=y then they want these functions,
otherwise there is no point, as they promised they won't be hotplugging
anything, right?
-Matt
next prev parent reply other threads:[~2005-05-09 22:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-20 12:07 [RFC/PATCH] unregister_node() for hotplug use Keiichiro Tokunaga
2005-04-20 12:35 ` Arjan van de Ven
2005-04-21 9:25 ` Keiichiro Tokunaga
2005-04-20 17:32 ` Greg KH
2005-04-21 15:30 ` Keiichiro Tokunaga
2005-04-22 0:39 ` Greg KH
2005-04-22 2:32 ` Keiichiro Tokunaga
2005-04-25 14:03 ` Keiichiro Tokunaga
2005-04-26 6:54 ` Greg KH
2005-04-28 0:17 ` Keiichiro Tokunaga
2005-05-07 12:11 ` Keiichiro Tokunaga
2005-05-08 0:26 ` Nathan Lynch
2005-05-08 12:28 ` Keiichiro Tokunaga
2005-05-09 22:44 ` Matthew Dobson [this message]
2005-05-10 11:20 ` Keiichiro Tokunaga
2005-05-10 18:15 ` Matthew Dobson
2005-05-10 18:45 ` Greg KH
2005-05-10 18:58 ` Matthew Dobson
2005-05-10 20:11 ` Greg KH
2005-05-10 20:13 ` Matthew Dobson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427FE7B3.8080200@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tokunaga.keiich@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).