linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Dobson <colpatch@us.ibm.com>
To: Greg KH <gregkh@suse.de>
Cc: Keiichiro Tokunaga <tokunaga.keiich@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [RFC/PATCH] unregister_node() for hotplug use
Date: Tue, 10 May 2005 11:58:36 -0700	[thread overview]
Message-ID: <4281045C.4020205@us.ibm.com> (raw)
In-Reply-To: <20050510184508.GA2463@suse.de>

Greg KH wrote:
> On Tue, May 10, 2005 at 11:15:29AM -0700, Matthew Dobson wrote:
> 
>>So I think it's probably a good idea to stick the __devinit on
>>register_node() and unregister_node(), otherwise we have no marker to know
>>which functions to remove for CONFIG_TINY.  Greg?
> 
> 
> Like _anyone_ would have CONFIG_NUMA and CONFIG_TINY enabled at the same
> time?  I don't think so...
> 
> I'll leave it as is for now.
> 
> thanks,
> 
> greg k-h

No, it seems unlikely that anyone would build with CONFIG_NUMA and
CONFIG_TINY both enabled.  But it is possible and reasonable to build with
CONFIG_NUMA=y and CONFIG_HOTPLUG=n, which is the case I was trying to speak
to.  If NUMA is on and HOTPLUG is off, then we're wasting kernel text
(granted, it's a very small amount of space) for the register_node() &
unregister_node() functions that we *know* will never be called after
initial bootup.  That's why I suggested marking both of those functions as
__devinit.  But it doesn't make a huge difference either way.

-Matt

  reply	other threads:[~2005-05-10 18:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-20 12:07 [RFC/PATCH] unregister_node() for hotplug use Keiichiro Tokunaga
2005-04-20 12:35 ` Arjan van de Ven
2005-04-21  9:25   ` Keiichiro Tokunaga
2005-04-20 17:32 ` Greg KH
2005-04-21 15:30   ` Keiichiro Tokunaga
2005-04-22  0:39     ` Greg KH
2005-04-22  2:32       ` Keiichiro Tokunaga
2005-04-25 14:03         ` Keiichiro Tokunaga
2005-04-26  6:54           ` Greg KH
2005-04-28  0:17             ` Keiichiro Tokunaga
2005-05-07 12:11             ` Keiichiro Tokunaga
2005-05-08  0:26               ` Nathan Lynch
2005-05-08 12:28                 ` Keiichiro Tokunaga
2005-05-09 22:44               ` Matthew Dobson
2005-05-10 11:20                 ` Keiichiro Tokunaga
2005-05-10 18:15                   ` Matthew Dobson
2005-05-10 18:45                     ` Greg KH
2005-05-10 18:58                       ` Matthew Dobson [this message]
2005-05-10 20:11                         ` Greg KH
2005-05-10 20:13                           ` Matthew Dobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4281045C.4020205@us.ibm.com \
    --to=colpatch@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tokunaga.keiich@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).