archive mirror
 help / color / mirror / Atom feed
From: Rene Herman <>
Cc: Bjorn Helgaas <>,
	linux-kernel <>,
	akpm <>,
	"Li, Shaohua" <>,
	Alan Cox <>
Subject: Re: [PATCH] Declare PNP option parsing functions as __init
Date: Sun, 02 Dec 2007 14:50:10 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 02-12-07 14:34, Thomas Renninger wrote:

> On Sat, 2007-12-01 at 01:33 +0100, Rene Herman wrote:
>> On 01-12-07 00:52, Bjorn Helgaas wrote:

>>> I agree this is probably safe in the current implementation.
>>> However, I think the current implementation is just broken because
>>> we can't really handle hotplug of ACPI devices.  Specifically, I think
>>> the first TBD in acpi_bus_check_device() should be fleshed out so it
>>> does something like pnpacpi_add_device().
>>> So my dissenting opinion is that this patch would just get reverted
>>> soon anyway when somebody finishes implementing ACPI hotplug, and
>>> therefore it's not worth doing.
>> <shrug>
>> The PnPBIOS bits should still be fine at least I guess. And, it would seem 
>> this is rather essential to Thomas' efforts of making this stuff dynamic in 
>> the first place anyway.
> No it is not. It is just another optimization I saw while going through
> these code parts...

Bjorn's argument of making the possible resources runtime dynamic is the 
essential bit, not the patch. You weren't doing that in the simple scheme 
you've outlined till now. Are you or is anyone else now after all?


  reply	other threads:[~2007-12-02 13:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 17:04 [PATCH] Declare PNP option parsing functions as __init Thomas Renninger
2007-11-30 23:37 ` Rene Herman
2007-11-30 23:52   ` Bjorn Helgaas
2007-12-01  0:33     ` Rene Herman
2007-12-02 13:34       ` Thomas Renninger
2007-12-02 13:50         ` Rene Herman [this message]
2007-12-02 13:32     ` Thomas Renninger
2007-12-03 11:53     ` Thomas Renninger
2007-12-03 15:52       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).