Re: [PATCH] Declare PNP option parsing functions as __init

From: Rene Herman <rene.herman@keyaccess.nl>
To: trenn@suse.de
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>,
	"Li, Shaohua" <shaohua.li@intel.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] Declare PNP option parsing functions as __init
Date: Sun, 02 Dec 2007 14:50:10 +0100	[thread overview]
Message-ID: <4752B812.7070802@keyaccess.nl> (raw)
In-Reply-To: <1196602496.4049.51.camel@queen.suse.de>

On 02-12-07 14:34, Thomas Renninger wrote:

> On Sat, 2007-12-01 at 01:33 +0100, Rene Herman wrote:
>> On 01-12-07 00:52, Bjorn Helgaas wrote:

>>> I agree this is probably safe in the current implementation.
>>>
>>> However, I think the current implementation is just broken because
>>> we can't really handle hotplug of ACPI devices.  Specifically, I think
>>> the first TBD in acpi_bus_check_device() should be fleshed out so it
>>> does something like pnpacpi_add_device().
>>>
>>> So my dissenting opinion is that this patch would just get reverted
>>> soon anyway when somebody finishes implementing ACPI hotplug, and
>>> therefore it's not worth doing.
>> <shrug>
>>
>> The PnPBIOS bits should still be fine at least I guess. And, it would seem 
>> this is rather essential to Thomas' efforts of making this stuff dynamic in 
>> the first place anyway.
> No it is not. It is just another optimization I saw while going through
> these code parts...

Bjorn's argument of making the possible resources runtime dynamic is the 
essential bit, not the patch. You weren't doing that in the simple scheme 
you've outlined till now. Are you or is anyone else now after all?

Rene.