From: Michael Opdenacker <michael-lists@free-electrons.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, Linux-tiny@selenic.com
Subject: Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling
Date: Fri, 18 Jan 2008 13:14:25 +0100 [thread overview]
Message-ID: <47909821.1090907@free-electrons.com> (raw)
In-Reply-To: <20080118110252.GA17397@elte.hu>
On 01/18/2008 12:02 PM, Ingo Molnar wrote:
>
> why didnt you make this:
>
> obj-$(CONFIG_INPUT_PCSPKR) += pcspeaker.o
>
> ?
>
Many thanks for your feedback.
That's what I did first, but if CONFIG_INPUT_PCSPKR=m,
arch/x86/kernel/pcspeaker.c gets compiled as a module. While compiling
doesn't fail, is this still a valid module? It defines no init and exit
functions, and it defines an initcall, which only makes sense at boot time.
We could make pcspeaker.c depend on another switch, like
CONFIG_PCSPEAKER on mips. We could offer the possibility to disable it
when CONFIG_EMBEDDED is set.
What do you think?
Michael.
--
Michael Opdenacker, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)
next prev parent reply other threads:[~2008-01-18 12:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-17 15:43 [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling Michael Opdenacker
2008-01-17 16:36 ` Matt Mackall
2008-01-17 17:05 ` Michael Opdenacker
2008-01-17 17:13 ` Matt Mackall
2008-01-17 18:32 ` Michael Opdenacker
2008-01-17 22:15 ` Michael Opdenacker
2008-01-18 3:16 ` Taral
2008-01-18 8:22 ` Michael Opdenacker
2008-01-19 7:21 ` Taral
2008-01-18 11:02 ` [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling Ingo Molnar
2008-01-18 12:14 ` Michael Opdenacker [this message]
2008-01-18 12:25 ` Ingo Molnar
2008-01-18 12:29 ` Ingo Molnar
2008-01-18 13:03 ` Michael Opdenacker
2008-01-18 13:50 ` Matt Mackall
2008-01-18 13:57 ` Ingo Molnar
2008-01-18 14:04 ` Matt Mackall
2008-01-18 16:29 ` Michael Opdenacker
2008-01-18 17:10 ` Matt Mackall
2008-01-18 21:09 ` Ingo Molnar
2008-01-18 22:39 ` Matt Mackall
2008-01-22 14:39 ` Ingo Molnar
2008-01-22 16:37 ` Matt Mackall
2008-01-22 18:58 ` Sam Ravnborg
2008-01-22 19:17 ` Matt Mackall
2008-01-20 4:59 ` Rob Landley
2008-01-20 16:44 ` Matt Mackall
2008-01-21 15:31 ` Michael Opdenacker
2008-01-23 22:30 ` Michael Opdenacker
2008-01-24 17:09 ` [PATCH] x86: fix?unconditional?arch/x86/kernel/pcspeaker.c?compiling Adrian Bunk
2008-01-24 20:12 ` [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling Dmitri Vorobiev
2008-01-25 16:09 ` Ralf Baechle
2008-01-20 12:25 ` Rob Landley
2008-01-17 22:44 ` [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c compiling Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47909821.1090907@free-electrons.com \
--to=michael-lists@free-electrons.com \
--cc=Linux-tiny@selenic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).