Re: [PATCH] x86: fix unconditional arch/x86/kernel/pcspeaker.c?compiling

From: Michael Opdenacker <michael-lists@free-electrons.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, Linux-tiny@selenic.com,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: fix	unconditional	arch/x86/kernel/pcspeaker.c?compiling
Date: Fri, 18 Jan 2008 17:29:23 +0100	[thread overview]
Message-ID: <4790D3E3.4060409@free-electrons.com> (raw)
In-Reply-To: <1200664214.4001.24.camel@cinder.waste.org>

On 01/18/2008 02:50 PM, Matt Mackall wrote:
> On Fri, 2008-01-18 at 14:03 +0100, Michael Opdenacker wrote:
>   
>> However, wouldn't the Makefile look nicer if we introduced a
>> CONFIG_PCSPEAKER setting as in the mips platform? We would just have:
>>
>> obj-$(CONFIG_PCSPEAKER)		+= pcspeaker.o
>>     
>
> Yes, that would be cleaner. Not worth it for just x86, but there are
> about 6 other arches that use CONFIG_INPUT_PCSPKR. Do that in one patch
> on top of this one and send it to Andrew (who will pull the above into
> his tree from Ingo shortly).
>   
Well, sorry for consuming your time with this very small change, but I'm
not sure I understand what you're suggesting... Here's what I'd do:

    * I'd define  CONFIG_PCSPEAKER for x86 (typically in
      arch/x86/Kconfig), to be set to "y"  when CONFIG_INPUT_SPKR is
      set. This is what minimizes the changes to make.
    * This way, we can just have:
      obj-$(CONFIG_PCSPEAKER) += pcspeaker.o

Did I understand things right? Anyway, the current situation is not so
bad either.
> Also, bear in mind that there is a fair amount of lower-hanging fruit
> than this, so bouncing a bunch of patches back and forth to make this
> perfect is not the best use of people's time.
>   
Sounds fine! Don't hesitate to let us know about the lower-hanging fruit
you're thinking about. Here are the main things I have so far:

    * Ideas in the existing Linux-Tiny patchset.
    * Disable support for non-Intel processors in x86 (cyrix.c,
      centaur.c, transmeta.c, nexgen.c, umc.c in arch/x86/kernel/cpu).
      As far as I remember, I saved 15 KB when I first experimented with
      this).
    * Disable support for readahead, page writeback, pdflush and swap
      when we have no storage at all (typically booting from an
      initramfs). This corresponds to 69 KB of source code!

So, more ideas are welcome!

Thanks for your time,

Michael.

-- 
Michael Opdenacker, Free Electrons
Free Embedded Linux Training Materials
on http://free-electrons.com/training
(More than 1500 pages!)