From: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
To: shuah@kernel.org, linux-kselftest@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
tony.luck@intel.com, reinette.chatre@intel.com,
babu.moger@amd.com, james.morse@arm.com,
ravi.v.shankar@intel.com, fenghua.yu@intel.com, x86@kernel.org,
linux-kernel@vger.kernel.org,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Subject: [PATCH V1 08/13] selftests/resctrl: Fix typos
Date: Fri, 6 Mar 2020 19:40:49 -0800 [thread overview]
Message-ID: <4800d93350b5bdfa52cc99f2420e0d629b1dec78.1583657204.git.sai.praneeth.prakhya@intel.com> (raw)
In-Reply-To: <cover.1583657204.git.sai.praneeth.prakhya@intel.com>
No functional changes intended
1. Schemata is spelled wrongly in a comment in mbm_test, fix it.
2. Fix incorrect commenting style in cache.c, fill_buf.c
3. Remove extra space while initializing struct resctrl_val_param in
mbm_test.c
Signed-off-by: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
---
tools/testing/selftests/resctrl/cache.c | 10 +++-------
tools/testing/selftests/resctrl/fill_buf.c | 3 ++-
tools/testing/selftests/resctrl/mbm_test.c | 4 ++--
3 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/tools/testing/selftests/resctrl/cache.c b/tools/testing/selftests/resctrl/cache.c
index 1cbcd7fbe216..be60d7d3f066 100644
--- a/tools/testing/selftests/resctrl/cache.c
+++ b/tools/testing/selftests/resctrl/cache.c
@@ -179,9 +179,7 @@ int measure_cache_vals(struct resctrl_val_param *param, int bm_pid)
unsigned long llc_perf_miss = 0, llc_occu_resc = 0, llc_value = 0;
int ret;
- /*
- * Measure cache miss from perf.
- */
+ /* Measure cache miss from perf */
if (!strcmp(param->resctrl_val, "cat")) {
ret = get_llc_perf(&llc_perf_miss);
if (ret < 0)
@@ -189,9 +187,7 @@ int measure_cache_vals(struct resctrl_val_param *param, int bm_pid)
llc_value = llc_perf_miss;
}
- /*
- * Measure llc occupancy from resctrl.
- */
+ /* Measure llc occupancy from resctrl */
if (!strcmp(param->resctrl_val, "cqm")) {
ret = get_llc_occu_resctrl(&llc_occu_resc);
if (ret < 0)
@@ -228,7 +224,7 @@ int cat_val(struct resctrl_val_param *param)
if (ret)
return ret;
- /* Write benchmark to specified con_mon grp, mon_grp in resctrl FS*/
+ /* Write benchmark to specified con_mon grp, mon_grp in resctrl FS */
ret = write_bm_pid_to_resctrl(bm_pid, param->ctrlgrp, param->mongrp,
resctrl_val);
if (ret)
diff --git a/tools/testing/selftests/resctrl/fill_buf.c b/tools/testing/selftests/resctrl/fill_buf.c
index 84d2a8b9657a..9ede7b63f059 100644
--- a/tools/testing/selftests/resctrl/fill_buf.c
+++ b/tools/testing/selftests/resctrl/fill_buf.c
@@ -54,7 +54,8 @@ static void mem_flush(void *p, size_t s)
char *cp = (char *)p;
size_t i = 0;
- s = s / CL_SIZE; /* mem size in cache llines */
+ /* mem size in cache lines */
+ s = s / CL_SIZE;
for (i = 0; i < s; i++)
cl_flush(&cp[i * CL_SIZE]);
diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c
index 9e847641516a..b64906f1b34f 100644
--- a/tools/testing/selftests/resctrl/mbm_test.c
+++ b/tools/testing/selftests/resctrl/mbm_test.c
@@ -93,7 +93,7 @@ static int mbm_setup(struct resctrl_val_param *p)
if (num_of_runs++ >= NUM_OF_RUNS)
return -1;
- /* Set up shemata with 100% allocation on the first run. */
+ /* Set up schemata with 100% allocation on the first run */
if (num_of_runs == 0)
ret = write_schemata(p->ctrlgrp, "100", p->cpu_no,
p->resctrl_val);
@@ -116,7 +116,7 @@ int mbm_bw_change(int span, int cpu_no, char *bw_report, char **benchmark_cmd)
.cpu_no = cpu_no,
.mum_resctrlfs = 1,
.filename = RESULT_FILE_NAME,
- .bw_report = bw_report,
+ .bw_report = bw_report,
.setup = mbm_setup
};
int ret;
--
2.7.4
next prev parent reply other threads:[~2020-03-07 3:46 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 3:40 [PATCH V1 00/13] Miscellaneous fixes for resctrl selftests Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 01/13] selftests/resctrl: Fix feature detection Sai Praneeth Prakhya
2020-03-09 21:44 ` Reinette Chatre
2020-03-09 22:22 ` Prakhya, Sai Praneeth
2020-03-09 22:33 ` Reinette Chatre
2020-03-09 22:51 ` Prakhya, Sai Praneeth
2020-03-11 18:06 ` Reinette Chatre
2020-03-11 18:22 ` Sai Praneeth Prakhya
2020-03-11 18:45 ` Reinette Chatre
2020-03-11 18:54 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 02/13] selftests/resctrl: Fix typo Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 03/13] selftests/resctrl: Fix typo in help text Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 04/13] selftests/resctrl: Ensure sibling CPU is not same as original CPU Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 05/13] selftests/resctrl: Fix missing options "-n" and "-p" Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 06/13] selftests/resctrl: Fix MBA/MBM results reporting format Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 07/13] selftests/resctrl: Don't use variable argument list for setup function Sai Praneeth Prakhya
2020-03-07 3:40 ` Sai Praneeth Prakhya [this message]
2020-03-07 3:40 ` [PATCH V1 09/13] selftests/resctrl: Modularize fill_buf for new CAT test case Sai Praneeth Prakhya
2020-03-10 21:59 ` Reinette Chatre
2020-03-11 1:04 ` Sai Praneeth Prakhya
2020-03-11 15:44 ` Reinette Chatre
2020-03-11 17:45 ` Sai Praneeth Prakhya
2020-03-11 18:10 ` Reinette Chatre
2020-03-11 18:14 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 10/13] selftests/resctrl: Change Cache Allocation Technology (CAT) test Sai Praneeth Prakhya
2020-03-10 22:14 ` Reinette Chatre
2020-03-11 1:59 ` Sai Praneeth Prakhya
2020-03-11 17:03 ` Reinette Chatre
2020-03-11 19:14 ` Sai Praneeth Prakhya
2020-03-11 20:22 ` Reinette Chatre
2020-03-11 20:55 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 11/13] selftests/resctrl: Change Cache Quality Monitoring (CQM) test Sai Praneeth Prakhya
2020-03-10 22:18 ` Reinette Chatre
2020-03-11 2:46 ` Sai Praneeth Prakhya
2020-03-11 17:19 ` Reinette Chatre
2020-03-11 17:33 ` Sai Praneeth Prakhya
2020-03-11 18:03 ` Reinette Chatre
2020-03-11 18:07 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 12/13] selftests/resctrl: Dynamically select buffer size for CAT test Sai Praneeth Prakhya
2020-03-10 22:19 ` Reinette Chatre
2020-03-11 2:52 ` Sai Praneeth Prakhya
2020-03-07 3:40 ` [PATCH V1 13/13] selftests/resctrl: Cleanup fill_buff after changing " Sai Praneeth Prakhya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4800d93350b5bdfa52cc99f2420e0d629b1dec78.1583657204.git.sai.praneeth.prakhya@intel.com \
--to=sai.praneeth.prakhya@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=fenghua.yu@intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).