* Re: [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON
2008-08-18 22:34 [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON roel kluin
@ 2008-08-18 21:42 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2008-08-18 21:42 UTC (permalink / raw)
To: roel kluin; +Cc: paulus, linuxppc-dev, linux-kernel
On Mon, 2008-08-18 at 18:34 -0400, roel kluin wrote:
> untested, is it correct?
Your patch is correct. The bug is quite harmless thankfully :-)
Ben.
> arch/powerpc/include/asm/pmac_feature.h:359:
> #define MACIO_FLAG_SCCA_ON 0x00000001
> #define MACIO_FLAG_SCCB_ON 0x00000002
> ---
> duplicate test of MACIO_FLAG_SCCB_ON
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 5169ecc..e6c0040 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
> macio_chips[i].of_node = node;
> macio_chips[i].type = type;
> macio_chips[i].base = base;
> - macio_chips[i].flags = MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
> + macio_chips[i].flags = MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
> macio_chips[i].name = macio_names[type];
> revp = of_get_property(node, "revision-id", NULL);
> if (revp)
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON
@ 2008-08-18 22:34 roel kluin
2008-08-18 21:42 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-08-18 22:34 UTC (permalink / raw)
To: paulus, benh, linuxppc-dev, linux-kernel
untested, is it correct?
arch/powerpc/include/asm/pmac_feature.h:359:
#define MACIO_FLAG_SCCA_ON 0x00000001
#define MACIO_FLAG_SCCB_ON 0x00000002
---
duplicate test of MACIO_FLAG_SCCB_ON
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index 5169ecc..e6c0040 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c
@@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
macio_chips[i].of_node = node;
macio_chips[i].type = type;
macio_chips[i].base = base;
- macio_chips[i].flags = MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
+ macio_chips[i].flags = MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
macio_chips[i].name = macio_names[type];
revp = of_get_property(node, "revision-id", NULL);
if (revp)
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-18 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-08-18 22:34 [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON roel kluin
2008-08-18 21:42 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).