* [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
@ 2021-02-19 8:45 Jason Wang
2021-02-19 10:12 ` Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Jason Wang @ 2021-02-19 8:45 UTC (permalink / raw)
To: mst, jasowang
Cc: virtualization, linux-kernel, Arnd Bergmann, Anders Roxell,
Guenter Roeck
We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
lot of confusion. E.g it may break various default configs which want
virtio devices.
So this patch fixes this by hide the prompot and document the
dependency.
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Anders Roxell <anders.roxell@linaro.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
drivers/virtio/Kconfig | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
index 6b9b81f4b8c2..be7df369bc2b 100644
--- a/drivers/virtio/Kconfig
+++ b/drivers/virtio/Kconfig
@@ -13,12 +13,12 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
VIRTIO_F_ACCESS_PLATFORM
config VIRTIO_PCI_MODERN
- tristate "Modern Virtio PCI Device"
- depends on PCI
+ tristate
help
Modern PCI device implementation. This module implements the
basic probe and control for devices which are based on modern
- PCI device with possible vendor specific extensions.
+ PCI device with possible vendor specific extensions. Any
+ module that selects this module must depend on PCI.
menuconfig VIRTIO_MENU
bool "Virtio drivers"
@@ -28,7 +28,8 @@ if VIRTIO_MENU
config VIRTIO_PCI
tristate "PCI driver for virtio devices"
- depends on VIRTIO_PCI_MODERN
+ depends on PCI
+ select VIRTIO_PCI_MODERN
select VIRTIO
help
This driver provides support for virtio based paravirtual device
--
2.18.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-19 8:45 [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN Jason Wang
@ 2021-02-19 10:12 ` Arnd Bergmann
2021-02-22 3:41 ` Jason Wang
2021-02-19 10:13 ` Christoph Hellwig
2021-02-19 15:38 ` Guenter Roeck
2 siblings, 1 reply; 9+ messages in thread
From: Arnd Bergmann @ 2021-02-19 10:12 UTC (permalink / raw)
To: Jason Wang
Cc: Michael S. Tsirkin, virtualization, linux-kernel, Arnd Bergmann,
Anders Roxell, Guenter Roeck
On Fri, Feb 19, 2021 at 9:45 AM Jason Wang <jasowang@redhat.com> wrote:
>
> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
> lot of confusion. E.g it may break various default configs which want
> virtio devices.
>
> So this patch fixes this by hide the prompot and document the
> dependency.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Anders Roxell <anders.roxell@linaro.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Note that this effectively makes VIRTIO_PCI_MODERN and VIRTIO_PCI
synonyms, so git goes back to not being able to have VIRTIO_PCI_MODERN
by itself, but it seems that this is ok because the legacy part was already
split out.
Arnd
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-19 10:12 ` Arnd Bergmann
@ 2021-02-22 3:41 ` Jason Wang
0 siblings, 0 replies; 9+ messages in thread
From: Jason Wang @ 2021-02-22 3:41 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Michael S. Tsirkin, virtualization, linux-kernel, Arnd Bergmann,
Anders Roxell, Guenter Roeck
On 2021/2/19 6:12 下午, Arnd Bergmann wrote:
> On Fri, Feb 19, 2021 at 9:45 AM Jason Wang <jasowang@redhat.com> wrote:
>> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
>> lot of confusion. E.g it may break various default configs which want
>> virtio devices.
>>
>> So this patch fixes this by hide the prompot and document the
>> dependency.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Anders Roxell <anders.roxell@linaro.org>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Note that this effectively makes VIRTIO_PCI_MODERN and VIRTIO_PCI
> synonyms, so git goes back to not being able to have VIRTIO_PCI_MODERN
> by itself, but it seems that this is ok because the legacy part was already
> split out.
There will be a vDPA driver that will select VIRTIO_PCI_MODERN_DEV. It
used to belong to one large sereis, but it was not merged since it needs
some rebase.
Thanks
>
> Arnd
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-19 8:45 [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN Jason Wang
2021-02-19 10:12 ` Arnd Bergmann
@ 2021-02-19 10:13 ` Christoph Hellwig
2021-02-20 1:51 ` Jason Wang
2021-02-19 15:38 ` Guenter Roeck
2 siblings, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2021-02-19 10:13 UTC (permalink / raw)
To: Jason Wang
Cc: mst, virtualization, linux-kernel, Arnd Bergmann, Anders Roxell,
Guenter Roeck
On Fri, Feb 19, 2021 at 03:45:09AM -0500, Jason Wang wrote:
> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
> lot of confusion. E.g it may break various default configs which want
> virtio devices.
>
> So this patch fixes this by hide the prompot and document the
> dependency.
Is there any good reason to keep the symbol at all?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-19 10:13 ` Christoph Hellwig
@ 2021-02-20 1:51 ` Jason Wang
0 siblings, 0 replies; 9+ messages in thread
From: Jason Wang @ 2021-02-20 1:51 UTC (permalink / raw)
To: Christoph Hellwig
Cc: mst, virtualization, linux-kernel, Arnd Bergmann, Anders Roxell,
Guenter Roeck
On 2021/2/19 6:13 下午, Christoph Hellwig wrote:
> On Fri, Feb 19, 2021 at 03:45:09AM -0500, Jason Wang wrote:
>> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
>> lot of confusion. E.g it may break various default configs which want
>> virtio devices.
>>
>> So this patch fixes this by hide the prompot and document the
>> dependency.
> Is there any good reason to keep the symbol at all?
>
The plan is to convert IFCVF driver to use this module (select it).
Thanks
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-19 8:45 [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN Jason Wang
2021-02-19 10:12 ` Arnd Bergmann
2021-02-19 10:13 ` Christoph Hellwig
@ 2021-02-19 15:38 ` Guenter Roeck
2021-02-22 3:42 ` Jason Wang
2 siblings, 1 reply; 9+ messages in thread
From: Guenter Roeck @ 2021-02-19 15:38 UTC (permalink / raw)
To: Jason Wang, mst
Cc: virtualization, linux-kernel, Arnd Bergmann, Anders Roxell
On 2/19/21 12:45 AM, Jason Wang wrote:
> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
> lot of confusion. E.g it may break various default configs which want
> virtio devices.
>
> So this patch fixes this by hide the prompot and document the
... by hiding the prompt and documenting ...
> dependency.
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Anders Roxell <anders.roxell@linaro.org>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/virtio/Kconfig | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 6b9b81f4b8c2..be7df369bc2b 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -13,12 +13,12 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> VIRTIO_F_ACCESS_PLATFORM
>
> config VIRTIO_PCI_MODERN
> - tristate "Modern Virtio PCI Device"
> - depends on PCI
> + tristate
> help
> Modern PCI device implementation. This module implements the
> basic probe and control for devices which are based on modern
> - PCI device with possible vendor specific extensions.
> + PCI device with possible vendor specific extensions. Any
> + module that selects this module must depend on PCI.
>
> menuconfig VIRTIO_MENU
> bool "Virtio drivers"
> @@ -28,7 +28,8 @@ if VIRTIO_MENU
>
> config VIRTIO_PCI
> tristate "PCI driver for virtio devices"
> - depends on VIRTIO_PCI_MODERN
> + depends on PCI
> + select VIRTIO_PCI_MODERN
> select VIRTIO
> help
> This driver provides support for virtio based paravirtual device
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-19 15:38 ` Guenter Roeck
@ 2021-02-22 3:42 ` Jason Wang
2021-02-22 7:29 ` Michael S. Tsirkin
0 siblings, 1 reply; 9+ messages in thread
From: Jason Wang @ 2021-02-22 3:42 UTC (permalink / raw)
To: Guenter Roeck, mst
Cc: virtualization, linux-kernel, Arnd Bergmann, Anders Roxell
On 2021/2/19 11:38 下午, Guenter Roeck wrote:
> On 2/19/21 12:45 AM, Jason Wang wrote:
>> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
>> lot of confusion. E.g it may break various default configs which want
>> virtio devices.
>>
>> So this patch fixes this by hide the prompot and document the
> ... by hiding the prompt and documenting ...
Hi Michael:
Would you like me to post a new version or you can fix those typos when
applying the patch?
Thanks
>
>> dependency.
>>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Cc: Anders Roxell <anders.roxell@linaro.org>
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
>> ---
>> drivers/virtio/Kconfig | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>> index 6b9b81f4b8c2..be7df369bc2b 100644
>> --- a/drivers/virtio/Kconfig
>> +++ b/drivers/virtio/Kconfig
>> @@ -13,12 +13,12 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>> VIRTIO_F_ACCESS_PLATFORM
>>
>> config VIRTIO_PCI_MODERN
>> - tristate "Modern Virtio PCI Device"
>> - depends on PCI
>> + tristate
>> help
>> Modern PCI device implementation. This module implements the
>> basic probe and control for devices which are based on modern
>> - PCI device with possible vendor specific extensions.
>> + PCI device with possible vendor specific extensions. Any
>> + module that selects this module must depend on PCI.
>>
>> menuconfig VIRTIO_MENU
>> bool "Virtio drivers"
>> @@ -28,7 +28,8 @@ if VIRTIO_MENU
>>
>> config VIRTIO_PCI
>> tristate "PCI driver for virtio devices"
>> - depends on VIRTIO_PCI_MODERN
>> + depends on PCI
>> + select VIRTIO_PCI_MODERN
>> select VIRTIO
>> help
>> This driver provides support for virtio based paravirtual device
>>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-22 3:42 ` Jason Wang
@ 2021-02-22 7:29 ` Michael S. Tsirkin
2021-02-22 9:06 ` Jason Wang
0 siblings, 1 reply; 9+ messages in thread
From: Michael S. Tsirkin @ 2021-02-22 7:29 UTC (permalink / raw)
To: Jason Wang
Cc: Guenter Roeck, virtualization, linux-kernel, Arnd Bergmann,
Anders Roxell
On Mon, Feb 22, 2021 at 11:42:44AM +0800, Jason Wang wrote:
>
> On 2021/2/19 11:38 下午, Guenter Roeck wrote:
> > On 2/19/21 12:45 AM, Jason Wang wrote:
> > > We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
> > > lot of confusion. E.g it may break various default configs which want
> > > virtio devices.
> > >
> > > So this patch fixes this by hide the prompot and document the
> > ... by hiding the prompt and documenting ...
>
>
> Hi Michael:
>
> Would you like me to post a new version or you can fix those typos when
> applying the patch?
>
> Thanks
A new version. However I have a suggestion.
How about we call the new library VIRTIO_PCI_LIB? That would be
a new auto-selected symbol.
We can then keep VIRTIO_PCI as a symbol enabling the actual driver.
>
> >
> > > dependency.
> > >
> > > Cc: Arnd Bergmann <arnd@arndb.de>
> > > Cc: Anders Roxell <anders.roxell@linaro.org>
> > > Cc: Guenter Roeck <linux@roeck-us.net>
> > > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > > Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
> > > Signed-off-by: Jason Wang <jasowang@redhat.com>
> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> >
> > > ---
> > > drivers/virtio/Kconfig | 9 +++++----
> > > 1 file changed, 5 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > > index 6b9b81f4b8c2..be7df369bc2b 100644
> > > --- a/drivers/virtio/Kconfig
> > > +++ b/drivers/virtio/Kconfig
> > > @@ -13,12 +13,12 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
> > > VIRTIO_F_ACCESS_PLATFORM
> > > config VIRTIO_PCI_MODERN
> > > - tristate "Modern Virtio PCI Device"
> > > - depends on PCI
> > > + tristate
> > > help
> > > Modern PCI device implementation. This module implements the
> > > basic probe and control for devices which are based on modern
> > > - PCI device with possible vendor specific extensions.
> > > + PCI device with possible vendor specific extensions. Any
> > > + module that selects this module must depend on PCI.
> > > menuconfig VIRTIO_MENU
> > > bool "Virtio drivers"
> > > @@ -28,7 +28,8 @@ if VIRTIO_MENU
> > > config VIRTIO_PCI
> > > tristate "PCI driver for virtio devices"
> > > - depends on VIRTIO_PCI_MODERN
> > > + depends on PCI
> > > + select VIRTIO_PCI_MODERN
> > > select VIRTIO
> > > help
> > > This driver provides support for virtio based paravirtual device
> > >
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
2021-02-22 7:29 ` Michael S. Tsirkin
@ 2021-02-22 9:06 ` Jason Wang
0 siblings, 0 replies; 9+ messages in thread
From: Jason Wang @ 2021-02-22 9:06 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Guenter Roeck, virtualization, linux-kernel, Arnd Bergmann,
Anders Roxell
On 2021/2/22 3:29 下午, Michael S. Tsirkin wrote:
> On Mon, Feb 22, 2021 at 11:42:44AM +0800, Jason Wang wrote:
>> On 2021/2/19 11:38 下午, Guenter Roeck wrote:
>>> On 2/19/21 12:45 AM, Jason Wang wrote:
>>>> We used to prompt CONFIG_VIRTIO_PCI_MODERN to user which may bring a
>>>> lot of confusion. E.g it may break various default configs which want
>>>> virtio devices.
>>>>
>>>> So this patch fixes this by hide the prompot and document the
>>> ... by hiding the prompt and documenting ...
>>
>> Hi Michael:
>>
>> Would you like me to post a new version or you can fix those typos when
>> applying the patch?
>>
>> Thanks
>
> A new version. However I have a suggestion.
>
> How about we call the new library VIRTIO_PCI_LIB? That would be
> a new auto-selected symbol.
>
> We can then keep VIRTIO_PCI as a symbol enabling the actual driver.
Ok, will do.
Thanks
>
>
>
>>>> dependency.
>>>>
>>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>>> Cc: Anders Roxell <anders.roxell@linaro.org>
>>>> Cc: Guenter Roeck <linux@roeck-us.net>
>>>> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>>>> Fixes: 86b87c9d858b6 ("virtio-pci: introduce modern device module")
>>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>>> ---
>>>> drivers/virtio/Kconfig | 9 +++++----
>>>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
>>>> index 6b9b81f4b8c2..be7df369bc2b 100644
>>>> --- a/drivers/virtio/Kconfig
>>>> +++ b/drivers/virtio/Kconfig
>>>> @@ -13,12 +13,12 @@ config ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS
>>>> VIRTIO_F_ACCESS_PLATFORM
>>>> config VIRTIO_PCI_MODERN
>>>> - tristate "Modern Virtio PCI Device"
>>>> - depends on PCI
>>>> + tristate
>>>> help
>>>> Modern PCI device implementation. This module implements the
>>>> basic probe and control for devices which are based on modern
>>>> - PCI device with possible vendor specific extensions.
>>>> + PCI device with possible vendor specific extensions. Any
>>>> + module that selects this module must depend on PCI.
>>>> menuconfig VIRTIO_MENU
>>>> bool "Virtio drivers"
>>>> @@ -28,7 +28,8 @@ if VIRTIO_MENU
>>>> config VIRTIO_PCI
>>>> tristate "PCI driver for virtio devices"
>>>> - depends on VIRTIO_PCI_MODERN
>>>> + depends on PCI
>>>> + select VIRTIO_PCI_MODERN
>>>> select VIRTIO
>>>> help
>>>> This driver provides support for virtio based paravirtual device
>>>>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-02-22 9:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 8:45 [PATCH] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN Jason Wang
2021-02-19 10:12 ` Arnd Bergmann
2021-02-22 3:41 ` Jason Wang
2021-02-19 10:13 ` Christoph Hellwig
2021-02-20 1:51 ` Jason Wang
2021-02-19 15:38 ` Guenter Roeck
2021-02-22 3:42 ` Jason Wang
2021-02-22 7:29 ` Michael S. Tsirkin
2021-02-22 9:06 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).