[PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

[PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

[Greg Gallagher]

Fix warnings generated by checkpatch.pl for alignment should match open
parenthesis.  This is a coding style change only.

Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
---
Changes in v2:
    - Clean up all the alignment warnings in the file
---
 .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
index ec468d5719b1..8af303e25036 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c
@@ -94,7 +94,7 @@ static int snd_bcm2835_ctl_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_ctl_put(struct snd_kcontrol *kcontrol,
-				struct snd_ctl_elem_value *ucontrol)
+			       struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	int changed = 0;
@@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = {
 };
 
 static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+					  struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;
@@ -182,7 +182,7 @@ static int snd_bcm2835_spdif_default_info(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					 struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	int i;
@@ -199,7 +199,7 @@ static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					 struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	unsigned int val = 0;
@@ -219,7 +219,7 @@ static int snd_bcm2835_spdif_default_put(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_mask_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+				       struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;
@@ -227,7 +227,7 @@ static int snd_bcm2835_spdif_mask_info(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+				      struct snd_ctl_elem_value *ucontrol)
 {
 	/*
 	 * bcm2835 supports only consumer mode and sets all other format flags
@@ -238,7 +238,7 @@ static int snd_bcm2835_spdif_mask_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_stream_info(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_info *uinfo)
+					 struct snd_ctl_elem_info *uinfo)
 {
 	uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958;
 	uinfo->count = 1;
@@ -246,7 +246,7 @@ static int snd_bcm2835_spdif_stream_info(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_stream_get(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	int i;
@@ -263,7 +263,7 @@ static int snd_bcm2835_spdif_stream_get(struct snd_kcontrol *kcontrol,
 }
 
 static int snd_bcm2835_spdif_stream_put(struct snd_kcontrol *kcontrol,
-	struct snd_ctl_elem_value *ucontrol)
+					struct snd_ctl_elem_value *ucontrol)
 {
 	struct bcm2835_chip *chip = snd_kcontrol_chip(kcontrol);
 	unsigned int val = 0;
-- 
2.14.1

Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

[Greg Kroah-Hartman]

On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
> Fix warnings generated by checkpatch.pl for alignment should match open
> parenthesis.  This is a coding style change only.
> 
> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
> ---
> Changes in v2:
>     - Clean up all the alignment warnings in the file
> ---
>  .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

You sent 2 patches that did the same thing, with different subjects :(

Please fix up and send only the "correct" one.

greg k-h

Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

[Greg Gallagner]

On 08/08/2018 08:26 AM, Greg Kroah-Hartman wrote:
> On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
>> Fix warnings generated by checkpatch.pl for alignment should match open
>> parenthesis.  This is a coding style change only.
>>
>> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
>> ---
>> Changes in v2:
>>     - Clean up all the alignment warnings in the file
>> ---
>>  .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
> You sent 2 patches that did the same thing, with different subjects :(
>
> Please fix up and send only the "correct" one.
>
> greg k-h
Sorry, the first one was a mistake and I should have sent something saying
to ignore it.  I will double check the second one is correct.  Is there
a best
practice when I'd like a patch ignored?

thanks

Greg

Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

[Greg Kroah-Hartman]

On Wed, Aug 08, 2018 at 08:54:49AM -0400, Greg Gallagner wrote:
> On 08/08/2018 08:26 AM, Greg Kroah-Hartman wrote:
> > On Tue, Aug 07, 2018 at 09:40:47PM -0400, Greg Gallagher wrote:
> >> Fix warnings generated by checkpatch.pl for alignment should match open
> >> parenthesis.  This is a coding style change only.
> >>
> >> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>
> >> ---
> >> Changes in v2:
> >>     - Clean up all the alignment warnings in the file
> >> ---
> >>  .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
> >>  1 file changed, 9 insertions(+), 9 deletions(-)
> > You sent 2 patches that did the same thing, with different subjects :(
> >
> > Please fix up and send only the "correct" one.
> >
> > greg k-h
> Sorry, the first one was a mistake and I should have sent something saying
> to ignore it.  I will double check the second one is correct.  Is there
> a best
> practice when I'd like a patch ignored?

Just respond to the email and say "please ignore this patch" or
something like that.

thanks,
greg k-h

Re: [PATCH v2] staging/bcm2835-audio: Fix alignment of function arguments - Style

[Stefan Wahren]

> Greg Gallagher <greg@embeddedgreg.com> hat am 8. August 2018 um 03:40 geschrieben:
> 
> 
> Fix warnings generated by checkpatch.pl for alignment should match open
> parenthesis.  This is a coding style change only.
> 
> Signed-off-by: Greg Gallagher <greg@embeddedgreg.com>

Acked-by: Stefan Wahren <stefan.wahren@i2se.com>