linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* WARNING: at net/mac80211/rx.c:2234 __ieee80211_rx+0x7f/0x559 [mac80211]()
@ 2009-01-06 17:07 Dhaval Giani
  2009-01-07 13:51 ` [PATCH 1/1] ath5k: fix hw rate index condition Jiri Slaby
  0 siblings, 1 reply; 22+ messages in thread
From: Dhaval Giani @ 2009-01-06 17:07 UTC (permalink / raw)
  To: linville, davem; +Cc: lkml

Hi,

I see this on current git. Not sure how to reproduce it, has happened on
two random occasions. At both times, I was not connected to a wireless
network, but to wired networks.

------------[ cut here ]------------
WARNING: at net/mac80211/rx.c:2234 __ieee80211_rx+0x7f/0x559
[mac80211]()
Hardware name: 2007CS3
Modules linked in: tun fuse radeon drm ipt_MASQUERADE iptable_nat nf_nat
bridge stp bnep sco l2cap bluetooth ip6t_REJECT nf_conntrack_ipv6
ip6table_filter ip6_tables ipv6 cpufreq_ondemand acpi_cpufreq
dm_multipath kvm_intel kvm uinput snd_hda_codec_analog snd_hda_intel
snd_hd
a_codec snd_hwdep snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq
arc4 snd_seq_device ecb snd_pcm_oss ath5k mac80211 snd_mixer_oss
thinkpad_acpi snd_pcm rfkill hwmon snd_timer i2c_i801 snd iTCO_wdt
yenta_socket pcspkr joydev nsc_ircc i2c_core iTCO_vendor_support
rsrc_non
static cfg80211 soundcore irda snd_page_alloc video output crc_ccitt
[last unloaded: scsi_wait_scan]
Pid: 0, comm: swapper Not tainted 2.6.28 #5
Call Trace:
 [<c043180f>] warn_slowpath+0x76/0xad
 [<c04512d8>] ? __lock_acquire+0xb3b/0xb4a
 [<c044f3bd>] ? trace_hardirqs_off+0xb/0xd
 [<f80d4192>] __ieee80211_rx+0x7f/0x559 [mac80211]
 [<f80a19f4>] ath5k_tasklet_rx+0x4f7/0x53b [ath5k]
 [<c06f6edb>] ? _spin_unlock_irq+0x27/0x34
 [<c04360fc>] tasklet_action+0x84/0xef
 [<c0436802>] __do_softirq+0x9d/0x157
 [<c0436765>] ? __do_softirq+0x0/0x157
 <IRQ>  [<c0470e78>] ? handle_fasteoi_irq+0x0/0xb6
 [<c0436493>] ? irq_exit+0x49/0x85
 [<c04055df>] ? do_IRQ+0xf5/0x10b
 [<c04042ac>] ? common_interrupt+0x2c/0x34
 [<c045017e>] ? trace_hardirqs_on+0xb/0xd
 [<c045007b>] ? trace_hardirqs_on_caller+0x5c/0x154
 [<c058cf89>] ? acpi_idle_enter_bm+0x281/0x2d0
 [<c0665273>] ? cpuidle_idle_call+0x65/0x96
 [<c0402c96>] ? cpu_idle+0x84/0xae
 [<c06e2e1b>] ? rest_init+0x53/0x55
---[ end trace e5a3692e59279535 ]---

Thanks,
-- 
regards,
Dhaval

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [PATCH 1/1] ath5k: fix hw rate index condition
@ 2009-02-26 22:44 Jiri Slaby
  2009-02-26 23:15 ` Bob Copeland
  0 siblings, 1 reply; 22+ messages in thread
From: Jiri Slaby @ 2009-02-26 22:44 UTC (permalink / raw)
  To: John W. Linville
  Cc: linux-wireless, ath5k-devel, linux-kernel, Jiri Slaby,
	Nick Kossifidis, Luis R. Rodriguez, Bob Copeland

Make sure we print out a warning when the index is out of bounds,
i.e. even on hw_rix == AR5K_MAX_RATES.

Also change to WARN and print text with the reported hw_rix.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Nick Kossifidis <mickflemm@gmail.com>
Cc: Luis R. Rodriguez <lrodriguez@atheros.com>
Cc: Bob Copeland <me@bobcopeland.com>
---
 drivers/net/wireless/ath5k/base.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath5k/base.c b/drivers/net/wireless/ath5k/base.c
index c06d1cc..08d691d 100644
--- a/drivers/net/wireless/ath5k/base.c
+++ b/drivers/net/wireless/ath5k/base.c
@@ -1100,7 +1100,8 @@ ath5k_mode_setup(struct ath5k_softc *sc)
 static inline int
 ath5k_hw_to_driver_rix(struct ath5k_softc *sc, int hw_rix)
 {
-	WARN_ON(hw_rix < 0 || hw_rix > AR5K_MAX_RATES);
+	WARN(hw_rix < 0 || hw_rix >= AR5K_MAX_RATES,
+			"hw_rix out of bounds: %x\n", hw_rix);
 	return sc->rate_idx[sc->curband->band][hw_rix];
 }
 
-- 
1.6.1.3


^ permalink raw reply related	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2009-04-08 15:22 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-01-06 17:07 WARNING: at net/mac80211/rx.c:2234 __ieee80211_rx+0x7f/0x559 [mac80211]() Dhaval Giani
2009-01-07 13:51 ` [PATCH 1/1] ath5k: fix hw rate index condition Jiri Slaby
2009-01-07 14:36   ` Jiri Slaby
2009-01-07 15:22     ` Dhaval Giani
2009-01-07 15:30       ` Jiri Slaby
2009-02-02  7:57         ` Dhaval Giani
2009-02-15 13:47           ` Bob Copeland
2009-02-28 23:08             ` Jiri Slaby
2009-03-30  8:59               ` Dhaval Giani
2009-03-30 16:58                 ` Bob Copeland
2009-03-30 17:59                   ` Dhaval Giani
2009-03-30 18:13                     ` Bob Copeland
2009-03-31  3:51                       ` Dhaval Giani
2009-03-31 12:23                         ` Bob Copeland
2009-04-08 15:22                           ` [ath5k-devel] " Bob Copeland
2009-03-15 21:27     ` Stefan Lippers-Hollmann
2009-03-15 21:35       ` Michael Buesch
2009-03-23  0:45       ` Stefan Lippers-Hollmann
2009-03-23  2:31         ` Bob Copeland
2009-02-26 22:44 Jiri Slaby
2009-02-26 23:15 ` Bob Copeland
2009-02-26 23:19   ` Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).