ANDN and Group 17 in x86-opcode-map.txt

ANDN and Group 17 in x86-opcode-map.txt

[Ulrich Drepper]

The Intel documentation at

http://software.intel.com/file/36945

shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
respectively.  The current version of x86-opcode-map.txt shows them
with f3 and f4.  Unless someone can point to documentation which shows
the currently used encoding the following patch be applied.

Signed-off-by: Ulrich Drepper <drepper@gmail.com>

diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt
index 5b83c51..4c8010d 100644
--- a/arch/x86/lib/x86-opcode-map.txt
+++ b/arch/x86/lib/x86-opcode-map.txt
@@ -729,8 +729,8 @@ de: VAESDEC Vdq,Hdq,Wdq (66),(v1)
 df: VAESDECLAST Vdq,Hdq,Wdq (66),(v1)
 f0: MOVBE Gy,My | MOVBE Gw,Mw (66) | CRC32 Gd,Eb (F2)
 f1: MOVBE My,Gy | MOVBE Mw,Gw (66) | CRC32 Gd,Ey (F2)
-f3: ANDN Gy,By,Ey (v)
-f4: Grp17 (1A)
+f2: ANDN Gy,By,Ey (v)
+f3: Grp17 (1A)
 f5: BZHI Gy,Ey,By (v) | PEXT Gy,By,Ey (F3),(v) | PDEP Gy,By,Ey (F2),(v)
 f6: MULX By,Gy,rDX,Ey (F2),(v)
 f7: BEXTR Gy,Ey,By (v) | SHLX Gy,Ey,By (66),(v) | SARX Gy,Ey,By
(F3),(v) | SHRX Gy,Ey,By (F2),(v)

Re: ANDN and Group 17 in x86-opcode-map.txt

[H. Peter Anvin]

On 01/17/2012 11:14 AM, Ulrich Drepper wrote:
> The Intel documentation at
> 
> http://software.intel.com/file/36945
> 
> shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
> respectively.  The current version of x86-opcode-map.txt shows them
> with f3 and f4.  Unless someone can point to documentation which shows
> the currently used encoding the following patch be applied.
> 
> Signed-off-by: Ulrich Drepper <drepper@gmail.com>
> 

Looks right to me.  Masami, I assume this was just a transcription error?

Acked-by: H. Peter Anvin <hpa@zytor.com>


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

[tip:x86/urgent] x86, opcode: ANDN and Group 17 in x86-opcode-map. txt

[tip-bot for Ulrich Drepper]

Commit-ID:  ce79dac861e0d9a473d9923391bdbaad83c1c57f
Gitweb:     http://git.kernel.org/tip/ce79dac861e0d9a473d9923391bdbaad83c1c57f
Author:     Ulrich Drepper <drepper@gmail.com>
AuthorDate: Tue, 17 Jan 2012 14:14:02 -0500
Committer:  H. Peter Anvin <hpa@zytor.com>
CommitDate: Tue, 17 Jan 2012 12:11:54 -0800

x86, opcode: ANDN and Group 17 in x86-opcode-map.txt

The Intel documentation at

http://software.intel.com/file/36945

shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
respectively.  The current version of x86-opcode-map.txt shows them
with f3 and f4.  Unless someone can point to documentation which shows
the currently used encoding the following patch be applied.

Signed-off-by: Ulrich Drepper <drepper@gmail.com>
Link: http://lkml.kernel.org/r/CAOPLpQdq5SuVo9=023CYhbFLAX9rONyjmYq7jJkqc5xwctW5eA@mail.gmail.com
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
---
 arch/x86/lib/x86-opcode-map.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/lib/x86-opcode-map.txt b/arch/x86/lib/x86-opcode-map.txt
index 5b83c51..4c8010d 100644
--- a/arch/x86/lib/x86-opcode-map.txt
+++ b/arch/x86/lib/x86-opcode-map.txt
@@ -729,8 +729,8 @@ de: VAESDEC Vdq,Hdq,Wdq (66),(v1)
 df: VAESDECLAST Vdq,Hdq,Wdq (66),(v1)
 f0: MOVBE Gy,My | MOVBE Gw,Mw (66) | CRC32 Gd,Eb (F2)
 f1: MOVBE My,Gy | MOVBE Mw,Gw (66) | CRC32 Gd,Ey (F2)
-f3: ANDN Gy,By,Ey (v)
-f4: Grp17 (1A)
+f2: ANDN Gy,By,Ey (v)
+f3: Grp17 (1A)
 f5: BZHI Gy,Ey,By (v) | PEXT Gy,By,Ey (F3),(v) | PDEP Gy,By,Ey (F2),(v)
 f6: MULX By,Gy,rDX,Ey (F2),(v)
 f7: BEXTR Gy,Ey,By (v) | SHLX Gy,Ey,By (66),(v) | SARX Gy,Ey,By (F3),(v) | SHRX Gy,Ey,By (F2),(v)

Re: Re: ANDN and Group 17 in x86-opcode-map.txt

[Masami Hiramatsu]

(2012/01/18 4:21), H. Peter Anvin wrote:
> On 01/17/2012 11:14 AM, Ulrich Drepper wrote:
>> The Intel documentation at
>>
>> http://software.intel.com/file/36945
>>
>> shows the ANDN opcode and Group 17 with encoding f2 and f3 encoding
>> respectively.  The current version of x86-opcode-map.txt shows them
>> with f3 and f4.  Unless someone can point to documentation which shows
>> the currently used encoding the following patch be applied.
>>
>> Signed-off-by: Ulrich Drepper <drepper@gmail.com>
>>
> 
> Looks right to me.  Masami, I assume this was just a transcription error?
> 
> Acked-by: H. Peter Anvin <hpa@zytor.com>

Oh! right, it must be my typo.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>



-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com