linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: subhashj@codeaurora.org
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Zang Leigang <zangleigang@hisilicon.com>,
	vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR
Date: Wed, 28 Sep 2016 15:42:18 -0700	[thread overview]
Message-ID: <4c55deca663895cd8b8843ef51b2ec73@codeaurora.org> (raw)
In-Reply-To: <yq1intgy5at.fsf@sermon.lab.mkp.net>

On 2016-09-27 22:14, Martin K. Petersen wrote:
>>>>>> "Subhash" == subhashj  <subhashj@codeaurora.org> writes:
> 
> Subhash> Looks good to me.
> 
>> -	/* Data segment length */
>> -	ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
>> -			0, 0, len >> 8, (u8)len);
>> +	/* Data segment length only need for WRITE_DESC */
>> +	if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
>> +		ucd_req_ptr->header.dword_2 =
>> +			UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
>> +	else
>> +		ucd_req_ptr->header.dword_2 = 0;
> 
> What about READ_DESC?

This patch is changing the value written to "Data Segment Length" field 
in the Basic header section of Query Request UPIU. This is description 
of "Data Segment Length" from UFS device v2.1 spec (JESD220C, 
line#1429-1430): "The Data Segment Length field contains the number of 
valid bytes within the Data Segment of the UPIU". Because we will not be 
sending any data segment in the request UPIU itself for the read 
descriptor hence this field can be zeroed out for descriptor read.
Read length for the "read descriptor" transaction needs to be specified 
(in ) in "LENGTH" of transaction specific fields of query request UPIU.

Thanks,
Subhash

      parent reply	other threads:[~2016-09-28 22:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-25  9:39 [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR Zang Leigang
2016-09-27 22:30 ` subhashj
2016-09-28  5:14   ` Martin K. Petersen
2016-09-28  5:36     ` Kiwoong Kim
2016-09-30  1:36       ` Martin K. Petersen
2016-09-28 22:42     ` subhashj [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c55deca663895cd8b8843ef51b2ec73@codeaurora.org \
    --to=subhashj@codeaurora.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=vinholikatti@gmail.com \
    --cc=zangleigang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).