From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: subhashj@codeaurora.org
Cc: Zang Leigang <zangleigang@hisilicon.com>,
vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR
Date: Wed, 28 Sep 2016 01:14:18 -0400 [thread overview]
Message-ID: <yq1intgy5at.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <9e470819d1cfcead5966e37c00f53967@codeaurora.org> (subhashj@codeaurora.org's message of "Tue, 27 Sep 2016 15:30:22 -0700")
>>>>> "Subhash" == subhashj <subhashj@codeaurora.org> writes:
Subhash> Looks good to me.
> - /* Data segment length */
> - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> - 0, 0, len >> 8, (u8)len);
> + /* Data segment length only need for WRITE_DESC */
> + if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
> + ucd_req_ptr->header.dword_2 =
> + UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
> + else
> + ucd_req_ptr->header.dword_2 = 0;
What about READ_DESC?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-09-28 5:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 9:39 [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR Zang Leigang
2016-09-27 22:30 ` subhashj
2016-09-28 5:14 ` Martin K. Petersen [this message]
2016-09-28 5:36 ` Kiwoong Kim
2016-09-30 1:36 ` Martin K. Petersen
2016-09-28 22:42 ` subhashj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1intgy5at.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).