From: subhashj@codeaurora.org
To: Zang Leigang <zangleigang@hisilicon.com>
Cc: vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR
Date: Tue, 27 Sep 2016 15:30:22 -0700 [thread overview]
Message-ID: <9e470819d1cfcead5966e37c00f53967@codeaurora.org> (raw)
In-Reply-To: <20160825093919.5936-1-zangleigang@hisilicon.com>
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
On 2016-08-25 02:39, Zang Leigang wrote:
> Some device may cause a compatibility issue while receiving a Query
> UPIU
> with Data Segment which does not expected.
>
> Signed-off-by: Zang Leigang <zangleigang@hisilicon.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index f08d41a..9b21d88 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1266,9 +1266,12 @@ static void
> ufshcd_prepare_utp_query_req_upiu(struct ufs_hba *hba,
> ucd_req_ptr->header.dword_1 = UPIU_HEADER_DWORD(
> 0, query->request.query_func, 0, 0);
>
> - /* Data segment length */
> - ucd_req_ptr->header.dword_2 = UPIU_HEADER_DWORD(
> - 0, 0, len >> 8, (u8)len);
> + /* Data segment length only need for WRITE_DESC */
> + if (query->request.upiu_req.opcode == UPIU_QUERY_OPCODE_WRITE_DESC)
> + ucd_req_ptr->header.dword_2 =
> + UPIU_HEADER_DWORD(0, 0, (len >> 8), (u8)len);
> + else
> + ucd_req_ptr->header.dword_2 = 0;
>
> /* Copy the Query Request buffer as is */
> memcpy(&ucd_req_ptr->qr, &query->request.upiu_req,
next prev parent reply other threads:[~2016-09-27 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 9:39 [PATCH v2] UFS: Date Segment only need for WRITE DESCRIPTOR Zang Leigang
2016-09-27 22:30 ` subhashj [this message]
2016-09-28 5:14 ` Martin K. Petersen
2016-09-28 5:36 ` Kiwoong Kim
2016-09-30 1:36 ` Martin K. Petersen
2016-09-28 22:42 ` subhashj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e470819d1cfcead5966e37c00f53967@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vinholikatti@gmail.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).