Re: [PATCH net-next v3 12/12] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY

From: Andrew Lunn <andrew@lunn.ch>
To: Conor Dooley <conor@kernel.org>
Cc: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com,
	anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net,
	linux-doc@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, horatiu.vultur@microchip.com,
	ruanjinjie@huawei.com, steen.hegelund@microchip.com,
	vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com,
	Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com,
	Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com,
	benjamin.bigler@bernformulastudent.ch
Subject: Re: [PATCH net-next v3 12/12] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY
Date: Wed, 6 Mar 2024 19:48:57 +0100	[thread overview]
Message-ID: <4c5968a3-c043-45fc-8fff-2a9eaa6de341@lunn.ch> (raw)
In-Reply-To: <20240306-spree-islamist-957acf0ee368@spud>

> > +description:
> > +  The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet
> > +  PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller
> > +  (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible
> > +  with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver
> > +  integrated into the LAN8650/1. The communication between the Host and
> > +  the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial
> > +  Interface (TC6).
> > +
> > +allOf:
> > +  - $ref: ethernet-controller.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - const: microchip,lan8650
> > +          - const: microchip,lan8651
> 
> The order here is wrong, lan8561 needs to come before the fallback of
> lan8650.

I don't think it is a fallback. There are two devices, and hence two
different compatibles. So i suspect the -items: is wrong here?

	  Andrew