Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking

From: Andrew Lunn <andrew@lunn.ch>
To: Parthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org, saeedm@nvidia.com,
	anthony.l.nguyen@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, corbet@lwn.net,
	linux-doc@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, horatiu.vultur@microchip.com,
	ruanjinjie@huawei.com, steen.hegelund@microchip.com,
	vladimir.oltean@nxp.com, UNGLinuxDriver@microchip.com,
	Thorsten.Kummermehr@microchip.com, Pier.Beruto@onsemi.com,
	Selvamani.Rajagopal@onsemi.com, Nicolas.Ferre@microchip.com,
	benjamin.bigler@bernformulastudent.ch
Subject: Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking
Date: Thu, 7 Mar 2024 01:43:55 +0100	[thread overview]
Message-ID: <ea217697-fdb8-4112-ae84-62f566cdc375@lunn.ch> (raw)
In-Reply-To: <20240306085017.21731-6-Parthiban.Veerasooran@microchip.com>

On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote:
> This will unmask the following error interrupts from the MAC-PHY.
>   tx protocol error
>   rx buffer overflow error
>   loss of frame error

The standard seems to call it "Loss of framing". To me as a network
person, a frame is an L2 Ethernet packet. However, framing is
something completely different, being able to synchronise a bitstream
with some sort of markers, e.g. E1 to know where the 32 slots are.

In this context, we are not talking about packets, but the SPI bit
stream. So it would be good to use framing, not frame.

	Andrew