Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking

From: <Parthiban.Veerasooran@microchip.com>
To: <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <horms@kernel.org>, <saeedm@nvidia.com>,
	<anthony.l.nguyen@intel.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <corbet@lwn.net>,
	<linux-doc@vger.kernel.org>, <robh+dt@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <Horatiu.Vultur@microchip.com>,
	<ruanjinjie@huawei.com>, <Steen.Hegelund@microchip.com>,
	<vladimir.oltean@nxp.com>, <UNGLinuxDriver@microchip.com>,
	<Thorsten.Kummermehr@microchip.com>, <Pier.Beruto@onsemi.com>,
	<Selvamani.Rajagopal@onsemi.com>, <Nicolas.Ferre@microchip.com>,
	<benjamin.bigler@bernformulastudent.ch>
Subject: Re: [PATCH net-next v3 05/12] net: ethernet: oa_tc6: implement error interrupts unmasking
Date: Thu, 7 Mar 2024 08:28:59 +0000	[thread overview]
Message-ID: <9f824a6f-a075-405f-b615-75076061a284@microchip.com> (raw)
In-Reply-To: <ea217697-fdb8-4112-ae84-62f566cdc375@lunn.ch>

Hi Andrew,

On 07/03/24 6:13 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Wed, Mar 06, 2024 at 02:20:10PM +0530, Parthiban Veerasooran wrote:
>> This will unmask the following error interrupts from the MAC-PHY.
>>    tx protocol error
>>    rx buffer overflow error
>>    loss of frame error
> 
> The standard seems to call it "Loss of framing". To me as a network
> person, a frame is an L2 Ethernet packet. However, framing is
> something completely different, being able to synchronise a bitstream
> with some sort of markers, e.g. E1 to know where the 32 slots are.
> 
> In this context, we are not talking about packets, but the SPI bit
> stream. So it would be good to use framing, not frame.
Yes you are right. The specification also says the same thing as you 
said "Loss of Framing Error". I will correct it in the next version.

Best regards,
Parthiban V
> 
>          Andrew
> 