* Re: [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error
2020-03-08 21:51 [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error Dmitry Osipenko
@ 2020-03-09 12:51 ` Andrew F. Davis
2020-03-09 23:06 ` Pali Rohár
2020-03-11 22:14 ` Sebastian Reichel
2 siblings, 0 replies; 5+ messages in thread
From: Andrew F. Davis @ 2020-03-09 12:51 UTC (permalink / raw)
To: Dmitry Osipenko, Pali Rohár, Sebastian Reichel, David Heidelberg
Cc: linux-pm, linux-kernel
On 3/8/20 5:51 PM, Dmitry Osipenko wrote:
> The driver fails to probe with -EPROBE_DEFER if battery's power supply
> (charger driver) isn't ready yet and this results in a bit noisy error
> message in KMSG during kernel's boot up. Let's silence the harmless
> error message.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
Reviewed-by: Andrew F. Davis <afd@ti.com>
> drivers/power/supply/bq27xxx_battery.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 195c18c2f426..664e50103eaa 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1885,7 +1885,10 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)
>
> di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
> if (IS_ERR(di->bat)) {
> - dev_err(di->dev, "failed to register battery\n");
> + if (PTR_ERR(di->bat) == -EPROBE_DEFER)
> + dev_dbg(di->dev, "failed to register battery, deferring probe\n");
> + else
> + dev_err(di->dev, "failed to register battery\n");
> return PTR_ERR(di->bat);
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error
2020-03-08 21:51 [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error Dmitry Osipenko
2020-03-09 12:51 ` Andrew F. Davis
@ 2020-03-09 23:06 ` Pali Rohár
2020-03-10 13:21 ` Dmitry Osipenko
2020-03-11 22:14 ` Sebastian Reichel
2 siblings, 1 reply; 5+ messages in thread
From: Pali Rohár @ 2020-03-09 23:06 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Andrew F. Davis, Sebastian Reichel, David Heidelberg, linux-pm,
linux-kernel
On Monday 09 March 2020 00:51:43 Dmitry Osipenko wrote:
> The driver fails to probe with -EPROBE_DEFER if battery's power supply
> (charger driver) isn't ready yet and this results in a bit noisy error
> message in KMSG during kernel's boot up. Let's silence the harmless
> error message.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Hello Dmitry! This change make sense, it is really not an error when
bq27k device registration is deferred. You can add my:
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
> drivers/power/supply/bq27xxx_battery.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 195c18c2f426..664e50103eaa 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1885,7 +1885,10 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)
>
> di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
> if (IS_ERR(di->bat)) {
> - dev_err(di->dev, "failed to register battery\n");
> + if (PTR_ERR(di->bat) == -EPROBE_DEFER)
> + dev_dbg(di->dev, "failed to register battery, deferring probe\n");
> + else
> + dev_err(di->dev, "failed to register battery\n");
> return PTR_ERR(di->bat);
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error
2020-03-09 23:06 ` Pali Rohár
@ 2020-03-10 13:21 ` Dmitry Osipenko
0 siblings, 0 replies; 5+ messages in thread
From: Dmitry Osipenko @ 2020-03-10 13:21 UTC (permalink / raw)
To: Pali Rohár, Andrew F. Davis
Cc: Sebastian Reichel, David Heidelberg, linux-pm, linux-kernel
10.03.2020 02:06, Pali Rohár пишет:
> On Monday 09 March 2020 00:51:43 Dmitry Osipenko wrote:
>> The driver fails to probe with -EPROBE_DEFER if battery's power supply
>> (charger driver) isn't ready yet and this results in a bit noisy error
>> message in KMSG during kernel's boot up. Let's silence the harmless
>> error message.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>
> Hello Dmitry! This change make sense, it is really not an error when
> bq27k device registration is deferred. You can add my:
>
> Reviewed-by: Pali Rohár <pali@kernel.org>
Thank you and Andrew for taking a look at this patch!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error
2020-03-08 21:51 [PATCH v1] power: supply: bq27xxx_battery: Silence deferred-probe error Dmitry Osipenko
2020-03-09 12:51 ` Andrew F. Davis
2020-03-09 23:06 ` Pali Rohár
@ 2020-03-11 22:14 ` Sebastian Reichel
2 siblings, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2020-03-11 22:14 UTC (permalink / raw)
To: Dmitry Osipenko
Cc: Andrew F. Davis, Pali Rohár, David Heidelberg, linux-pm,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
Hi,
On Mon, Mar 09, 2020 at 12:51:43AM +0300, Dmitry Osipenko wrote:
> The driver fails to probe with -EPROBE_DEFER if battery's power supply
> (charger driver) isn't ready yet and this results in a bit noisy error
> message in KMSG during kernel's boot up. Let's silence the harmless
> error message.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/supply/bq27xxx_battery.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> index 195c18c2f426..664e50103eaa 100644
> --- a/drivers/power/supply/bq27xxx_battery.c
> +++ b/drivers/power/supply/bq27xxx_battery.c
> @@ -1885,7 +1885,10 @@ int bq27xxx_battery_setup(struct bq27xxx_device_info *di)
>
> di->bat = power_supply_register_no_ws(di->dev, psy_desc, &psy_cfg);
> if (IS_ERR(di->bat)) {
> - dev_err(di->dev, "failed to register battery\n");
> + if (PTR_ERR(di->bat) == -EPROBE_DEFER)
> + dev_dbg(di->dev, "failed to register battery, deferring probe\n");
> + else
> + dev_err(di->dev, "failed to register battery\n");
> return PTR_ERR(di->bat);
> }
>
> --
> 2.25.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread