* [PATCH] perf jevents: Silence warning for ArchStd files
@ 2021-05-06 22:56 Ian Rogers
2021-05-07 8:59 ` John Garry
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2021-05-06 22:56 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
John Garry, Kajol Jain, Joakim Zhang, Kim Phillips,
linux-perf-users, linux-kernel
Cc: Ian Rogers
json files in the level 1 directory are used for ArchStd events (see
preprocess_arch_std_files), as such they shouldn't be warned about.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/pmu-events/jevents.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index ed4f0bd72e5a..7422b0ea8790 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -1123,8 +1123,10 @@ static int process_one_file(const char *fpath, const struct stat *sb,
mapfile = strdup(fpath);
return 0;
}
-
- pr_info("%s: Ignoring file %s\n", prog, fpath);
+ if (is_json_file(bname))
+ pr_debug("%s: ArchStd json is preprocessed %s\n", prog, fpath);
+ else
+ pr_info("%s: Ignoring file %s\n", prog, fpath);
return 0;
}
--
2.31.1.607.g51e8a6a459-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] perf jevents: Silence warning for ArchStd files
2021-05-06 22:56 [PATCH] perf jevents: Silence warning for ArchStd files Ian Rogers
@ 2021-05-07 8:59 ` John Garry
2021-05-07 15:46 ` Ian Rogers
0 siblings, 1 reply; 5+ messages in thread
From: John Garry @ 2021-05-07 8:59 UTC (permalink / raw)
To: Ian Rogers, Peter Zijlstra, Ingo Molnar,
Arnaldo Carvalho de Melo, Mark Rutland, Alexander Shishkin,
Jiri Olsa, Namhyung Kim, Kajol Jain, Joakim Zhang, Kim Phillips,
linux-perf-users, linux-kernel
On 06/05/2021 23:56, Ian Rogers wrote:
> json files in the level 1 directory are used for ArchStd events (see
> preprocess_arch_std_files), as such they shouldn't be warned about.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/pmu-events/jevents.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index ed4f0bd72e5a..7422b0ea8790 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -1123,8 +1123,10 @@ static int process_one_file(const char *fpath, const struct stat *sb,
> mapfile = strdup(fpath);
> return 0;
> }
> -
> - pr_info("%s: Ignoring file %s\n", prog, fpath);
> + if (is_json_file(bname))
> + pr_debug("%s: ArchStd json is preprocessed %s\n", prog, fpath)
We could get more elaborate and add the same first debug print in
process_one_file() to preprocess_arch_std_file() to give the allusion
that they are preprocessed, and change the logic not print that for arch
std files (in process_one_file()). But not sure it's worth it.
Or else we could also just omit any print here for archstd files here.
But I suppose what you are doing is ok...
Thanks,
John
> + else
> + pr_info("%s: Ignoring file %s\n", prog, fpath);
> return 0;
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf jevents: Silence warning for ArchStd files
2021-05-07 8:59 ` John Garry
@ 2021-05-07 15:46 ` Ian Rogers
2021-05-07 16:29 ` John Garry
0 siblings, 1 reply; 5+ messages in thread
From: Ian Rogers @ 2021-05-07 15:46 UTC (permalink / raw)
To: John Garry
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Kajol Jain, Joakim Zhang, Kim Phillips, linux-perf-users, LKML
On Fri, May 7, 2021 at 2:00 AM John Garry <john.garry@huawei.com> wrote:
>
> On 06/05/2021 23:56, Ian Rogers wrote:
> > json files in the level 1 directory are used for ArchStd events (see
> > preprocess_arch_std_files), as such they shouldn't be warned about.
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/pmu-events/jevents.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> > index ed4f0bd72e5a..7422b0ea8790 100644
> > --- a/tools/perf/pmu-events/jevents.c
> > +++ b/tools/perf/pmu-events/jevents.c
> > @@ -1123,8 +1123,10 @@ static int process_one_file(const char *fpath, const struct stat *sb,
> > mapfile = strdup(fpath);
> > return 0;
> > }
> > -
> > - pr_info("%s: Ignoring file %s\n", prog, fpath);
> > + if (is_json_file(bname))
> > + pr_debug("%s: ArchStd json is preprocessed %s\n", prog, fpath)
> We could get more elaborate and add the same first debug print in
> process_one_file() to preprocess_arch_std_file() to give the allusion
> that they are preprocessed, and change the logic not print that for arch
> std files (in process_one_file()). But not sure it's worth it.
>
> Or else we could also just omit any print here for archstd files here.
I thought about just dropping the print in the json case but then a
comment would be nice, the pr_debug is a comment and is somewhat
intention revealing. If you think it is overkill then it is ok to
change.
Thanks,
Ian
> But I suppose what you are doing is ok...
>
> Thanks,
> John
>
> > + else
> > + pr_info("%s: Ignoring file %s\n", prog, fpath);
> > return 0;
> > }
> >
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf jevents: Silence warning for ArchStd files
2021-05-07 15:46 ` Ian Rogers
@ 2021-05-07 16:29 ` John Garry
2021-05-08 14:24 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 5+ messages in thread
From: John Garry @ 2021-05-07 16:29 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Kajol Jain, Joakim Zhang, Kim Phillips, linux-perf-users, LKML
On 07/05/2021 16:46, Ian Rogers wrote:
> On Fri, May 7, 2021 at 2:00 AM John Garry<john.garry@huawei.com> wrote:
>> On 06/05/2021 23:56, Ian Rogers wrote:
>>> json files in the level 1 directory are used for ArchStd events (see
>>> preprocess_arch_std_files), as such they shouldn't be warned about.
>>>
>>> Signed-off-by: Ian Rogers<irogers@google.com>
>>> ---
>>> tools/perf/pmu-events/jevents.c | 6 ++++--
>>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
>>> index ed4f0bd72e5a..7422b0ea8790 100644
>>> --- a/tools/perf/pmu-events/jevents.c
>>> +++ b/tools/perf/pmu-events/jevents.c
>>> @@ -1123,8 +1123,10 @@ static int process_one_file(const char *fpath, const struct stat *sb,
>>> mapfile = strdup(fpath);
>>> return 0;
>>> }
>>> -
>>> - pr_info("%s: Ignoring file %s\n", prog, fpath);
>>> + if (is_json_file(bname))
>>> + pr_debug("%s: ArchStd json is preprocessed %s\n", prog, fpath)
>> We could get more elaborate and add the same first debug print in
>> process_one_file() to preprocess_arch_std_file() to give the allusion
>> that they are preprocessed, and change the logic not print that for arch
>> std files (in process_one_file()). But not sure it's worth it.
>>
>> Or else we could also just omit any print here for archstd files here.
> I thought about just dropping the print in the json case but then a
> comment would be nice, the pr_debug is a comment and is somewhat
> intention revealing. If you think it is overkill then it is ok to
> change.
I don't think it's a big deal either way.
Reviewed-by: John Garry <john.garry@huawei.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] perf jevents: Silence warning for ArchStd files
2021-05-07 16:29 ` John Garry
@ 2021-05-08 14:24 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 5+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-05-08 14:24 UTC (permalink / raw)
To: John Garry
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Jiri Olsa, Namhyung Kim, Kajol Jain,
Joakim Zhang, Kim Phillips, linux-perf-users, LKML
Em Fri, May 07, 2021 at 05:29:06PM +0100, John Garry escreveu:
> On 07/05/2021 16:46, Ian Rogers wrote:
> > On Fri, May 7, 2021 at 2:00 AM John Garry<john.garry@huawei.com> wrote:
> > > On 06/05/2021 23:56, Ian Rogers wrote:
> > > > json files in the level 1 directory are used for ArchStd events (see
> > > > preprocess_arch_std_files), as such they shouldn't be warned about.
> > > >
> > > > Signed-off-by: Ian Rogers<irogers@google.com>
> > > > ---
> > > > tools/perf/pmu-events/jevents.c | 6 ++++--
> > > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> > > > index ed4f0bd72e5a..7422b0ea8790 100644
> > > > --- a/tools/perf/pmu-events/jevents.c
> > > > +++ b/tools/perf/pmu-events/jevents.c
> > > > @@ -1123,8 +1123,10 @@ static int process_one_file(const char *fpath, const struct stat *sb,
> > > > mapfile = strdup(fpath);
> > > > return 0;
> > > > }
> > > > -
> > > > - pr_info("%s: Ignoring file %s\n", prog, fpath);
> > > > + if (is_json_file(bname))
> > > > + pr_debug("%s: ArchStd json is preprocessed %s\n", prog, fpath)
> > > We could get more elaborate and add the same first debug print in
> > > process_one_file() to preprocess_arch_std_file() to give the allusion
> > > that they are preprocessed, and change the logic not print that for arch
> > > std files (in process_one_file()). But not sure it's worth it.
> > >
> > > Or else we could also just omit any print here for archstd files here.
> > I thought about just dropping the print in the json case but then a
> > comment would be nice, the pr_debug is a comment and is somewhat
> > intention revealing. If you think it is overkill then it is ok to
> > change.
>
> I don't think it's a big deal either way.
>
> Reviewed-by: John Garry <john.garry@huawei.com>
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-08 14:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 22:56 [PATCH] perf jevents: Silence warning for ArchStd files Ian Rogers
2021-05-07 8:59 ` John Garry
2021-05-07 15:46 ` Ian Rogers
2021-05-07 16:29 ` John Garry
2021-05-08 14:24 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).