linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors
@ 2017-01-26 17:42 Randy Dunlap
  2017-01-27  8:15 ` Kishon Vijay Abraham I
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2017-01-26 17:42 UTC (permalink / raw)
  To: Kishon Vijay Abraham I; +Cc: MyungJoo Ham, Chanwoo Choi, Heiko Stuebner, LKML

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors in phy-rockchip-inno-usb2.c. The driver uses
extcon interfaces so it should depend on EXTCON.

Fixes these build errors:

drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work':
phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to `extcon_get_state'
phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to `extcon_set_state_sync'
phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to `extcon_set_state_sync'
phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to `extcon_get_state'
drivers/built-in.o: In function `rockchip_usb2phy_probe':
phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to `extcon_get_edev_by_phandle'
phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to `devm_extcon_dev_allocate'
phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to `devm_extcon_dev_register'
phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to `extcon_register_notifier'

Found in linux-next but is also needed in mainline.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc:	MyungJoo Ham <myungjoo.ham@samsung.com>
Cc:	Chanwoo Choi <cw00.choi@samsung.com>
Cc:	Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20170124.orig/drivers/phy/Kconfig
+++ linux-next-20170124/drivers/phy/Kconfig
@@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2
 	tristate "Rockchip INNO USB2PHY Driver"
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
 	depends on COMMON_CLK
+	depends on EXTCON
 	depends on USB_SUPPORT
 	select GENERIC_PHY
 	select USB_COMMON

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors
  2017-01-26 17:42 [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors Randy Dunlap
@ 2017-01-27  8:15 ` Kishon Vijay Abraham I
  0 siblings, 0 replies; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2017-01-27  8:15 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: MyungJoo Ham, Chanwoo Choi, Heiko Stuebner, LKML



On Thursday 26 January 2017 11:12 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors in phy-rockchip-inno-usb2.c. The driver uses
> extcon interfaces so it should depend on EXTCON.
> 
> Fixes these build errors:
> 
> drivers/built-in.o: In function `rockchip_usb2phy_otg_sm_work':
> phy-rockchip-inno-usb2.c:(.text+0x2bcb): undefined reference to `extcon_get_state'
> phy-rockchip-inno-usb2.c:(.text+0x2cd4): undefined reference to `extcon_set_state_sync'
> phy-rockchip-inno-usb2.c:(.text+0x2cec): undefined reference to `extcon_set_state_sync'
> phy-rockchip-inno-usb2.c:(.text+0x2d2d): undefined reference to `extcon_get_state'
> drivers/built-in.o: In function `rockchip_usb2phy_probe':
> phy-rockchip-inno-usb2.c:(.text+0x31d7): undefined reference to `extcon_get_edev_by_phandle'
> phy-rockchip-inno-usb2.c:(.text+0x321a): undefined reference to `devm_extcon_dev_allocate'
> phy-rockchip-inno-usb2.c:(.text+0x3230): undefined reference to `devm_extcon_dev_register'
> phy-rockchip-inno-usb2.c:(.text+0x375a): undefined reference to `extcon_register_notifier'
> 
> Found in linux-next but is also needed in mainline.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:	MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc:	Chanwoo Choi <cw00.choi@samsung.com>
> Cc:	Heiko Stuebner <heiko@sntech.de>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

merged, thanks.

-Kishon
> ---
>  drivers/phy/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20170124.orig/drivers/phy/Kconfig
> +++ linux-next-20170124/drivers/phy/Kconfig
> @@ -363,6 +363,7 @@ config PHY_ROCKCHIP_INNO_USB2
>  	tristate "Rockchip INNO USB2PHY Driver"
>  	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
>  	depends on COMMON_CLK
> +	depends on EXTCON
>  	depends on USB_SUPPORT
>  	select GENERIC_PHY
>  	select USB_COMMON
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-27  9:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 17:42 [PATCH RESEND] phy: fix rockchip-inno-usb2 build errors Randy Dunlap
2017-01-27  8:15 ` Kishon Vijay Abraham I

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).