From: James Hogan <james.hogan@imgtec.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Takashi Iwai <tiwai@suse.de>, Rusty Russell <rusty@ozlabs.org>,
"David Howells" <dhowells@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source
Date: Wed, 5 Dec 2012 11:16:11 +0000 [thread overview]
Message-ID: <50BF2CFB.3030603@imgtec.com> (raw)
In-Reply-To: <50BF2A95.9070704@suse.cz>
On 05/12/12 11:05, Michal Marek wrote:
> Dne 5.12.2012 11:30, James Hogan napsal(a):
>> However I think it's unfortunate having to stringify from C as it's
>> pretty much always required to be in string form when used from a C
>> file, usually in an asm block. Any objection to defining SYMBOL_PREFIX
>> with the quotes around it for _c_flags only? E.g. see below
>
>
> After Takashi's patch is applied, there will be no user of the
> SYMBOL_PREFIX in C source. But it would probably be more convenient for
> potential new users.
Yes indeed (so the C related bits could indeed be dropped for now). I'd
likely change this patch to use it though:
http://thread.gmane.org/gmane.linux.kernel.cross-arch/15586/focus=15593
>
>> +_c_sym_flags = -DSYMBOL_PREFIX=\"$(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX))\"
>
> Maybe simply
>
> -DDSYMBOL_PREFIX='$(or $(CONFIG_SYMBOL_PREFIX),"")'
>
> ? The single quotes are needed either way, to prevent the shell eating
> the double quotes.
Yep, works for me (makefiles aren't one of my strengths!)
Cheers
James
next prev parent reply other threads:[~2012-12-05 11:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 10:18 [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file Michal Marek
2012-12-04 10:18 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source Michal Marek
2012-12-04 10:18 ` [PATCH 3/3] MODSIGN: Drop ccache hack Michal Marek
2012-12-04 18:15 ` [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file David Howells
2012-12-04 18:17 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source David Howells
2012-12-04 23:58 ` Rusty Russell
2012-12-05 7:39 ` Takashi Iwai
2012-12-05 9:50 ` Michal Marek
2012-12-05 10:06 ` Takashi Iwai
2012-12-05 10:30 ` James Hogan
2012-12-05 11:05 ` Michal Marek
2012-12-05 11:16 ` James Hogan [this message]
2012-12-07 4:40 ` Rusty Russell
2012-12-10 10:12 ` James Hogan
2012-12-05 10:30 ` David Howells
2012-12-05 10:54 ` Michal Marek
2012-12-05 12:35 ` David Howells
2012-12-05 7:46 ` Takashi Iwai
2012-12-04 18:29 ` [PATCH 3/3] MODSIGN: Drop ccache hack David Howells
2012-12-04 23:44 ` [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50BF2CFB.3030603@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@ozlabs.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).