From: Rusty Russell <rusty@ozlabs.org>
To: Michal Marek <mmarek@suse.cz>, dhowells@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file
Date: Wed, 05 Dec 2012 10:14:39 +1030 [thread overview]
Message-ID: <87k3sxgz6g.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1354616321-13520-1-git-send-email-mmarek@suse.cz>
Michal Marek <mmarek@suse.cz> writes:
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> scripts/sign-file | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/sign-file b/scripts/sign-file
> index 87ca59d..974a20b 100755
> --- a/scripts/sign-file
> +++ b/scripts/sign-file
> @@ -156,12 +156,12 @@ sub asn1_extract($$@)
>
> if ($l == 0x1) {
> $len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
> - } elsif ($l = 0x2) {
> + } elsif ($l == 0x2) {
> $len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
> - } elsif ($l = 0x3) {
> + } elsif ($l == 0x3) {
> $len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
> $len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
> - } elsif ($l = 0x4) {
> + } elsif ($l == 0x4) {
> $len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
> } else {
> die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, ")\n";
This was already applied to Linus' tree as
commit 916492b1e1a186260951831c53a53d8a448dc026
Author: Chun-Yi Lee <jlee@suse.com>
Date: Wed Nov 21 11:26:09 2012 +0000
Thanks,
Rusty.
prev parent reply other threads:[~2012-12-05 1:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 10:18 [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file Michal Marek
2012-12-04 10:18 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source Michal Marek
2012-12-04 10:18 ` [PATCH 3/3] MODSIGN: Drop ccache hack Michal Marek
2012-12-04 18:15 ` [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file David Howells
2012-12-04 18:17 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source David Howells
2012-12-04 23:58 ` Rusty Russell
2012-12-05 7:39 ` Takashi Iwai
2012-12-05 9:50 ` Michal Marek
2012-12-05 10:06 ` Takashi Iwai
2012-12-05 10:30 ` James Hogan
2012-12-05 11:05 ` Michal Marek
2012-12-05 11:16 ` James Hogan
2012-12-07 4:40 ` Rusty Russell
2012-12-10 10:12 ` James Hogan
2012-12-05 10:30 ` David Howells
2012-12-05 10:54 ` Michal Marek
2012-12-05 12:35 ` David Howells
2012-12-05 7:46 ` Takashi Iwai
2012-12-04 18:29 ` [PATCH 3/3] MODSIGN: Drop ccache hack David Howells
2012-12-04 23:44 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3sxgz6g.fsf@rustcorp.com.au \
--to=rusty@ozlabs.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).