linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: David Howells <dhowells@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>,
	linux-kernel@vger.kernel.org, rusty@ozlabs.org,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source
Date: Wed, 05 Dec 2012 08:46:10 +0100	[thread overview]
Message-ID: <s5hmwxtaqm5.wl%tiwai@suse.de> (raw)
In-Reply-To: <22396.1354645048@warthog.procyon.org.uk>

At Tue, 04 Dec 2012 18:17:28 +0000,
David Howells wrote:
> 
> Michal Marek <mmarek@suse.cz> wrote:
> 
> > Using the asm .incbin statement in C sources breaks any gcc wrapper which
> > assumes that preprocessed C source is self-contained. Use a separate .S
> > file to include the siging key and certificate.
> 
> I was trying to avoid that as .S files generally don't crop up in generic
> code and the format of the assembly varies with the arch.  However, you don't
> seem to have anything that should cause a problem

Well, we hit actually the issue...  Please check the revised patch again.


thanks,

Takashi

> - so:
> 
> Acked-by: David Howells <dhowells@redhat.com>
> 

  parent reply	other threads:[~2012-12-05  7:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 10:18 [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file Michal Marek
2012-12-04 10:18 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source Michal Marek
2012-12-04 10:18 ` [PATCH 3/3] MODSIGN: Drop ccache hack Michal Marek
2012-12-04 18:15 ` [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file David Howells
2012-12-04 18:17 ` [PATCH 2/3] MODSIGN: Avoid using .incbin in C source David Howells
2012-12-04 23:58   ` Rusty Russell
2012-12-05  7:39     ` Takashi Iwai
2012-12-05  9:50       ` Michal Marek
2012-12-05 10:06         ` Takashi Iwai
2012-12-05 10:30         ` James Hogan
2012-12-05 11:05           ` Michal Marek
2012-12-05 11:16             ` James Hogan
2012-12-07  4:40         ` Rusty Russell
2012-12-10 10:12           ` James Hogan
2012-12-05 10:30     ` David Howells
2012-12-05 10:54       ` Michal Marek
2012-12-05 12:35     ` David Howells
2012-12-05  7:46   ` Takashi Iwai [this message]
2012-12-04 18:29 ` [PATCH 3/3] MODSIGN: Drop ccache hack David Howells
2012-12-04 23:44 ` [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hmwxtaqm5.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=rusty@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).