* [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
@ 2013-03-27 7:23 Chen Gang
2013-04-03 8:01 ` Chen Gang
2013-04-07 11:24 ` Paul Menzel
0 siblings, 2 replies; 9+ messages in thread
From: Chen Gang @ 2013-03-27 7:23 UTC (permalink / raw)
To: airlied, bskeggs, airlied; +Cc: dri-devel, linux-kernel
need remove semicolon, or always return true.
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
index 7f0e6c3..1ddc03e 100644
--- a/drivers/gpu/drm/nouveau/nv50_display.c
+++ b/drivers/gpu/drm/nouveau/nv50_display.c
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
{
struct nv50_display_flip *flip = data;
if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
- flip->chan->data);
+ flip->chan->data)
return true;
usleep_range(1, 2);
return false;
--
1.7.7.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-03-27 7:23 [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon Chen Gang
@ 2013-04-03 8:01 ` Chen Gang
2013-04-07 1:03 ` Chen Gang
2013-04-07 11:24 ` Paul Menzel
1 sibling, 1 reply; 9+ messages in thread
From: Chen Gang @ 2013-04-03 8:01 UTC (permalink / raw)
To: airlied, bskeggs, airlied; +Cc: dri-devel, linux-kernel
Hello maintainers:
when you have time, please help to check this patch whether is OK.
thanks.
gchen.
On 2013年03月27日 15:23, Chen Gang wrote:
>
> need remove semicolon, or always return true.
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
> index 7f0e6c3..1ddc03e 100644
> --- a/drivers/gpu/drm/nouveau/nv50_display.c
> +++ b/drivers/gpu/drm/nouveau/nv50_display.c
> @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
> {
> struct nv50_display_flip *flip = data;
> if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
> - flip->chan->data);
> + flip->chan->data)
> return true;
> usleep_range(1, 2);
> return false;
>
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-04-03 8:01 ` Chen Gang
@ 2013-04-07 1:03 ` Chen Gang
2013-04-07 3:49 ` Greg KH
0 siblings, 1 reply; 9+ messages in thread
From: Chen Gang @ 2013-04-07 1:03 UTC (permalink / raw)
To: Greg KH; +Cc: airlied, bskeggs, airlied, dri-devel, linux-kernel
Hello Greg KH:
when you have time, can you help to check this patch whether OK ?
thanks.
gchen.
On 2013年04月03日 16:01, Chen Gang wrote:
> Hello maintainers:
>
> when you have time, please help to check this patch whether is OK.
>
> thanks.
>
> gchen.
>
>
> On 2013年03月27日 15:23, Chen Gang wrote:
>>
>> need remove semicolon, or always return true.
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>> ---
>> drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
>> index 7f0e6c3..1ddc03e 100644
>> --- a/drivers/gpu/drm/nouveau/nv50_display.c
>> +++ b/drivers/gpu/drm/nouveau/nv50_display.c
>> @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
>> {
>> struct nv50_display_flip *flip = data;
>> if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
>> - flip->chan->data);
>> + flip->chan->data)
>> return true;
>> usleep_range(1, 2);
>> return false;
>>
>
>
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-04-07 1:03 ` Chen Gang
@ 2013-04-07 3:49 ` Greg KH
2013-04-07 3:57 ` Chen Gang
0 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2013-04-07 3:49 UTC (permalink / raw)
To: Chen Gang; +Cc: airlied, bskeggs, airlied, dri-devel, linux-kernel
On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote:
> Hello Greg KH:
>
> when you have time, can you help to check this patch whether OK ?
No.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-04-07 3:49 ` Greg KH
@ 2013-04-07 3:57 ` Chen Gang
2013-04-07 4:09 ` Joe Perches
0 siblings, 1 reply; 9+ messages in thread
From: Chen Gang @ 2013-04-07 3:57 UTC (permalink / raw)
To: Greg KH; +Cc: airlied, bskeggs, airlied, dri-devel, linux-kernel
On 2013年04月07日 11:49, Greg KH wrote:
> On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote:
>> Hello Greg KH:
>>
>> when you have time, can you help to check this patch whether OK ?
>
> No.
>
>
Why ? does it also need a test ??
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-04-07 3:57 ` Chen Gang
@ 2013-04-07 4:09 ` Joe Perches
2013-04-07 4:19 ` Chen Gang
0 siblings, 1 reply; 9+ messages in thread
From: Joe Perches @ 2013-04-07 4:09 UTC (permalink / raw)
To: Chen Gang; +Cc: Greg KH, airlied, bskeggs, airlied, dri-devel, linux-kernel
On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote:
> On 2013年04月07日 11:49, Greg KH wrote:
> > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote:
> >> Hello Greg KH:
> >> when you have time, can you help to check this patch whether OK ?
> > No.
> Why ? does it also need a test ??
Greg's not the nouveau maintainer/babysitter and
likely doesn't have the time/hardware/desire to
test it.
The patch should be simply be sent to David Airlie
and dri-devel.
It is a pretty obvious typo though.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-04-07 4:09 ` Joe Perches
@ 2013-04-07 4:19 ` Chen Gang
0 siblings, 0 replies; 9+ messages in thread
From: Chen Gang @ 2013-04-07 4:19 UTC (permalink / raw)
To: Joe Perches; +Cc: Greg KH, airlied, bskeggs, airlied, dri-devel, linux-kernel
thank you very much for your reply, firstly.
On 2013年04月07日 12:09, Joe Perches wrote:
> On Sun, 2013-04-07 at 11:57 +0800, Chen Gang wrote:
>> > On 2013年04月07日 11:49, Greg KH wrote:
>>> > > On Sun, Apr 07, 2013 at 09:03:55AM +0800, Chen Gang wrote:
>>>> > >> Hello Greg KH:
>>>> > >> when you have time, can you help to check this patch whether OK ?
>>> > > No.
>> > Why ? does it also need a test ??
> Greg's not the nouveau maintainer/babysitter and
> likely doesn't have the time/hardware/desire to
> test it.
>
> The patch should be simply be sent to David Airlie
> and dri-devel.
>
ok, thanks, it seems, I need a little more patience.
:-)
> It is a pretty obvious typo though.
>
I guess so, too.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-03-27 7:23 [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon Chen Gang
2013-04-03 8:01 ` Chen Gang
@ 2013-04-07 11:24 ` Paul Menzel
2013-04-07 11:36 ` Chen Gang
1 sibling, 1 reply; 9+ messages in thread
From: Paul Menzel @ 2013-04-07 11:24 UTC (permalink / raw)
To: Chen Gang; +Cc: airlied, bskeggs, airlied, linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
Dear Chen,
Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang:
> need remove semicolon, or always return true.
do you know if this cause any problems? Did you find this reading the
code or by using some tools?
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
> drivers/gpu/drm/nouveau/nv50_display.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
> index 7f0e6c3..1ddc03e 100644
> --- a/drivers/gpu/drm/nouveau/nv50_display.c
> +++ b/drivers/gpu/drm/nouveau/nv50_display.c
> @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
> {
> struct nv50_display_flip *flip = data;
> if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
> - flip->chan->data);
> + flip->chan->data)
> return true;
> usleep_range(1, 2);
> return false;
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Thanks,
Paul
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon
2013-04-07 11:24 ` Paul Menzel
@ 2013-04-07 11:36 ` Chen Gang
0 siblings, 0 replies; 9+ messages in thread
From: Chen Gang @ 2013-04-07 11:36 UTC (permalink / raw)
To: Paul Menzel; +Cc: airlied, bskeggs, airlied, linux-kernel, dri-devel
On 2013年04月07日 19:24, Paul Menzel wrote:
> do you know if this cause any problems? Did you find this reading the
> code or by using some tools?
sorry, I do not know if this can cause any problems.
for this issue, I did not find it by reading code.
I find it by using compiler warnings with EXTRA_CFLAGS=-W
thanks.
:-)
--
Chen Gang
Asianux Corporation
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-07 11:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-27 7:23 [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon Chen Gang
2013-04-03 8:01 ` Chen Gang
2013-04-07 1:03 ` Chen Gang
2013-04-07 3:49 ` Greg KH
2013-04-07 3:57 ` Chen Gang
2013-04-07 4:09 ` Joe Perches
2013-04-07 4:19 ` Chen Gang
2013-04-07 11:24 ` Paul Menzel
2013-04-07 11:36 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).