linux-next: build failure after merge of the regulator tree

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 631 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/palmas-regulator.c: In function 'palmas_regulators_probe':
drivers/regulator/palmas-regulator.c:850:8: error: 'PALMAS_REG_SMPS10' undeclared (first use in this function)
   case PALMAS_REG_SMPS10:
        ^

Caused by commit 07a02e0b1a4f ("regulator: palmas: model SMPS10 as two
regulators").  Clearly not build tested at all :-(  Grep is your
friend ...

I have used the regulator tree from next-20130628 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Kishon Vijay Abraham I]

+Keerthy

On Monday 01 July 2013 09:48 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/regulator/palmas-regulator.c: In function 'palmas_regulators_probe':
> drivers/regulator/palmas-regulator.c:850:8: error: 'PALMAS_REG_SMPS10' undeclared (first use in this function)
>     case PALMAS_REG_SMPS10:
>          ^
>
> Caused by commit 07a02e0b1a4f ("regulator: palmas: model SMPS10 as two
> regulators").  Clearly not build tested at all :-(  Grep is your
> friend ...

commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
and I dint have that patch in my tree. Sorry, my bad.
Keerthy will send a fix for it.

Thanks
Kishon

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]

On Mon, Jul 01, 2013 at 11:37:09AM +0530, Kishon Vijay Abraham I wrote:

> commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
> and I dint have that patch in my tree. Sorry, my bad.
> Keerthy will send a fix for it.

Resubmit the patch, I've dropped it.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Kishon Vijay Abraham I]

On Monday 01 July 2013 02:13 PM, Mark Brown wrote:
> On Mon, Jul 01, 2013 at 11:37:09AM +0530, Kishon Vijay Abraham I wrote:
>
>> commit 1ffb0b (mfd: palmas: Add SMPS10_BOOST feature) had used PALMAS_REG_SMPS10
>> and I dint have that patch in my tree. Sorry, my bad.
>> Keerthy will send a fix for it.
>
> Resubmit the patch, I've dropped it.

Ok. I'll resend the patch.

Thanks
Kishon

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Mon, Jul 01, 2013 at 02:18:27PM +1000, Stephen Rothwell wrote:

> Caused by commit 07a02e0b1a4f ("regulator: palmas: model SMPS10 as two
> regulators").  Clearly not build tested at all :-(  Grep is your
> friend ...

That's odd, it's also not been caught by Fengguang's system which
generally gets this sort of stuff...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/max597x-regulator.c:24:10: fatal error: linux/mfd/max597x.h: No such file or directory
   24 | #include <linux/mfd/max597x.h>
      |          ^~~~~~~~~~~~~~~~~~~~~

Caused by commit

  38493f008deb ("regulator: max597x: Add support for max597x regulator")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (s390
allmodconfig) failed like this:

include/linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
cc1: all warnings being treated as errors

Caused by commit

  8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Vaittinen, Matti]

Hi dee Ho peeps,

On 11/23/21 09:41, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (s390
> allmodconfig) failed like this:
> 
> include/Linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>    8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")


Ouch. The stub in header should be inlined. Sorry for that. I'll send 
incremental patch to Mark - please let me know if that's not sufficient?

Best Regards
	-- Matti Vaittinen

-- 
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~

Re: linux-next: build failure after merge of the regulator tree

[Vaittinen, Matti]

Hi again,

On 11/23/21 09:41, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (s390
> allmodconfig) failed like this:
> 
> include/linux/mfd/rohm-generic.h:93:12: error: 'rohm_regulator_set_voltage_sel_restricted' defined but not used [-Werror=unused-function]
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>    8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")

As a second thought - do we need such a stub function at all? I guess 
anyone who is actually adding a call to the 
rohm_regulator_set_voltage_sel_restricted()  helper should also have the 
implementation selected. Failing to do so is probably indication of an 
error. Compile testing could perhaps be an exception but this is 
currently not supported.

Should I just drop the stub or make it inline? Am I overlooking something?

Best Regards
	-- Matti Vaittinen

-- 
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 779 bytes --]

On Tue, Nov 23, 2021 at 09:26:45AM +0000, Vaittinen, Matti wrote:

> As a second thought - do we need such a stub function at all? I guess 
> anyone who is actually adding a call to the 
> rohm_regulator_set_voltage_sel_restricted()  helper should also have the 
> implementation selected. Failing to do so is probably indication of an 
> error. Compile testing could perhaps be an exception but this is 
> currently not supported.

> Should I just drop the stub or make it inline? Am I overlooking something?

Dropping it does seem reasonable, I can't immediately think of a case
where the stub would get used.  I've queued your existing patch to try
to make sure that a fix lands tomorrow so (assuming no test issues)
please send a removal patch on top of that.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/sy7636a-regulator.c:14:10: fatal error: linux/mfd/sy7636a.h: No such file or directory
   14 | #include <linux/mfd/sy7636a.h>
      |          ^~~~~~~~~~~~~~~~~~~~~

Caused by commit

  cb17820ef71e ("regulator: sy7636a: Remove requirement on sy7636a mfd")

I have used the regulator tree from next-20211021 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Alistair]

On Fri, Oct 22, 2021, at 11:53 AM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/regulator/sy7636a-regulator.c:14:10: fatal error: linux/mfd/sy7636a.h: No such file or directory
>    14 | #include <linux/mfd/sy7636a.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   cb17820ef71e ("regulator: sy7636a: Remove requirement on sy7636a mfd")

The above patch allows the sy7636a regulator to be built, as it no longer depends on
the mfd driver directly.
This fails to build on current upstream as the sy7636a header file isn't upstream
yet. The header file is added earlier in the patch series.

This patch should probably not be applied until after:

mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a

Or if preferred I can split adding the header file into it's own patch that can be
applied.

Alistair


> 
> I have used the regulator tree from next-20211021 for today.
> 
> -- 
> Cheers,
> Stephen Rothwell
> 

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

On Fri, Oct 22, 2021 at 08:31:08PM +1000, Alistair wrote:

> This patch should probably not be applied until after:

> mfd: simple-mfd-i2c: Enable support for the silergy,sy7636a

> Or if preferred I can split adding the header file into it's own patch that can be
> applied.

Let's just add the dependency back until the MFD gets sorted out :/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 517 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mt6359-regulator.c:6:10: fatal error: linux/mfd/mt6359/registers.h: No such file or directory
    6 | #include <linux/mfd/mt6359/registers.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  1db868c30287 ("regulator: mt6359: Add support for MT6359 regulator")

I have used the regulator tree from next-20200225 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 6467 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ld: drivers/ata/ahci.o:(.opd+0x150): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/ata/ahci.o: in function `.regulator_bulk_set_supply_names':
ahci.c:(.text+0x1780): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/ata/libahci.o: in function `.regulator_bulk_set_supply_names':
(.text+0x84a0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/ata/libahci.o:(.opd+0x5d0): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/ata/sata_mv.o:(.opd+0x690): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/ata/sata_mv.o: in function `.regulator_bulk_set_supply_names':
sata_mv.c:(.text+0xb9b0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/common/common.o: in function `.regulator_bulk_set_supply_names':
(.text+0x7d0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/common/common.o:(.opd+0x120): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/core/usb.o: in function `.regulator_bulk_set_supply_names':
(.text+0x17d0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/usb.o:(.opd+0x348): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/core/hub.o: in function `.regulator_bulk_set_supply_names':
(.text+0x2610): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/hub.o:(.opd+0x378): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/core/hcd.o: in function `.regulator_bulk_set_supply_names':
(.text+0x3020): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/hcd.o:(.opd+0x378): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/core/message.o: in function `.regulator_bulk_set_supply_names':
(.text+0x2350): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/message.o:(.opd+0x240): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/core/phy.o: in function `.regulator_bulk_set_supply_names':
(.text+0x700): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/phy.o:(.opd+0xc0): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/core/of.o: in function `.regulator_bulk_set_supply_names':
(.text+0x2f0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/core/of.o:(.opd+0x48): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/phy/of.o: in function `.regulator_bulk_set_supply_names':
(.text+0x120): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/phy/of.o:(.opd+0x18): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/host/ehci-hcd.o: in function `.regulator_bulk_set_supply_names':
(.text+0x11830): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/host/ehci-hcd.o:(.opd+0x8d0): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/usb/host/ohci-hcd.o: in function `.regulator_bulk_set_supply_names':
(.text+0xe8d0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/usb/host/ohci-hcd.o:(.opd+0x570): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
ld: drivers/of/platform.o: in function `.regulator_bulk_set_supply_names':
(.text+0x1180): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
ld: drivers/of/platform.o:(.opd+0x180): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here

Caused by commit

  d0087e72710c ("regulator: provide regulator_bulk_set_supply_names()")

I applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 3 Sep 2019 14:23:17 +1000
Subject: [PATCH] regulator: stubs in header files should be static inline

Fixes: d0087e72710c ("regulator: provide regulator_bulk_set_supply_names()")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 include/linux/regulator/consumer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index 6d2181a76987..fe9bdf37c296 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -586,7 +586,7 @@ static inline int regulator_list_voltage(struct regulator *regulator, unsigned s
 	return -EINVAL;
 }
 
-void regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers,
+static inline void regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers,
 				     const char *const *supply_names,
 				     unsigned int num_supplies)
 {
-- 
2.23.0.rc1

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Bartosz Golaszewski]

wt., 3 wrz 2019 o 06:26 Stephen Rothwell <sfr@canb.auug.org.au> napisał(a):
>
> Hi all,
>
> After merging the regulator tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ld: drivers/ata/ahci.o:(.opd+0x150): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/ata/ahci.o: in function `.regulator_bulk_set_supply_names':
> ahci.c:(.text+0x1780): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/ata/libahci.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x84a0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/ata/libahci.o:(.opd+0x5d0): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/ata/sata_mv.o:(.opd+0x690): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/ata/sata_mv.o: in function `.regulator_bulk_set_supply_names':
> sata_mv.c:(.text+0xb9b0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/common/common.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x7d0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/common/common.o:(.opd+0x120): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/core/usb.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x17d0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/usb.o:(.opd+0x348): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/core/hub.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x2610): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/hub.o:(.opd+0x378): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/core/hcd.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x3020): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/hcd.o:(.opd+0x378): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/core/message.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x2350): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/message.o:(.opd+0x240): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/core/phy.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x700): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/phy.o:(.opd+0xc0): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/core/of.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x2f0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/core/of.o:(.opd+0x48): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/phy/of.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x120): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/phy/of.o:(.opd+0x18): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/host/ehci-hcd.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x11830): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/host/ehci-hcd.o:(.opd+0x8d0): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/usb/host/ohci-hcd.o: in function `.regulator_bulk_set_supply_names':
> (.text+0xe8d0): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/usb/host/ohci-hcd.o:(.opd+0x570): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
> ld: drivers/of/platform.o: in function `.regulator_bulk_set_supply_names':
> (.text+0x1180): multiple definition of `.regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.text+0x2390): first defined here
> ld: drivers/of/platform.o:(.opd+0x180): multiple definition of `regulator_bulk_set_supply_names'; drivers/phy/phy-core.o:(.opd+0x3f0): first defined here
>
> Caused by commit
>
>   d0087e72710c ("regulator: provide regulator_bulk_set_supply_names()")
>
> I applied the following patch for today.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Tue, 3 Sep 2019 14:23:17 +1000
> Subject: [PATCH] regulator: stubs in header files should be static inline
>
> Fixes: d0087e72710c ("regulator: provide regulator_bulk_set_supply_names()")
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  include/linux/regulator/consumer.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
> index 6d2181a76987..fe9bdf37c296 100644
> --- a/include/linux/regulator/consumer.h
> +++ b/include/linux/regulator/consumer.h
> @@ -586,7 +586,7 @@ static inline int regulator_list_voltage(struct regulator *regulator, unsigned s
>         return -EINVAL;
>  }
>
> -void regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers,
> +static inline void regulator_bulk_set_supply_names(struct regulator_bulk_data *consumers,
>                                      const char *const *supply_names,
>                                      unsigned int num_supplies)
>  {
> --
> 2.23.0.rc1
>
> --
> Cheers,
> Stephen Rothwell

Hi Stephen,

a patch for this was already on the list: https://lkml.org/lkml/2019/9/2/668

Bart

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mt6358-regulator.c:5:10: fatal error: linux/mfd/mt6358/registers.h: No such file or directory
 #include <linux/mfd/mt6358/registers.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by commit

  f67ff1bd58f0 ("regulator: mt6358: Add support for MT6358 regulator")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regulator_lock" [drivers/regulator/wm8350-regulator.ko] undefined!
ERROR: "regulator_unlock" [drivers/regulator/wm8350-regulator.ko] undefined!
ERROR: "regulator_unlock" [drivers/regulator/da9210-regulator.ko] undefined!
ERROR: "regulator_lock" [drivers/regulator/da9210-regulator.ko] undefined!

Caused by commit

  f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")

I have used the regulator tree from next-20181119 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Dmitry Osipenko]

On 20.11.2018 3:49, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: "regulator_lock" [drivers/regulator/wm8350-regulator.ko] undefined!
> ERROR: "regulator_unlock" [drivers/regulator/wm8350-regulator.ko] undefined!
> ERROR: "regulator_unlock" [drivers/regulator/da9210-regulator.ko] undefined!
> ERROR: "regulator_lock" [drivers/regulator/da9210-regulator.ko] undefined!
> 
> Caused by commit
> 
>   f8702f9e4aa7 ("regulator: core: Use ww_mutex for regulators locking")
> 
> I have used the regulator tree from next-20181119 for today.
> 

My bad, forgot to export these functions. That's the same issue that was reporter by the build robot earlier. Will send the fix, sorry for the inconvenience.

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/regulator/anatop-regulator.c: In function 'anatop_regulator_probe':
drivers/regulator/anatop-regulator.c:310:24: error: assignment of member 'enable' in read-only object
    anatop_rops.enable  = regulator_enable_regmap;
                        ^
drivers/regulator/anatop-regulator.c:311:24: error: assignment of member 'disable' in read-only object
    anatop_rops.disable = regulator_disable_regmap;
                        ^
drivers/regulator/anatop-regulator.c:312:27: error: assignment of member 'is_enabled' in read-only object
    anatop_rops.is_enabled = regulator_is_enabled_regmap;
                           ^

Caused by commit

  524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops structure")

I can only assume that this patch has been rebased since it was tested.

I have used the regulator tree from next-20170131 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 282 bytes --]

On Wed, Feb 01, 2017 at 01:42:21PM +1100, Stephen Rothwell wrote:

> Caused by commit
> 
>   524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops structure")
> 
> I can only assume that this patch has been rebased since it was tested.

Discarded that commit.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

Hi Mark,

On Wed, 1 Feb 2017 10:03:43 +0000 Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, Feb 01, 2017 at 01:42:21PM +1100, Stephen Rothwell wrote:
> 
> > Caused by commit
> > 
> >   524d339a9d6b ("regulator: anatop-regulator: constify regulator_ops structure")
> > 
> > I can only assume that this patch has been rebased since it was tested.  
> 
> Discarded that commit.

The patch is still there ...

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

On Fri, Feb 03, 2017 at 09:30:04AM +1100, Stephen Rothwell wrote:

> > Discarded that commit.

> The patch is still there ...

Only in the merge branch, it got dropped from the source branch but the
merge ended up not being rebuilt.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2517 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (arm multi_v7_defconfig)
failed like this:

drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
    regulator_set_optimum_mode(s[i].consumer,
    ^

Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
support") from the drm tree interacting with commit ae6e808f1574
("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
the regulator tree.

This happens every time someone renames/changes an API :-(

I have applied the following merge fix patch.  Someone needs to make
sure Linus finds out when the latter of these two trees is merged into
his.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Thu, 9 Apr 2015 14:28:42 +1000
Subject: [PATCH] drm/msm: fixes for regulator_set_optimum_mode name change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index fdc54e3eff55..962cf545d24c 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -327,8 +327,7 @@ static void dsi_host_regulator_disable(struct msm_dsi_host *msm_host)
 	DBG("");
 	for (i = num - 1; i >= 0; i--)
 		if (regs[i].disable_load >= 0)
-			regulator_set_optimum_mode(s[i].consumer,
-						regs[i].disable_load);
+			regulator_set_load(s[i].consumer, regs[i].disable_load);
 
 	regulator_bulk_disable(num, s);
 }
@@ -343,8 +342,8 @@ static int dsi_host_regulator_enable(struct msm_dsi_host *msm_host)
 	DBG("");
 	for (i = 0; i < num; i++) {
 		if (regs[i].enable_load >= 0) {
-			ret = regulator_set_optimum_mode(s[i].consumer,
-							regs[i].enable_load);
+			ret = regulator_set_load(s[i].consumer,
+						regs[i].enable_load);
 			if (ret < 0) {
 				pr_err("regulator %d set op mode failed, %d\n",
 					i, ret);
@@ -363,7 +362,7 @@ static int dsi_host_regulator_enable(struct msm_dsi_host *msm_host)
 
 fail:
 	for (i--; i >= 0; i--)
-		regulator_set_optimum_mode(s[i].consumer, regs[i].disable_load);
+		regulator_set_load(s[i].consumer, regs[i].disable_load);
 	return ret;
 }
 
-- 
2.1.4

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1032 bytes --]

On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:

> After merging the regulator tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:

> drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
> drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
>     regulator_set_optimum_mode(s[i].consumer,
>     ^

> Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> support") from the drm tree interacting with commit ae6e808f1574
> ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> the regulator tree.

> This happens every time someone renames/changes an API :-(

It's *really* questionable if anyone should be using that API in the
first place, one of the reasons it's being removed is that it's really
unclear that anything would be able to successfully use it as-is.  The
easist thing might be to drop the new usage for the time being.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

Hi all,

On Thu, 9 Apr 2015 10:35:56 +0100 Mark Brown <broonie@kernel.org> wrote:
>
> On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:
> 
> > After merging the regulator tree, today's linux-next build (arm multi_v7_defconfig)
> > failed like this:
> 
> > drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
> > drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
> >     regulator_set_optimum_mode(s[i].consumer,
> >     ^
> 
> > Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> > support") from the drm tree interacting with commit ae6e808f1574
> > ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> > the regulator tree.
> 
> > This happens every time someone renames/changes an API :-(
> 
> It's *really* questionable if anyone should be using that API in the
> first place, one of the reasons it's being removed is that it's really
> unclear that anything would be able to successfully use it as-is.  The
> easist thing might be to drop the new usage for the time being.

This fix up patch is now needed when the drm tree is merged with Linus'
tree (the regulator part has been merged).

Mark, what did you above response mean?  Should the drm tree be using
something different?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Bjorn Andersson]

On Mon 13 Apr 16:44 PDT 2015, Stephen Rothwell wrote:

> Hi all,
> 
> On Thu, 9 Apr 2015 10:35:56 +0100 Mark Brown <broonie@kernel.org> wrote:
> >
> > On Thu, Apr 09, 2015 at 02:33:09PM +1000, Stephen Rothwell wrote:
> > 
> > > After merging the regulator tree, today's linux-next build (arm multi_v7_defconfig)
> > > failed like this:
> > 
> > > drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
> > > drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
> > >     regulator_set_optimum_mode(s[i].consumer,
> > >     ^
> > 
> > > Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> > > support") from the drm tree interacting with commit ae6e808f1574
> > > ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> > > the regulator tree.
> > 
> > > This happens every time someone renames/changes an API :-(
> > 
> > It's *really* questionable if anyone should be using that API in the
> > first place, one of the reasons it's being removed is that it's really
> > unclear that anything would be able to successfully use it as-is.  The
> > easist thing might be to drop the new usage for the time being.
> 
> This fix up patch is now needed when the drm tree is merged with Linus'
> tree (the regulator part has been merged).
> 
> Mark, what did you above response mean?  Should the drm tree be using
> something different?
> 

What Mark mean is basically that there shouldn't be any users of
regulator_set_optimum_mode() for various reasons and we introduced
regulator_set_load() to solve these, before any users popped up.

Unfortunately we weren't fast enough and people got some code in that
uses the API that isn't implemented for any Qualcomm platform today...


Your patch looks correct and should preferrably be added to the drm
tree, or the last patch in my series that drops the API wrapper should
be held back until rc1(?)

Regards,
Bjorn

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Hi Bjorn,

On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson <bjorn.andersson@sonymobile.com> wrote:
>
> What Mark mean is basically that there shouldn't be any users of
> regulator_set_optimum_mode() for various reasons and we introduced
> regulator_set_load() to solve these, before any users popped up.
> 
> Unfortunately we weren't fast enough and people got some code in that
> uses the API that isn't implemented for any Qualcomm platform today...

Ah, OK.

> Your patch looks correct and should preferrably be added to the drm
> tree, or the last patch in my series that drops the API wrapper should
> be held back until rc1(?)

It needs to be sent to Linus as a merge fix when the drm tree is merged.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On Tue, Apr 14, 2015 at 11:22:41AM +1000, Stephen Rothwell wrote:
> On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson <bjorn.andersson@sonymobile.com> wrote:

> > Your patch looks correct and should preferrably be added to the drm
> > tree, or the last patch in my series that drops the API wrapper should
> > be held back until rc1(?)

> It needs to be sent to Linus as a merge fix when the drm tree is merged.

Or the DRM tree could pull my tree I guess - Rob/David, I can make a tag
specifically for this branch if you like?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Dave Airlie]

On 14 April 2015 at 19:40, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Apr 14, 2015 at 11:22:41AM +1000, Stephen Rothwell wrote:
>> On Mon, 13 Apr 2015 18:07:06 -0700 Bjorn Andersson <bjorn.andersson@sonymobile.com> wrote:
>
>> > Your patch looks correct and should preferrably be added to the drm
>> > tree, or the last patch in my series that drops the API wrapper should
>> > be held back until rc1(?)
>
>> It needs to be sent to Linus as a merge fix when the drm tree is merged.
>
> Or the DRM tree could pull my tree I guess - Rob/David, I can make a tag
> specifically for this branch if you like?

I can just backmerge Linus's tree before I send it to him, and stick
this patch on top.

seems like the best answer.

Dave.

Re: linux-next: build failure after merge of the regulator tree

[Rob Clark]

On Thu, Apr 9, 2015 at 12:33 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (arm multi_v7_defconfig)
> failed like this:
>
> drivers/gpu/drm/msm/dsi/dsi_host.c: In function 'dsi_host_regulator_disable':
> drivers/gpu/drm/msm/dsi/dsi_host.c:330:4: error: implicit declaration of function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
>     regulator_set_optimum_mode(s[i].consumer,
>     ^
>
> Caused by commit a689554ba6ed ("drm/msm: Initial add DSI connector
> support") from the drm tree interacting with commit ae6e808f1574
> ("regulator: Drop temporary regulator_set_optimum_mode wrapper") from
> the regulator tree.

Thanks.. btw, would it be possible to get my msm-next branch picked up
by linux-next?  That seems like it would help to catch these earlier..

 git://people.freedesktop.org/~robclark/linux msm-next

BR,
-R

> This happens every time someone renames/changes an API :-(
>
> I have applied the following merge fix patch.  Someone needs to make
> sure Linus finds out when the latter of these two trees is merged into
> his.
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Thu, 9 Apr 2015 14:28:42 +1000
> Subject: [PATCH] drm/msm: fixes for regulator_set_optimum_mode name change
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index fdc54e3eff55..962cf545d24c 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -327,8 +327,7 @@ static void dsi_host_regulator_disable(struct msm_dsi_host *msm_host)
>         DBG("");
>         for (i = num - 1; i >= 0; i--)
>                 if (regs[i].disable_load >= 0)
> -                       regulator_set_optimum_mode(s[i].consumer,
> -                                               regs[i].disable_load);
> +                       regulator_set_load(s[i].consumer, regs[i].disable_load);
>
>         regulator_bulk_disable(num, s);
>  }
> @@ -343,8 +342,8 @@ static int dsi_host_regulator_enable(struct msm_dsi_host *msm_host)
>         DBG("");
>         for (i = 0; i < num; i++) {
>                 if (regs[i].enable_load >= 0) {
> -                       ret = regulator_set_optimum_mode(s[i].consumer,
> -                                                       regs[i].enable_load);
> +                       ret = regulator_set_load(s[i].consumer,
> +                                               regs[i].enable_load);
>                         if (ret < 0) {
>                                 pr_err("regulator %d set op mode failed, %d\n",
>                                         i, ret);
> @@ -363,7 +362,7 @@ static int dsi_host_regulator_enable(struct msm_dsi_host *msm_host)
>
>  fail:
>         for (i--; i >= 0; i--)
> -               regulator_set_optimum_mode(s[i].consumer, regs[i].disable_load);
> +               regulator_set_load(s[i].consumer, regs[i].disable_load);
>         return ret;
>  }
>
> --
> 2.1.4
>
> --
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 3343 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/gpu/drm/msm/edp/edp_ctrl.c: In function 'edp_regulator_enable':
drivers/gpu/drm/msm/edp/edp_ctrl.c:335:2: error: implicit declaration of function 'regulator_set_optimum_mode' [-Werror=implicit-function-declaration]
  ret = regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_ON_LOAD);
  ^

Caused by commits e39ce48f5362 ("regulator: Rename
regulator_set_optimum_mode") and ae6e808f1574 ("regulator: Drop
temporary regulator_set_optimum_mode wrapper") interacting with commit
ab5b0107ccf3 ("drm/msm: Initial add eDP support in msm drm driver
(v5)") from Linus' tree (in v4.0-rc1) tree.

There was another use of regulator_set_optimum_mode() in
drivers/phy/phy-qcom-ufs.c (introduced by commit adaafaa393ef ("phy:
qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers") also
from v4.0-rc1) which I also fixed in the patch below.

grep is your friend ...

This patch should be applied to your tree as it is based off v4.0-rc1
already.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Tue, 10 Mar 2015 13:35:59 +1100
Subject: [PATCH] fixes for regulator_set_optimum_mode name change

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/gpu/drm/msm/edp/edp_ctrl.c | 6 +++---
 drivers/phy/phy-qcom-ufs.c         | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
index 3e246210c46f..0ec5abdba5c4 100644
--- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
+++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
@@ -332,7 +332,7 @@ static int edp_regulator_enable(struct edp_ctrl *ctrl)
 		goto vdda_set_fail;
 	}
 
-	ret = regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_ON_LOAD);
+	ret = regulator_set_load(ctrl->vdda_vreg, VDDA_UA_ON_LOAD);
 	if (ret < 0) {
 		pr_err("%s: vdda_vreg set regulator mode failed.\n", __func__);
 		goto vdda_set_fail;
@@ -356,7 +356,7 @@ static int edp_regulator_enable(struct edp_ctrl *ctrl)
 lvl_enable_fail:
 	regulator_disable(ctrl->vdda_vreg);
 vdda_enable_fail:
-	regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
+	regulator_set_load(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
 vdda_set_fail:
 	return ret;
 }
@@ -365,7 +365,7 @@ static void edp_regulator_disable(struct edp_ctrl *ctrl)
 {
 	regulator_disable(ctrl->lvl_vreg);
 	regulator_disable(ctrl->vdda_vreg);
-	regulator_set_optimum_mode(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
+	regulator_set_load(ctrl->vdda_vreg, VDDA_UA_OFF_LOAD);
 }
 
 static int edp_gpio_config(struct edp_ctrl *ctrl)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 44ee983d57fe..86665e9dc399 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -346,10 +346,10 @@ int ufs_qcom_phy_cfg_vreg(struct phy *phy,
 			goto out;
 		}
 		uA_load = on ? vreg->max_uA : 0;
-		ret = regulator_set_optimum_mode(reg, uA_load);
+		ret = regulator_set_load(reg, uA_load);
 		if (ret >= 0) {
 			/*
-			 * regulator_set_optimum_mode() returns new regulator
+			 * regulator_set_load() returns new regulator
 			 * mode upon success.
 			 */
 			ret = 0;
-- 
2.1.4
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

On Tue, Mar 10, 2015 at 01:44:41PM +1100, Stephen Rothwell wrote:

> grep is your friend ...

Indeed :(

> This patch should be applied to your tree as it is based off v4.0-rc1
> already.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2072 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' declared inside parameter list
           struct rk808_board *pdata)
                  ^
drivers/regulator/rk808-regulator.c:312:18: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_dts':
drivers/regulator/rk808-regulator.c:340:8: error: dereferencing pointer to incomplete type
   pdata->rk808_init_data[i] = rk808_reg_matches[i].init_data;
        ^
drivers/regulator/rk808-regulator.c:341:8: error: dereferencing pointer to incomplete type
   pdata->of_node[i] = rk808_reg_matches[i].of_node;
        ^
drivers/regulator/rk808-regulator.c: In function 'rk808_regulator_probe':
drivers/regulator/rk808-regulator.c:359:43: error: dereferencing pointer to incomplete type
   pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
                                           ^
drivers/regulator/rk808-regulator.c:364:8: warning: passing argument 2 of 'rk808_regulator_dts' from incompatible pointer type
  ret = rk808_regulator_dts(client, pdata);
        ^
drivers/regulator/rk808-regulator.c:311:12: note: expected 'struct rk808_board *' but argument is of type 'struct rk808_board *'
 static int rk808_regulator_dts(struct i2c_client *client,
            ^
drivers/regulator/rk808-regulator.c:370:19: error: dereferencing pointer to incomplete type
   reg_data = pdata->rk808_init_data[i];
                   ^
drivers/regulator/rk808-regulator.c:379:26: error: dereferencing pointer to incomplete type
    config.of_node = pdata->of_node[i];
                          ^

Caused by commit 2cd64ae3d57b ("regulator: RK808: Add regulator driver
for RK808").

I have reverted that commit and all the following ones in the regulator
tree that touch this file.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:

> drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' declared inside parameter list
>            struct rk808_board *pdata)

Chris, as previously requested please send me any changes needed to
update for the changes in the MFD driver.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Chris Zhong]

On 09/10/2014 06:39 AM, Mark Brown wrote:
> On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:
>
>> drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' declared inside parameter list
>>             struct rk808_board *pdata)
> Chris, as previously requested please send me any changes needed to
> update for the changes in the MFD driver.
Yes, I have modified the rk808.h, so rk808-regulator.c lacks some 
structure now.
Please help me review the patch "[PATCH v10 3/3] regulator: RK808: 
Remove pdata from the regulator"
It contains the corresponding changes.

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

On Wed, Sep 10, 2014 at 10:33:16AM +0800, Chris Zhong wrote:

> Yes, I have modified the rk808.h, so rk808-regulator.c lacks some structure
> now.
> Please help me review the patch "[PATCH v10 3/3] regulator: RK808: Remove
> pdata from the regulator"
> It contains the corresponding changes.

...which you sent to me overnight.  It's applied now so -next should be
fine tomorrow, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Doug Anderson]

Hi,

On Tue, Sep 9, 2014 at 3:39 PM, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Sep 08, 2014 at 06:33:50PM +1000, Stephen Rothwell wrote:
>
>> drivers/regulator/rk808-regulator.c:312:18: warning: 'struct rk808_board' declared inside parameter list
>>            struct rk808_board *pdata)
>
> Chris, as previously requested please send me any changes needed to
> update for the changes in the MFD driver.

See <https://patchwork.kernel.org/patch/4873501/>

-Doug

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/mc13892-regulator.c: In function 'mc13892_regulator_probe':
drivers/regulator/mc13892-regulator.c:586:3: error: assignment of member 'set_mode' in read-only object
   = mc13892_vcam_set_mode;
   ^
drivers/regulator/mc13892-regulator.c:588:3: error: assignment of member 'get_mode' in read-only object
   = mc13892_vcam_get_mode;
   ^

Caused by commit 272e2315fac3 ("regulator: core: add const qualifier to
ops in struct regulator_desc").

I have used the regulator tree from next-20140815 for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/act8865-regulator.c: In function 'act8865_pmic_probe':
drivers/regulator/act8865-regulator.c:291:13: error: 'act8846_matches' undeclared (first use in this function)
   matches = act8846_matches;
             ^
drivers/regulator/act8865-regulator.c:291:13: note: each undeclared identifier is reported only once for each function it appears in
drivers/regulator/act8865-regulator.c:296:13: error: 'act8865_matches' undeclared (first use in this function)
   matches = act8865_matches;
             ^
drivers/regulator/act8865-regulator.c:311:9: error: too many arguments to function 'act8865_pdata_from_dt'
   ret = act8865_pdata_from_dt(dev, of_node, &pdata_of, matches,
         ^
drivers/regulator/act8865-regulator.c:239:19: note: declared here
 static inline int act8865_pdata_from_dt(struct device *dev,
                   ^

Caused by commit 7160912a8c55 ("regulator: act8865: add support for
act8846").

I have used the regulator tree from next-20140707 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/built-in.o: In function `ltc3589_probe':
ltc3589.c:(.text+0xccf24): undefined reference to `devm_regmap_init_i2c'
drivers/built-in.o: In function `ltc3589_driver_init':
ltc3589.c:(.init.text+0x9ebc): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `ltc3589_driver_exit':
ltc3589.c:(.exit.text+0x2d1): undefined reference to `i2c_del_driver'

Caused by commit 3eb2c7ecb7ea ("regulator: Add LTC3589 support").

Clearly some dependencies are incorrect.  Presumably the required
interfaces are in modules for this build.

I have used the regulator tree from next-20140526 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from /scratch/sfr/next/include/linux/cache.h:4:0,
                 from /scratch/sfr/next/include/linux/time.h:4,
                 from /scratch/sfr/next/include/linux/stat.h:18,
                 from /scratch/sfr/next/include/linux/module.h:10,
                 from /scratch/sfr/next/drivers/regulator/act8865-regulator.c:18:
/scratch/sfr/next/drivers/regulator/act8865-regulator.c: In function 'act8865_pmic_probe':
/scratch/sfr/next/drivers/regulator/act8865-regulator.c:306:29: error: 'act8865_matches' undeclared (first use in this function)
  for (i = 0; i < ARRAY_SIZE(act8865_matches); i++) {
                             ^

Caused by commit d04b75527368 ("regulator: act8865: register all
regulators regardless of how many are used").  This build does not have
CONFIG_OF set.

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "regulator_allow_bypass" [drivers/extcon/extcon-arizona.ko] undefined!

Caused by commit e6647c416e4f ("extcon: arizona: Use bypass mode for MICVDD").

I have used the regulator tree from next-20120907 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

lp872x.c:(.text+0xb0699): undefined reference to `devm_regmap_init_i2c'
drivers/built-in.o: In function `lp872x_driver_init':
lp872x.c:(.init.text+0x81ac): undefined reference to `i2c_register_driver'
drivers/built-in.o: In function `lp872x_driver_exit':
lp872x.c:(.exit.text+0x37e): undefined reference to `i2c_del_driver'

CONFIG_I2C=m in this build.

Caused by commit 809d310c7e69 ("regulator: lp872x: Don't allow modular
build") but that was done to fix a different build problem.

I have used the regulator tree from next-20120619 again for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

RE: linux-next: build failure after merge of the regulator tree

[Kim, Milo]

> Caused by commit 809d310c7e69 ("regulator: lp872x: Don't allow modular
> build") but that was done to fix a different build problem.

Sorry for this conflict.

Build config of lp872x driver has been changed as tristate.
And related undefined symbol error has been fixed.
(don't use devm_gpio_request_one() at this moment because it can not be exported.)

Please check patches below.

[PATCH 1/3] regulator: enable module build config for lp872x
[PATCH 2/3] regulator: replace devm_gpio_request_one() for loaded module

Thanks & BR
Milo -

Re: linux-next: build failure after merge of the regulator tree

[Axel Lin]

2012/6/21 Kim, Milo <Milo.Kim@ti.com>:
>> Caused by commit 809d310c7e69 ("regulator: lp872x: Don't allow modular
>> build") but that was done to fix a different build problem.
>
> Sorry for this conflict.
>
> Build config of lp872x driver has been changed as tristate.
> And related undefined symbol error has been fixed.
> (don't use devm_gpio_request_one() at this moment because it can not be exported.)

I don't think this is the good way, other drivers may have this build problem.
I think we can fix it by having the patch exporting
devm_gpio_request_one upstrem ASAP.

BTW, In yesterday's linux-next tree, Andrew has below commit.

commit a291ede7be8359a8986740b11b93f9c80e40210b
Author: Andrew Morton <akpm@linux-foundation.org>
Date:   Wed Jun 20 09:55:47 2012 +1000

    backlight-l4f00242t03-use-devm_gpio_request_one-fix

    export devm_gpio_request_one() to modules

    Cc: Alberto Panizzo <alberto@amarulasolutions.com>
    Cc: Jingoo Han <jg1.han@samsung.com>
    Cc: Richard Purdie <rpurdie@rpsys.net>
    Cc: Grant Likely <grant.likely@secretlab.ca>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Regards,
Axel

RE: linux-next: build failure after merge of the regulator tree

[Kim, Milo]

> BTW, In yesterday's linux-next tree, Andrew has below commit.
> 
> commit a291ede7be8359a8986740b11b93f9c80e40210b
> Author: Andrew Morton <akpm@linux-foundation.org>
> Date:   Wed Jun 20 09:55:47 2012 +1000
> 
>     backlight-l4f00242t03-use-devm_gpio_request_one-fix
> 
>     export devm_gpio_request_one() to modules
> 
>     Cc: Alberto Panizzo <alberto@amarulasolutions.com>
>     Cc: Jingoo Han <jg1.han@samsung.com>
>     Cc: Richard Purdie <rpurdie@rpsys.net>
>     Cc: Grant Likely <grant.likely@secretlab.ca>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Axel,
Good, thanks a lot !

Mark,
Then please ignore the patch below.
'[PATCH 2/3] regulator: replace devm_gpio_request_one() for loaded module'
https://lkml.org/lkml/2012/6/21/62

But two patches are still valid.
'[PATCH 1/3] regulator: enable module build config for lp872x'
'[PATCH 3/3] regulator: change message level on probing lp872x driver'
https://lkml.org/lkml/2012/6/21/61
https://lkml.org/lkml/2012/6/21/57

Thanks & BR
Milo -

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

On Thu, Jun 21, 2012 at 04:20:46PM +0800, Axel Lin wrote:

> I don't think this is the good way, other drivers may have this build problem.
> I think we can fix it by having the patch exporting
> devm_gpio_request_one upstrem ASAP.

This isn't any use until someone actually merges the patch which given
that it's for gpiolib could take a very long time.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

Hi Andrew,

On Thu, 21 Jun 2012 16:20:46 +0800 Axel Lin <axel.lin@gmail.com> wrote:
>
> 2012/6/21 Kim, Milo <Milo.Kim@ti.com>:
> >> Caused by commit 809d310c7e69 ("regulator: lp872x: Don't allow modular
> >> build") but that was done to fix a different build problem.
> >
> > Sorry for this conflict.
> >
> > Build config of lp872x driver has been changed as tristate.
> > And related undefined symbol error has been fixed.
> > (don't use devm_gpio_request_one() at this moment because it can not be exported.)
> 
> I don't think this is the good way, other drivers may have this build problem.
> I think we can fix it by having the patch exporting
> devm_gpio_request_one upstrem ASAP.
> 
> BTW, In yesterday's linux-next tree, Andrew has below commit.
> 
> commit a291ede7be8359a8986740b11b93f9c80e40210b
> Author: Andrew Morton <akpm@linux-foundation.org>
> Date:   Wed Jun 20 09:55:47 2012 +1000
> 
>     backlight-l4f00242t03-use-devm_gpio_request_one-fix
> 
>     export devm_gpio_request_one() to modules
> 
>     Cc: Alberto Panizzo <alberto@amarulasolutions.com>
>     Cc: Jingoo Han <jg1.han@samsung.com>
>     Cc: Richard Purdie <rpurdie@rpsys.net>
>     Cc: Grant Likely <grant.likely@secretlab.ca>
>     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

This export is needed for a patch in the regulator tree, so can we have
that patch sent to Linus ASAP, please?

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

On Thu, Jun 21, 2012 at 09:04:12PM +1000, Stephen Rothwell wrote:

> This export is needed for a patch in the regulator tree, so can we have
> that patch sent to Linus ASAP, please?

It's going to affect pretty much anything that tries to use the API.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Andrew Morton]

On Thu, 21 Jun 2012 21:04:12 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> This export is needed for a patch in the regulator tree, so can we have
> that patch sent to Linus ASAP, please?

Shall do.

From: Andrew Morton <akpm@linux-foundation.org>
Subject: drivers/gpio/devres.c: export devm_gpio_request_one() to modules

Several drivers in linux-next and possibly mainline are failing due to
this missing export.

Cc: Alberto Panizzo <alberto@amarulasolutions.com>
Cc: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/gpio/devres.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/gpio/devres.c~drivers-gpio-devresc-export-devm_gpio_request_one-to-modules drivers/gpio/devres.c
--- a/drivers/gpio/devres.c~drivers-gpio-devresc-export-devm_gpio_request_one-to-modules
+++ a/drivers/gpio/devres.c
@@ -98,6 +98,7 @@ int devm_gpio_request_one(struct device 
 
 	return 0;
 }
+EXPORT_SYMBOL(devm_gpio_request_one);
 
 /**
  *      devm_gpio_free - free an interrupt
_

Re: linux-next: build failure after merge of the regulator tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

On Thu, Jun 21, 2012 at 08:13:15AM +0000, Kim, Milo wrote:
> > Caused by commit 809d310c7e69 ("regulator: lp872x: Don't allow modular
> > build") but that was done to fix a different build problem.
> 
> Sorry for this conflict.
> 
> Build config of lp872x driver has been changed as tristate.
> And related undefined symbol error has been fixed.
> (don't use devm_gpio_request_one() at this moment because it can not be exported.)

I'm not going to apply those patches, they're a step back in terms of
driver quality.  We just need to bodge the Kconfig dependencies until
the fix for gpiolib gets merged.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 409 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "devm_gpio_request_one" [drivers/regulator/lp872x.ko] undefined!

Caused by commit af8b5fc31099 ("regulator: add new regulator driver for
lp872x").

I have used the regulator tree from next-20120619 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Axel Lin]

2012/6/20 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "devm_gpio_request_one" [drivers/regulator/lp872x.ko] undefined!
>
> Caused by commit af8b5fc31099 ("regulator: add new regulator driver for
> lp872x").

Milo already sent a patch for this:

[PATCH] gpio: add EXPORT_SYMBOL() for devm_gpio_request_one
https://lkml.org/lkml/2012/6/19/58

Also CCed Grant

Re: linux-next: build failure after merge of the regulator tree

[Stephen Warren]

On 06/19/2012 10:55 PM, Axel Lin wrote:
> 2012/6/20 Stephen Rothwell <sfr@canb.auug.org.au>:
>> Hi all,
>>
>> After merging the regulator tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> ERROR: "devm_gpio_request_one" [drivers/regulator/lp872x.ko] undefined!
>>
>> Caused by commit af8b5fc31099 ("regulator: add new regulator driver for
>> lp872x").
> 
> Milo already sent a patch for this:
> 
> [PATCH] gpio: add EXPORT_SYMBOL() for devm_gpio_request_one
> https://lkml.org/lkml/2012/6/19/58

As did I earlier:
https://lkml.org/lkml/2012/6/7/601

I hope that can go into 3.5, since the issue shows up there when
building Tegra audio as modules.

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/ab8500.c: In function 'ab8500_regulator_probe':
drivers/regulator/ab8500.c:783:9: error: invalid type argument of '->' (have 'struct regulator_config')
drivers/regulator/ab8500.c:784:9: error: invalid type argument of '->' (have 'struct regulator_config')
drivers/regulator/ab8500.c:785:9: error: invalid type argument of '->' (have 'struct regulator_config')

Caused by commit c172708d38a4 ("regulator: core: Use a struct to pass in
regulator runtime configuration").

I have used the regulator tree from next-20120405 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the regulator tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Hi all,

After merging the regulator tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/regulator/gpio-regulator.c: In function 'gpio_regulator_probe':
drivers/regulator/gpio-regulator.c:287:8: error: too few arguments to function 'regulator_register'
include/linux/regulator/driver.h:215:23: note: declared here


Caused by commit 2c043bcbf287 ("regulator: pass additional of_node to
regulator_register()").

drivers/regulator/gpio-regulator.c was added in commit 3f0292ae8bb1
("regulator: Add driver for gpio-controlled regulators") which was
included in Linus' tree before v3.2-rc1.

I have used the regulator tree from next-20111123 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the regulator tree

[Rajendra Nayak]

On Thursday 24 November 2011 08:40 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the regulator tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/regulator/gpio-regulator.c: In function 'gpio_regulator_probe':
> drivers/regulator/gpio-regulator.c:287:8: error: too few arguments to function 'regulator_register'
> include/linux/regulator/driver.h:215:23: note: declared here

Thanks Stephen, I just posted a patch to fix this on the regulator
for-next.
https://lkml.org/lkml/2011/11/24/29

>
>
> Caused by commit 2c043bcbf287 ("regulator: pass additional of_node to
> regulator_register()").
>
> drivers/regulator/gpio-regulator.c was added in commit 3f0292ae8bb1
> ("regulator: Add driver for gpio-controlled regulators") which was
> included in Linus' tree before v3.2-rc1.
>
> I have used the regulator tree from next-20111123 for today.