* [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI"
@ 2013-11-07 3:14 Chen Gang
2013-11-07 7:54 ` [alsa-devel] " Clemens Ladisch
2013-11-07 9:29 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Chen Gang @ 2013-11-07 3:14 UTC (permalink / raw)
To: Takashi Iwai, perex, dhowells; +Cc: alsa-devel, linux-kernel
When installing, "scripts/headers_install.sh" will strip guard macro'
"_UAPI" to prevent from appearing it to users. And also, all another
files which need uapi prefix always use "_UAPI", not "UAPI".
So use "_UAPI" instead of "UAPI" on the guard macro, and also give a
comment for "#endif".
Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
include/uapi/sound/firewire.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/sound/firewire.h b/include/uapi/sound/firewire.h
index e86131c..59f5961 100644
--- a/include/uapi/sound/firewire.h
+++ b/include/uapi/sound/firewire.h
@@ -1,5 +1,5 @@
-#ifndef UAPI_SOUND_FIREWIRE_H_INCLUDED
-#define UAPI_SOUND_FIREWIRE_H_INCLUDED
+#ifndef _UAPI_SOUND_FIREWIRE_H_INCLUDED
+#define _UAPI_SOUND_FIREWIRE_H_INCLUDED
#include <linux/ioctl.h>
@@ -48,4 +48,4 @@ struct snd_firewire_get_info {
* Returns -EBUSY if the driver is already streaming.
*/
-#endif
+#endif /* _UAPI_SOUND_FIREWIRE_H_INCLUDED */
--
1.7.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI"
2013-11-07 3:14 [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI" Chen Gang
@ 2013-11-07 7:54 ` Clemens Ladisch
2013-11-07 9:50 ` Chen Gang
2013-11-07 9:29 ` Takashi Iwai
1 sibling, 1 reply; 5+ messages in thread
From: Clemens Ladisch @ 2013-11-07 7:54 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Chen Gang, alsa-devel, linux-kernel
Chen Gang wrote:
> When installing, "scripts/headers_install.sh" will strip guard macro'
> "_UAPI" to prevent from appearing it to users. And also, all another
> files which need uapi prefix always use "_UAPI", not "UAPI".
>
> So use "_UAPI" instead of "UAPI" on the guard macro, and also give a
> comment for "#endif".
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Acked-by: Clemens Ladisch <clemens@ladisch.de>
> ---
> include/uapi/sound/firewire.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/sound/firewire.h b/include/uapi/sound/firewire.h
> index e86131c..59f5961 100644
> --- a/include/uapi/sound/firewire.h
> +++ b/include/uapi/sound/firewire.h
> @@ -1,5 +1,5 @@
> -#ifndef UAPI_SOUND_FIREWIRE_H_INCLUDED
> -#define UAPI_SOUND_FIREWIRE_H_INCLUDED
> +#ifndef _UAPI_SOUND_FIREWIRE_H_INCLUDED
> +#define _UAPI_SOUND_FIREWIRE_H_INCLUDED
>
> #include <linux/ioctl.h>
>
> @@ -48,4 +48,4 @@ struct snd_firewire_get_info {
> * Returns -EBUSY if the driver is already streaming.
> */
>
> -#endif
> +#endif /* _UAPI_SOUND_FIREWIRE_H_INCLUDED */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI"
2013-11-07 3:14 [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI" Chen Gang
2013-11-07 7:54 ` [alsa-devel] " Clemens Ladisch
@ 2013-11-07 9:29 ` Takashi Iwai
2013-11-07 9:49 ` Chen Gang
1 sibling, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2013-11-07 9:29 UTC (permalink / raw)
To: Chen Gang; +Cc: perex, dhowells, alsa-devel, linux-kernel
At Thu, 07 Nov 2013 11:14:29 +0800,
Chen Gang wrote:
>
> When installing, "scripts/headers_install.sh" will strip guard macro'
> "_UAPI" to prevent from appearing it to users. And also, all another
> files which need uapi prefix always use "_UAPI", not "UAPI".
>
> So use "_UAPI" instead of "UAPI" on the guard macro, and also give a
> comment for "#endif".
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Thanks, applied.
Takashi
> ---
> include/uapi/sound/firewire.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/sound/firewire.h b/include/uapi/sound/firewire.h
> index e86131c..59f5961 100644
> --- a/include/uapi/sound/firewire.h
> +++ b/include/uapi/sound/firewire.h
> @@ -1,5 +1,5 @@
> -#ifndef UAPI_SOUND_FIREWIRE_H_INCLUDED
> -#define UAPI_SOUND_FIREWIRE_H_INCLUDED
> +#ifndef _UAPI_SOUND_FIREWIRE_H_INCLUDED
> +#define _UAPI_SOUND_FIREWIRE_H_INCLUDED
>
> #include <linux/ioctl.h>
>
> @@ -48,4 +48,4 @@ struct snd_firewire_get_info {
> * Returns -EBUSY if the driver is already streaming.
> */
>
> -#endif
> +#endif /* _UAPI_SOUND_FIREWIRE_H_INCLUDED */
> --
> 1.7.7.6
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI"
2013-11-07 9:29 ` Takashi Iwai
@ 2013-11-07 9:49 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2013-11-07 9:49 UTC (permalink / raw)
To: Takashi Iwai; +Cc: perex, dhowells, alsa-devel, linux-kernel
On 11/07/2013 05:29 PM, Takashi Iwai wrote:
> At Thu, 07 Nov 2013 11:14:29 +0800,
> Chen Gang wrote:
>> >
>> > When installing, "scripts/headers_install.sh" will strip guard macro'
>> > "_UAPI" to prevent from appearing it to users. And also, all another
>> > files which need uapi prefix always use "_UAPI", not "UAPI".
>> >
>> > So use "_UAPI" instead of "UAPI" on the guard macro, and also give a
>> > comment for "#endif".
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Thanks, applied.
Thank you very much !!
--
Chen Gang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI"
2013-11-07 7:54 ` [alsa-devel] " Clemens Ladisch
@ 2013-11-07 9:50 ` Chen Gang
0 siblings, 0 replies; 5+ messages in thread
From: Chen Gang @ 2013-11-07 9:50 UTC (permalink / raw)
To: Clemens Ladisch; +Cc: Takashi Iwai, alsa-devel, linux-kernel
On 11/07/2013 03:54 PM, Clemens Ladisch wrote:
> Chen Gang wrote:
>> > When installing, "scripts/headers_install.sh" will strip guard macro'
>> > "_UAPI" to prevent from appearing it to users. And also, all another
>> > files which need uapi prefix always use "_UAPI", not "UAPI".
>> >
>> > So use "_UAPI" instead of "UAPI" on the guard macro, and also give a
>> > comment for "#endif".
>> >
>> > Signed-off-by: Chen Gang <gang.chen@asianux.com>
> Acked-by: Clemens Ladisch <clemens@ladisch.de>
>
Thank you very much !!
--
Chen Gang
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-07 9:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-07 3:14 [PATCH] include/uapi/sound/firewire.h: use "_UAPI" instead of "UAPI" Chen Gang
2013-11-07 7:54 ` [alsa-devel] " Clemens Ladisch
2013-11-07 9:50 ` Chen Gang
2013-11-07 9:29 ` Takashi Iwai
2013-11-07 9:49 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).