From: Stephen Warren <swarren@wwwdotorg.org>
To: Stefan Agner <stefan@agner.ch>,
thierry.reding@gmail.com, sameo@linux.intel.com, dev@lynxeye.de
Cc: mark.rutland@arm.com, linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: tps6586x: add version detection
Date: Wed, 27 Nov 2013 09:58:50 -0700 [thread overview]
Message-ID: <529624CA.6030604@wwwdotorg.org> (raw)
In-Reply-To: <ef881d39f78b75b4badeebb5be0264edc3906d86.1385508112.git.stefan@agner.ch>
On 11/26/2013 04:45 PM, Stefan Agner wrote:
> Use the VERSIONCRC to determine the exact device version. According to
> the datasheet this register can be used as device identifier. The
> identification is needed since some tps6586x regulators use a different
> voltage table.
> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> @@ -477,6 +486,7 @@ static int tps6586x_i2c_probe(struct i2c_client *client,
> {
> struct tps6586x_platform_data *pdata = dev_get_platdata(&client->dev);
> struct tps6586x *tps6586x;
> + const char *name = "";
There's no need to assign any value here; the switch below always
assigns something over the top of the variable, so it doesn't need to be
pre-initialized.
> + tps6586x = devm_kzalloc(&client->dev, sizeof(*tps6586x), GFP_KERNEL);
> + if (tps6586x == NULL) {
> + dev_err(&client->dev, "memory for tps6586x alloc failed\n");
> + return -ENOMEM;
> + }
> + tps6586x->version = (enum tps6586x_version)ret;
Why not make the version variable an integer of some kind. Then, the
cast wouldn't be required. The values like TPS658621A can be #defines or
const u32.
> + switch (ret) {
That should switch on tps6586x->version since that's been assigned;
it'll make the purpose a bit clearer.
> + default:
> + name = "TPS6586X";
> + break;
> }
I hope the rest of the code deals with unknown values of
tps6586x->version OK.
next prev parent reply other threads:[~2013-11-27 16:58 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 23:45 [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-11-26 23:45 ` [PATCH 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-11-27 13:09 ` Lee Jones
2013-11-27 13:11 ` Lee Jones
2013-11-27 13:49 ` Stefan Agner
2013-11-27 13:55 ` Lee Jones
[not found] ` <cfb203a896eda67c106794d89e668d56@agner.ch>
[not found] ` <20131127143429.GN3296@lee--X1>
2013-11-27 14:36 ` Lee Jones
2013-11-27 15:26 ` Stefan Agner
2013-11-27 15:30 ` Lee Jones
2013-11-27 15:52 ` Stefan Agner
2013-11-27 16:14 ` Lee Jones
2013-11-27 16:58 ` Stephen Warren [this message]
2013-11-27 21:44 ` Stefan Agner
2013-11-26 23:45 ` [PATCH 2/3] regulator: tps6586x: add voltage table for tps658643 Stefan Agner
2013-11-27 17:09 ` Stephen Warren
2013-11-27 21:56 ` Stefan Agner
2013-11-28 8:30 ` Thierry Reding
2013-11-26 23:45 ` [PATCH 3/3] ARM: tegra: set SM2 voltage correct Stefan Agner
2013-11-27 9:59 ` Lucas Stach
2013-11-27 11:05 ` Stefan Agner
2013-11-27 11:06 ` Lucas Stach
2013-11-27 17:13 ` Stephen Warren
2013-11-27 22:03 ` Stefan Agner
2013-11-28 9:49 ` Lucas Stach
2013-11-30 16:24 ` Stefan Agner
2013-11-28 8:13 ` [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Thierry Reding
2013-11-29 8:20 ` Kai Poggensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529624CA.6030604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=dev@lynxeye.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sameo@linux.intel.com \
--cc=stefan@agner.ch \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).