From: Stefan Agner <stefan@agner.ch>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
thierry.reding@gmail.com, sameo@linux.intel.com, dev@lynxeye.de,
mark.rutland@arm.com, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] ARM: tegra: set SM2 voltage correct
Date: Sat, 30 Nov 2013 17:24:14 +0100 [thread overview]
Message-ID: <ab16891b4a6bcfbb1854aa766e4926a7@agner.ch> (raw)
In-Reply-To: <1385632196.5838.4.camel@weser.hi.pengutronix.de>
Am 2013-11-28 10:49, schrieb Lucas Stach:
> Am Mittwoch, den 27.11.2013, 10:13 -0700 schrieb Stephen Warren:
>> On 11/26/2013 04:45 PM, Stefan Agner wrote:
>> > Set the requested SM2 voltage to the correct value of 1.8V. The value
>> > before used to work on TPS658623 since the driver applied a wrong
>> > voltage table too. However, the TPS658643 used on newer devices uses
>> > yet another voltage table and those broke that compatibility. The
>> > regulator driver now has the correct voltage table for both regulator
>> > versions and those the correct voltage can be used in this device
>> > tree.
>>
>> One thing you haven't called out explicitly here is that this series is
>> an incompatible change to the DT, since the old buggy driver used to
>> allow old buggy DT content to accidentally work.
>>
> The current (wrong and potentially dangerous) DT content only worked on
> the engineering sample models. So this change definitely does improve
> the situation, even with the risk of breaking a small fraction of
> working boards.
On the released modules, the current value ends in a freeze during
boot-up (since the wrong voltage table results in a too low voltage).
When I use 1.8V in the device tree, the old drivers refuses to set any
voltage. The regulators default/bootloader settings work then better
than the wrongfully applied values (tested on a new device). The probe
just fails:
[ 0.243864] tps6586x-regulator tps6586x-regulator: failed to register
regulator REG-SM_2
[ 0.244317] tps6586x-regulator: probe of tps6586x-regulator failed
with error -22
So, for newer modules, the incompatible 1.8V DT results in a successful
boot. Since we don't have a regulator driver at all, likely other things
are broken at that situation...
--
Stefan
next prev parent reply other threads:[~2013-11-30 16:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 23:45 [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-11-26 23:45 ` [PATCH 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-11-27 13:09 ` Lee Jones
2013-11-27 13:11 ` Lee Jones
2013-11-27 13:49 ` Stefan Agner
2013-11-27 13:55 ` Lee Jones
[not found] ` <cfb203a896eda67c106794d89e668d56@agner.ch>
[not found] ` <20131127143429.GN3296@lee--X1>
2013-11-27 14:36 ` Lee Jones
2013-11-27 15:26 ` Stefan Agner
2013-11-27 15:30 ` Lee Jones
2013-11-27 15:52 ` Stefan Agner
2013-11-27 16:14 ` Lee Jones
2013-11-27 16:58 ` Stephen Warren
2013-11-27 21:44 ` Stefan Agner
2013-11-26 23:45 ` [PATCH 2/3] regulator: tps6586x: add voltage table for tps658643 Stefan Agner
2013-11-27 17:09 ` Stephen Warren
2013-11-27 21:56 ` Stefan Agner
2013-11-28 8:30 ` Thierry Reding
2013-11-26 23:45 ` [PATCH 3/3] ARM: tegra: set SM2 voltage correct Stefan Agner
2013-11-27 9:59 ` Lucas Stach
2013-11-27 11:05 ` Stefan Agner
2013-11-27 11:06 ` Lucas Stach
2013-11-27 17:13 ` Stephen Warren
2013-11-27 22:03 ` Stefan Agner
2013-11-28 9:49 ` Lucas Stach
2013-11-30 16:24 ` Stefan Agner [this message]
2013-11-28 8:13 ` [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Thierry Reding
2013-11-29 8:20 ` Kai Poggensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab16891b4a6bcfbb1854aa766e4926a7@agner.ch \
--to=stefan@agner.ch \
--cc=dev@lynxeye.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).