From: Stefan Agner <stefan@agner.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: swarren@wwwdotorg.org, thierry.reding@gmail.com,
sameo@linux.intel.com, dev@lynxeye.de, mark.rutland@arm.com,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] mfd: tps6586x: add version detection
Date: Wed, 27 Nov 2013 16:52:39 +0100 [thread overview]
Message-ID: <89dbf704d8617c77259e04753e4380c9@agner.ch> (raw)
In-Reply-To: <20131127153019.GR3296@lee--X1>
Am 2013-11-27 16:30, schrieb Lee Jones:
> On Wed, 27 Nov 2013, Stefan Agner wrote:
>
>> Am 2013-11-27 15:36, schrieb Lee Jones:
>> <snip>
>> >> Perhaps I should suggest to make TPS6586X_ANY a positive number then,
>> >> as a negative value to me indicates more of an error than a generic
>> >> parameter.
>> I see, its especially confusing since the version is filled using the
>> i2c_smbus_read_byte_data functions return value. The version field is a
>> 8-Bit value according to the data sheet, I could use 0x100 as
>> TPS6586X_ANY identifier.
>
> How far are we away from using 0xFF?
>
> I'd be happy to use that and change it _if_ we ever get close.
>
> If it's likely that it'll be used, then sure 0x100 sounds okay too.
Yes, I thought about 0xFF too. The latest device we support is TPS658643
(according to data sheet release dates), which has the smallest version
number (03). Since it seems to be a CRC (hence VERSIONCRC) the number is
quite random. Also, 0xFF sounds like a bitmask which can mask all
versions, but the versions can't be used bitwise... So I would prefer to
go with 0x100.
next prev parent reply other threads:[~2013-11-27 15:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 23:45 [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Stefan Agner
2013-11-26 23:45 ` [PATCH 1/3] mfd: tps6586x: add version detection Stefan Agner
2013-11-27 13:09 ` Lee Jones
2013-11-27 13:11 ` Lee Jones
2013-11-27 13:49 ` Stefan Agner
2013-11-27 13:55 ` Lee Jones
[not found] ` <cfb203a896eda67c106794d89e668d56@agner.ch>
[not found] ` <20131127143429.GN3296@lee--X1>
2013-11-27 14:36 ` Lee Jones
2013-11-27 15:26 ` Stefan Agner
2013-11-27 15:30 ` Lee Jones
2013-11-27 15:52 ` Stefan Agner [this message]
2013-11-27 16:14 ` Lee Jones
2013-11-27 16:58 ` Stephen Warren
2013-11-27 21:44 ` Stefan Agner
2013-11-26 23:45 ` [PATCH 2/3] regulator: tps6586x: add voltage table for tps658643 Stefan Agner
2013-11-27 17:09 ` Stephen Warren
2013-11-27 21:56 ` Stefan Agner
2013-11-28 8:30 ` Thierry Reding
2013-11-26 23:45 ` [PATCH 3/3] ARM: tegra: set SM2 voltage correct Stefan Agner
2013-11-27 9:59 ` Lucas Stach
2013-11-27 11:05 ` Stefan Agner
2013-11-27 11:06 ` Lucas Stach
2013-11-27 17:13 ` Stephen Warren
2013-11-27 22:03 ` Stefan Agner
2013-11-28 9:49 ` Lucas Stach
2013-11-30 16:24 ` Stefan Agner
2013-11-28 8:13 ` [PATCH 0/3] regulator: tps6586x: add version detection and voltage tables Thierry Reding
2013-11-29 8:20 ` Kai Poggensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89dbf704d8617c77259e04753e4380c9@agner.ch \
--to=stefan@agner.ch \
--cc=dev@lynxeye.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).