From: Lawrence Brakmo <brakmo@fb.com>
To: David Miller <davem@davemloft.net>,
"olivier.tilmans@nokia-bell-labs.com"
<olivier.tilmans@nokia-bell-labs.com>
Cc: "koen.de_schepper@nokia-bell-labs.com"
<koen.de_schepper@nokia-bell-labs.com>,
"research@bobbriscoe.net" <research@bobbriscoe.net>,
"fw@strlen.de" <fw@strlen.de>,
"borkmann@iogearbox.net" <borkmann@iogearbox.net>,
"ycheng@google.com" <ycheng@google.com>,
"ncardwell@google.com" <ncardwell@google.com>,
"edumazet@google.com" <edumazet@google.com>,
"agshew@gmail.com" <agshew@gmail.com>,
"glenn.judd@morganstanley.com" <glenn.judd@morganstanley.com>,
"kuznet@ms2.inr.ac.ru" <kuznet@ms2.inr.ac.ru>,
"yoshfuji@linux-ipv6.org" <yoshfuji@linux-ipv6.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses
Date: Thu, 4 Apr 2019 18:10:42 +0000 [thread overview]
Message-ID: <532BB0D8-95C8-4A4D-A73D-3B563909780F@fb.com> (raw)
In-Reply-To: <20190404.105243.1039649838417325989.davem@davemloft.net>
On 4/4/19, 10:53 AM, "David Miller" <davem@davemloft.net> wrote:
From: "Tilmans, Olivier (Nokia - BE/Antwerp)" <olivier.tilmans@nokia-bell-labs.com>
Date: Thu, 4 Apr 2019 12:24:02 +0000
> RFC8257 §3.5 explicitly states that "A DCTCP sender MUST react to
> loss episodes in the same way as conventional TCP".
...
> This patch replace the clamping of alpha by setting ssthresh to
> half of cwnd for both fast retransmissions and RTOs, at most once
> per RTT. Consequently, the dctcp_clamp_alpha_on_loss module parameter
> has been removed.
Applied to 'net' and queued up for -stable, thanks.
DCTCP is meant to be used in environments where the switches/routers do ECN marking, so it is not surprising that it performs badly when used in environments where it was not meant to be used. Has anyone measured the effect of this changed when DCTCP is used in environments where all the switches/routers do ECN marking? My concern is that we could end up hurting performance when DCTCP is used how it was meant to be used in order to protect incorrect uses of DCTCP.
next prev parent reply other threads:[~2019-04-04 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 12:24 [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses Tilmans, Olivier (Nokia - BE/Antwerp)
2019-04-04 13:17 ` Florian Westphal
2019-04-04 13:48 ` Neal Cardwell
2019-04-04 13:55 ` Neal Cardwell
2019-04-04 13:59 ` Daniel Borkmann
2019-04-04 17:52 ` David Miller
2019-04-04 18:10 ` Lawrence Brakmo [this message]
2019-04-04 18:39 ` Tilmans, Olivier (Nokia - BE/Antwerp)
2019-04-04 18:55 ` Lawrence Brakmo
2019-04-05 9:23 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532BB0D8-95C8-4A4D-A73D-3B563909780F@fb.com \
--to=brakmo@fb.com \
--cc=agshew@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=glenn.judd@morganstanley.com \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=research@bobbriscoe.net \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).