From: Neal Cardwell <ncardwell@google.com>
To: "Tilmans,
Olivier (Nokia - BE/Antwerp)"
<olivier.tilmans@nokia-bell-labs.com>
Cc: "De Schepper,
Koen (Nokia - BE/Antwerp)"
<koen.de_schepper@nokia-bell-labs.com>,
Bob Briscoe <research@bobbriscoe.net>,
Lawrence Brakmo <brakmo@fb.com>, Florian Westphal <fw@strlen.de>,
Daniel Borkmann <borkmann@iogearbox.net>,
Yuchung Cheng <ycheng@google.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Shewmaker <agshew@gmail.com>,
Glenn Judd <glenn.judd@morganstanley.com>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses
Date: Thu, 4 Apr 2019 09:55:19 -0400 [thread overview]
Message-ID: <CADVnQyks1T8KZibJF+UWR0zWGvqs+fUBkCYPJFxATx5PU-csSQ@mail.gmail.com> (raw)
In-Reply-To: <CADVnQy=hsPrDwXoym18j7YzCc36669NJ1kVBR76y+FgK6Meytw@mail.gmail.com>
On Thu, Apr 4, 2019 at 9:48 AM Neal Cardwell <ncardwell@google.com> wrote:
>
> On Thu, Apr 4, 2019 at 8:24 AM Tilmans, Olivier (Nokia - BE/Antwerp)
> <olivier.tilmans@nokia-bell-labs.com> wrote:
> >
> > From: Koen De Schepper <koen.de_schepper@nokia-bell-labs.com>
> >
> > RFC8257 §3.5 explicitly states that "A DCTCP sender MUST react to
> > loss episodes in the same way as conventional TCP".
> ...
> > This patch replace the clamping of alpha by setting ssthresh to
> > half of cwnd for both fast retransmissions and RTOs, at most once
> > per RTT. Consequently, the dctcp_clamp_alpha_on_loss module parameter
> > has been removed.
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
>
> Thanks!
FWIW, my vote is that this is an important bug fix that is appropriate
for the net branch and -stable releases, rather than net-next.
neal
next prev parent reply other threads:[~2019-04-04 13:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 12:24 [PATCH net-next v2] tcp: Ensure DCTCP reacts to losses Tilmans, Olivier (Nokia - BE/Antwerp)
2019-04-04 13:17 ` Florian Westphal
2019-04-04 13:48 ` Neal Cardwell
2019-04-04 13:55 ` Neal Cardwell [this message]
2019-04-04 13:59 ` Daniel Borkmann
2019-04-04 17:52 ` David Miller
2019-04-04 18:10 ` Lawrence Brakmo
2019-04-04 18:39 ` Tilmans, Olivier (Nokia - BE/Antwerp)
2019-04-04 18:55 ` Lawrence Brakmo
2019-04-05 9:23 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADVnQyks1T8KZibJF+UWR0zWGvqs+fUBkCYPJFxATx5PU-csSQ@mail.gmail.com \
--to=ncardwell@google.com \
--cc=agshew@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=brakmo@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=glenn.judd@morganstanley.com \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olivier.tilmans@nokia-bell-labs.com \
--cc=research@bobbriscoe.net \
--cc=ycheng@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).