linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	gorcunov@openvz.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	luto@amacapital.net, mingo@kernel.org, sasha.levin@oracle.com,
	stefani@seibold.net, tglx@linutronix.de, xemul@parallels.com,
	kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [GIT PULL] x86/vdso changes for v3.16
Date: Fri, 06 Jun 2014 14:07:11 -0700	[thread overview]
Message-ID: <53922D7F.8090601@linux.intel.com> (raw)
In-Reply-To: <20140606140017.afb7f91142f66cb3dd13c186@linux-foundation.org>

On 06/06/2014 02:00 PM, Andrew Morton wrote:
> On Wed, 4 Jun 2014 15:35:42 -0700 "H. Peter Anvin" <hpa@linux.intel.com> wrote:
> 
>> Vdso cleanups and improvements largely from Andy Lutomirski.
> 
> arch/x86/vdso/vdso2c.h: In function 'go64':
> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le64toh'
> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le32toh'
> arch/x86/vdso/vdso2c.h:21: warning: implicit declaration of function 'le16toh'
> arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16'
> 
> My Fedora Core 6 (lol gotcha) test box doesn't have these.
> 
> http://www.unix.com/man-page/linux/3/le64toh/ has some details.  I
> don't appear to have letoh64 and friends either.  
> 

OK... so now we have a tools baseline problem.  It isn't that we
couldn't open-code these functions, but of course we'd also like to not
*have* to do so... but also we don't want to have the kernel build rely
on autoconf ;)

So we have a few options, here:

1. We could use the unaligned macros defined in
   tools/include/tools/*_byteshift.h.

2. Open-code it.

3. Define a baseline which includes these kinds of functions.

I guess I would be leaning toward #1, but would also wonder if that also
means we should add -I$(srctree)/tools/include to the global settings
... we are *already* adding it to HOSTCFLAGS_sortextable.o.

Thoughs?

	-hpa


  reply	other threads:[~2014-06-06 21:07 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 22:35 [GIT PULL] x86/vdso changes for v3.16 H. Peter Anvin
2014-06-06 21:00 ` Andrew Morton
2014-06-06 21:07   ` H. Peter Anvin [this message]
2014-06-08 17:18     ` Sam Ravnborg
2014-06-08 18:54       ` H. Peter Anvin
2014-06-06 21:07   ` Linus Torvalds
2014-06-06 21:09     ` Andy Lutomirski
2014-06-06 21:13       ` Linus Torvalds
2014-06-06 21:14         ` Andy Lutomirski
2014-06-06 21:15         ` H. Peter Anvin
2014-06-06 21:22           ` Andy Lutomirski
2014-06-06 21:25             ` H. Peter Anvin
2014-06-06 21:33               ` Andy Lutomirski
2014-06-06 21:37                 ` H. Peter Anvin
2014-06-06 21:39                   ` Andy Lutomirski
2014-06-06 21:42                     ` H. Peter Anvin
2014-06-06 21:44                       ` Andy Lutomirski
2014-06-06 21:36             ` H. Peter Anvin
2014-06-06 22:00   ` [tip:x86/vdso] x86, vdso: Use <tools/le_byteshift.h> for littleendian access tip-bot for H. Peter Anvin
2014-06-10 20:50     ` Andrew Morton
2014-06-10 21:28       ` H. Peter Anvin
2014-06-10 21:35         ` Andy Lutomirski
2014-06-10 22:06         ` Andrew Morton
2014-06-10 22:43       ` [tip:x86/vdso] x86, vdso: Remove one final use of htole16() tip-bot for H. Peter Anvin
2014-06-10 22:57       ` tip-bot for H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53922D7F.8090601@linux.intel.com \
    --to=hpa@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=gorcunov@openvz.org \
    --cc=hpa@zytor.com \
    --cc=kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=sasha.levin@oracle.com \
    --cc=stefani@seibold.net \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).