From: Andy Lutomirski <luto@amacapital.net>
To: "H. Peter Anvin" <hpa@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Peter Anvin <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Sasha Levin <sasha.levin@oracle.com>,
Stefani Seibold <stefani@seibold.net>,
Thomas Gleixner <tglx@linutronix.de>,
Pavel Emelyanov <xemul@parallels.com>
Subject: Re: [GIT PULL] x86/vdso changes for v3.16
Date: Fri, 6 Jun 2014 14:22:12 -0700 [thread overview]
Message-ID: <CALCETrXpCMdyPjM6MSbxoi0matoYLfduuSiwmTjGCUU62KOsTw@mail.gmail.com> (raw)
In-Reply-To: <53922F74.20406@linux.intel.com>
On Fri, Jun 6, 2014 at 2:15 PM, H. Peter Anvin <hpa@linux.intel.com> wrote:
> On 06/06/2014 02:13 PM, Linus Torvalds wrote:
>> On Fri, Jun 6, 2014 at 2:09 PM, Andy Lutomirski <luto@amacapital.net> wrote:
>>>
>>> The only real downside to that would be the chance of bitrot if that
>>> code isn't getting used on native builds.
>>
>> Sure. Does anybody really care?
>>
>> You could obviously just open-code the things, but the fact is,
>> "le64toh()" isn't exactly a standard function anyway, so now that I
>> see it needed I go "yeah, that's clearly completely unacceptable".
>>
>> I'd much rather say "screw cross-compiling" (because let's face it,
>> nobody sane cross-compiles x86 on anything else) than say "screw old
>> machines".
>>
>
> I'm thinking we should just carry the support functions with us, we
> already have some of those in tools/include. Working on a patchset for
> this.
Sounds good.
In the mean time, a trivial fix is here:
https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git/commit/?h=vdso/cleanup_fixes&id=cf780a0dc71f7cbd9a417e6ce2d5ddf56abccb74
(or it will be once the mirrors sync)
--Andy
next prev parent reply other threads:[~2014-06-06 21:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 22:35 [GIT PULL] x86/vdso changes for v3.16 H. Peter Anvin
2014-06-06 21:00 ` Andrew Morton
2014-06-06 21:07 ` H. Peter Anvin
2014-06-08 17:18 ` Sam Ravnborg
2014-06-08 18:54 ` H. Peter Anvin
2014-06-06 21:07 ` Linus Torvalds
2014-06-06 21:09 ` Andy Lutomirski
2014-06-06 21:13 ` Linus Torvalds
2014-06-06 21:14 ` Andy Lutomirski
2014-06-06 21:15 ` H. Peter Anvin
2014-06-06 21:22 ` Andy Lutomirski [this message]
2014-06-06 21:25 ` H. Peter Anvin
2014-06-06 21:33 ` Andy Lutomirski
2014-06-06 21:37 ` H. Peter Anvin
2014-06-06 21:39 ` Andy Lutomirski
2014-06-06 21:42 ` H. Peter Anvin
2014-06-06 21:44 ` Andy Lutomirski
2014-06-06 21:36 ` H. Peter Anvin
2014-06-06 22:00 ` [tip:x86/vdso] x86, vdso: Use <tools/le_byteshift.h> for littleendian access tip-bot for H. Peter Anvin
2014-06-10 20:50 ` Andrew Morton
2014-06-10 21:28 ` H. Peter Anvin
2014-06-10 21:35 ` Andy Lutomirski
2014-06-10 22:06 ` Andrew Morton
2014-06-10 22:43 ` [tip:x86/vdso] x86, vdso: Remove one final use of htole16() tip-bot for H. Peter Anvin
2014-06-10 22:57 ` tip-bot for H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrXpCMdyPjM6MSbxoi0matoYLfduuSiwmTjGCUU62KOsTw@mail.gmail.com \
--to=luto@amacapital.net \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sasha.levin@oracle.com \
--cc=stefani@seibold.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).