Re: [tip:x86/vdso] x86, vdso: Use <tools/le_byteshift.h> for littleendian access

["H. Peter Anvin" <hpa@zytor.com>]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

On 06/10/2014 01:50 PM, Andrew Morton wrote:
> On Fri, 6 Jun 2014 15:00:29 -0700 "tip-bot for H. Peter Anvin" <tipbot@zytor.com> wrote:
> 
>> Commit-ID:  bdfb9bcc25005d06a9c301830bdeb7ca5a0b6ef7
>> Gitweb:     http://git.kernel.org/tip/bdfb9bcc25005d06a9c301830bdeb7ca5a0b6ef7
>> Author:     H. Peter Anvin <hpa@linux.intel.com>
>> AuthorDate: Fri, 6 Jun 2014 14:30:37 -0700
>> Committer:  H. Peter Anvin <hpa@linux.intel.com>
>> CommitDate: Fri, 6 Jun 2014 14:54:54 -0700
>>
>> x86, vdso: Use <tools/le_byteshift.h> for littleendian access
> 
> Getting closer.
> 
> In file included from arch/x86/vdso/vdso2c.c:80:
> arch/x86/vdso/vdso2c.h: In function 'go64':
> arch/x86/vdso/vdso2c.h:119: warning: implicit declaration of function 'htole16'
> /tmp/cc04m2KE.o: In function `go':
> vdso2c.c:(.text+0xf69): undefined reference to `htole16'
> vdso2c.c:(.text+0x12e6): undefined reference to `htole16'
> 

Want to test this patch before I commit it?

	-hpa


[-- Attachment #2: 0001-x86-vdso-Remove-one-final-use-of-htole16.patch --]
[-- Type: text/x-patch, Size: 1355 bytes --]

>From 15ea1a528e08c6bc322f10686ec8d73ba413b941 Mon Sep 17 00:00:00 2001
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Tue, 10 Jun 2014 14:25:26 -0700
Subject: [PATCH] x86, vdso: Remove one final use of htole16()

One final use of the macros from <endian.h> which are not available on
older system.  In this case we had one sole case of *writing* a
littleendian number, but the number is SHN_UNDEF which is the constant
zero, so rather than dealing with the general case of littleendian
puts here, just document that the constant is zero and be done with
it.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Link: http://lkml.kernel.org/r/20140610135051.c3c34165f73d67d218b62bd9@linux-foundation.org
---
 arch/x86/vdso/vdso2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/vdso/vdso2c.h b/arch/x86/vdso/vdso2c.h
index 8a074637a576..d9f6f61aef1c 100644
--- a/arch/x86/vdso/vdso2c.h
+++ b/arch/x86/vdso/vdso2c.h
@@ -116,7 +116,7 @@ static void GOFUNC(void *addr, size_t len, FILE *outfile, const char *name)
 	hdr->e_shoff = 0;
 	hdr->e_shentsize = 0;
 	hdr->e_shnum = 0;
-	hdr->e_shstrndx = htole16(SHN_UNDEF);
+	hdr->e_shstrndx = SHN_UNDEF; /* SHN_UNDEF == 0 */
 
 	if (!name) {
 		fwrite(addr, load_size, 1, outfile);
-- 
1.9.3