From: Sibi Sankar <quic_sibis@quicinc.com>
To: Bjorn Andersson <quic_bjorande@quicinc.com>,
Georgi Djakov <djakov@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
"Rob Herring" <robh+dt@kernel.org>,
Mike Tipton <quic_mdtipton@quicinc.com>,
"Johan Hovold" <johan+linaro@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/10] interconnect: qcom: osm-l3: Squash common descriptors
Date: Fri, 11 Nov 2022 15:54:20 +0530 [thread overview]
Message-ID: <54982867-6495-ee1e-889f-65fa5e5b2912@quicinc.com> (raw)
In-Reply-To: <20221111032515.3460-3-quic_bjorande@quicinc.com>
On 11/11/22 08:55, Bjorn Andersson wrote:
> Each platform defines their own OSM L3 descriptor, but in practice
> there's only two: one for OSM and one for EPSS. Remove the duplicated
> definitions.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
> Tested-by: Steev Klimaszewski <steev@kali.org>
Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
>
> Changes since v1:
> - None
>
> drivers/interconnect/qcom/osm-l3.c | 48 +++++-------------------------
> 1 file changed, 8 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/osm-l3.c b/drivers/interconnect/qcom/osm-l3.c
> index d23769844419..7d6844253241 100644
> --- a/drivers/interconnect/qcom/osm-l3.c
> +++ b/drivers/interconnect/qcom/osm-l3.c
> @@ -104,7 +104,7 @@ static const struct qcom_osm_l3_node * const epss_l3_nodes[] = {
> [SLAVE_EPSS_L3_SHARED] = &epss_l3_slave,
> };
>
> -static const struct qcom_osm_l3_desc sdm845_icc_osm_l3 = {
> +static const struct qcom_osm_l3_desc osm_l3 = {
> .nodes = osm_l3_nodes,
> .num_nodes = ARRAY_SIZE(osm_l3_nodes),
> .lut_row_size = OSM_LUT_ROW_SIZE,
> @@ -112,39 +112,7 @@ static const struct qcom_osm_l3_desc sdm845_icc_osm_l3 = {
> .reg_perf_state = OSM_REG_PERF_STATE,
> };
>
> -static const struct qcom_osm_l3_desc sc7180_icc_osm_l3 = {
> - .nodes = osm_l3_nodes,
> - .num_nodes = ARRAY_SIZE(osm_l3_nodes),
> - .lut_row_size = OSM_LUT_ROW_SIZE,
> - .reg_freq_lut = OSM_REG_FREQ_LUT,
> - .reg_perf_state = OSM_REG_PERF_STATE,
> -};
> -
> -static const struct qcom_osm_l3_desc sc7280_icc_epss_l3 = {
> - .nodes = epss_l3_nodes,
> - .num_nodes = ARRAY_SIZE(epss_l3_nodes),
> - .lut_row_size = EPSS_LUT_ROW_SIZE,
> - .reg_freq_lut = EPSS_REG_FREQ_LUT,
> - .reg_perf_state = EPSS_REG_PERF_STATE,
> -};
> -
> -static const struct qcom_osm_l3_desc sc8180x_icc_osm_l3 = {
> - .nodes = osm_l3_nodes,
> - .num_nodes = ARRAY_SIZE(osm_l3_nodes),
> - .lut_row_size = OSM_LUT_ROW_SIZE,
> - .reg_freq_lut = OSM_REG_FREQ_LUT,
> - .reg_perf_state = OSM_REG_PERF_STATE,
> -};
> -
> -static const struct qcom_osm_l3_desc sm8150_icc_osm_l3 = {
> - .nodes = osm_l3_nodes,
> - .num_nodes = ARRAY_SIZE(osm_l3_nodes),
> - .lut_row_size = OSM_LUT_ROW_SIZE,
> - .reg_freq_lut = OSM_REG_FREQ_LUT,
> - .reg_perf_state = OSM_REG_PERF_STATE,
> -};
> -
> -static const struct qcom_osm_l3_desc sm8250_icc_epss_l3 = {
> +static const struct qcom_osm_l3_desc epss_l3 = {
> .nodes = epss_l3_nodes,
> .num_nodes = ARRAY_SIZE(epss_l3_nodes),
> .lut_row_size = EPSS_LUT_ROW_SIZE,
> @@ -317,12 +285,12 @@ static int qcom_osm_l3_probe(struct platform_device *pdev)
> }
>
> static const struct of_device_id osm_l3_of_match[] = {
> - { .compatible = "qcom,sc7180-osm-l3", .data = &sc7180_icc_osm_l3 },
> - { .compatible = "qcom,sc7280-epss-l3", .data = &sc7280_icc_epss_l3 },
> - { .compatible = "qcom,sdm845-osm-l3", .data = &sdm845_icc_osm_l3 },
> - { .compatible = "qcom,sm8150-osm-l3", .data = &sm8150_icc_osm_l3 },
> - { .compatible = "qcom,sc8180x-osm-l3", .data = &sc8180x_icc_osm_l3 },
> - { .compatible = "qcom,sm8250-epss-l3", .data = &sm8250_icc_epss_l3 },
> + { .compatible = "qcom,sc7180-osm-l3", .data = &osm_l3 },
> + { .compatible = "qcom,sc7280-epss-l3", .data = &epss_l3 },
> + { .compatible = "qcom,sdm845-osm-l3", .data = &osm_l3 },
> + { .compatible = "qcom,sm8150-osm-l3", .data = &osm_l3 },
> + { .compatible = "qcom,sc8180x-osm-l3", .data = &osm_l3 },
> + { .compatible = "qcom,sm8250-epss-l3", .data = &epss_l3 },
> { }
> };
> MODULE_DEVICE_TABLE(of, osm_l3_of_match);
next prev parent reply other threads:[~2022-11-11 10:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 3:25 [PATCH v2 00/10] interconnect: osm-l3: SC8280XP L3 and DDR scaling Bjorn Andersson
2022-11-11 3:25 ` [PATCH v2 01/10] interconnect: qcom: osm-l3: Use platform-independent node ids Bjorn Andersson
2022-11-11 10:23 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 02/10] interconnect: qcom: osm-l3: Squash common descriptors Bjorn Andersson
2022-11-11 10:24 ` Sibi Sankar [this message]
2022-11-11 3:25 ` [PATCH v2 03/10] interconnect: qcom: osm-l3: Add per-core EPSS L3 support Bjorn Andersson
2022-11-11 10:24 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 04/10] interconnect: qcom: osm-l3: Simplify osm_l3_set() Bjorn Andersson
2022-11-11 10:26 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 05/10] dt-bindings: interconnect: Add sm8350, sc8280xp and generic OSM L3 compatibles Bjorn Andersson
2022-11-11 8:36 ` Krzysztof Kozlowski
2022-11-11 10:32 ` Sibi Sankar
2022-11-11 18:08 ` Bjorn Andersson
2022-11-16 6:56 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 06/10] arm64: dts: qcom: Align with generic osm-l3/epss-l3 Bjorn Andersson
2022-11-11 10:44 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 07/10] arm64: dts: qcom: sc8280xp: Add epss_l3 node Bjorn Andersson
2022-11-11 10:33 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 08/10] arm64: dts: qcom: sc8280xp: Set up L3 scaling Bjorn Andersson
2022-11-16 11:01 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 09/10] dt-bindings: interconnect: qcom,msm8998-bwmon: Add sc8280xp bwmon instances Bjorn Andersson
2022-11-11 8:35 ` Krzysztof Kozlowski
2022-11-11 10:53 ` Sibi Sankar
2022-11-11 3:25 ` [PATCH v2 10/10] arm64: dts: qcom: sc8280xp: Add " Bjorn Andersson
2022-11-11 11:03 ` Sibi Sankar
2022-11-17 16:25 ` [PATCH v2 00/10] interconnect: osm-l3: SC8280XP L3 and DDR scaling Georgi Djakov
2022-12-06 18:19 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54982867-6495-ee1e-889f-65fa5e5b2912@quicinc.com \
--to=quic_sibis@quicinc.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=quic_mdtipton@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).