From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Wang Long <long.wanglong@huawei.com>
Cc: davem@davemloft.net, anil.s.keshavamurthy@intel.com,
ananth@in.ibm.com, linux-kernel@vger.kernel.org,
peifeiyue@huawei.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] SAMPLES: kprobe_example: Make it print something on ARM.
Date: Wed, 04 Feb 2015 12:17:21 +0900 [thread overview]
Message-ID: <54D18F41.4070207@hitachi.com> (raw)
In-Reply-To: <1423018585-4005-1-git-send-email-long.wanglong@huawei.com>
(2015/02/04 11:56), Wang Long wrote:
> This KProbes example is a little useless if it doesn't print anything.
> For ARM print similar messages to those produced on x86 and PPC.
BTW, I guess similar update required for s390, doesn't it?
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thank you!
> ---
> samples/kprobes/kprobe_example.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index 366db1a..eba9f1a 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -42,6 +42,11 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
> " ex1 = 0x%lx\n",
> p->addr, regs->pc, regs->ex1);
> #endif
> +#ifdef CONFIG_ARM
> + printk(KERN_INFO "pre_handler: p->addr = 0x%p, ARM_pc = 0x%lx,"
> + " ARM_cpsr = 0x%lx\n",
> + p->addr, regs->ARM_pc, regs->ARM_cpsr);
> +#endif
>
> /* A dump_stack() here will give a stack backtrace */
> return 0;
> @@ -67,6 +72,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
> printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
> p->addr, regs->ex1);
> #endif
> +#ifdef CONFIG_ARM
> + printk(KERN_INFO "post_handler: p->addr = 0x%p, ARM_cpsr = 0x%lx\n",
> + p->addr, regs->ARM_cpsr);
> +#endif
> }
>
> /*
>
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2015-02-04 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 2:56 [PATCH] SAMPLES: kprobe_example: Make it print something on ARM Wang Long
2015-02-04 3:17 ` Masami Hiramatsu [this message]
2015-02-05 1:09 ` long.wanglong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D18F41.4070207@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=long.wanglong@huawei.com \
--cc=peifeiyue@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).