linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] SAMPLES: kprobe_example: Make it print something on ARM.
@ 2015-02-04  2:56 Wang Long
  2015-02-04  3:17 ` Masami Hiramatsu
  0 siblings, 1 reply; 3+ messages in thread
From: Wang Long @ 2015-02-04  2:56 UTC (permalink / raw)
  To: masami.hiramatsu.pt, davem, anil.s.keshavamurthy, ananth
  Cc: linux-kernel, peifeiyue, long.wanglong, linux-arm-kernel

This KProbes example is a little useless if it doesn't print anything.
For ARM print similar messages to those produced on x86 and PPC.

Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
 samples/kprobes/kprobe_example.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index 366db1a..eba9f1a 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -42,6 +42,11 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
 			" ex1 = 0x%lx\n",
 		p->addr, regs->pc, regs->ex1);
 #endif
+#ifdef CONFIG_ARM
+	printk(KERN_INFO "pre_handler: p->addr = 0x%p, ARM_pc = 0x%lx,"
+			" ARM_cpsr = 0x%lx\n",
+		p->addr, regs->ARM_pc, regs->ARM_cpsr);
+#endif
 
 	/* A dump_stack() here will give a stack backtrace */
 	return 0;
@@ -67,6 +72,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
 	printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
 		p->addr, regs->ex1);
 #endif
+#ifdef CONFIG_ARM
+	printk(KERN_INFO "post_handler: p->addr = 0x%p, ARM_cpsr = 0x%lx\n",
+		p->addr, regs->ARM_cpsr);
+#endif
 }
 
 /*
-- 
1.8.3.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] SAMPLES: kprobe_example: Make it print something on ARM.
  2015-02-04  2:56 [PATCH] SAMPLES: kprobe_example: Make it print something on ARM Wang Long
@ 2015-02-04  3:17 ` Masami Hiramatsu
  2015-02-05  1:09   ` long.wanglong
  0 siblings, 1 reply; 3+ messages in thread
From: Masami Hiramatsu @ 2015-02-04  3:17 UTC (permalink / raw)
  To: Wang Long
  Cc: davem, anil.s.keshavamurthy, ananth, linux-kernel, peifeiyue,
	linux-arm-kernel

(2015/02/04 11:56), Wang Long wrote:
> This KProbes example is a little useless if it doesn't print anything.
> For ARM print similar messages to those produced on x86 and PPC.

BTW, I guess similar update required for s390, doesn't it?

> 
> Signed-off-by: Wang Long <long.wanglong@huawei.com>

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thank you!

> ---
>  samples/kprobes/kprobe_example.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> index 366db1a..eba9f1a 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -42,6 +42,11 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
>  			" ex1 = 0x%lx\n",
>  		p->addr, regs->pc, regs->ex1);
>  #endif
> +#ifdef CONFIG_ARM
> +	printk(KERN_INFO "pre_handler: p->addr = 0x%p, ARM_pc = 0x%lx,"
> +			" ARM_cpsr = 0x%lx\n",
> +		p->addr, regs->ARM_pc, regs->ARM_cpsr);
> +#endif
>  
>  	/* A dump_stack() here will give a stack backtrace */
>  	return 0;
> @@ -67,6 +72,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
>  	printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
>  		p->addr, regs->ex1);
>  #endif
> +#ifdef CONFIG_ARM
> +	printk(KERN_INFO "post_handler: p->addr = 0x%p, ARM_cpsr = 0x%lx\n",
> +		p->addr, regs->ARM_cpsr);
> +#endif
>  }
>  
>  /*
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] SAMPLES: kprobe_example: Make it print something on ARM.
  2015-02-04  3:17 ` Masami Hiramatsu
@ 2015-02-05  1:09   ` long.wanglong
  0 siblings, 0 replies; 3+ messages in thread
From: long.wanglong @ 2015-02-05  1:09 UTC (permalink / raw)
  To: Masami Hiramatsu
  Cc: peifeiyue, linux-kernel, anil.s.keshavamurthy, davem,
	linux-arm-kernel, ananth

On 2015/2/4 11:17, Masami Hiramatsu wrote:
> (2015/02/04 11:56), Wang Long wrote:
>> This KProbes example is a little useless if it doesn't print anything.
>> For ARM print similar messages to those produced on x86 and PPC.
> 
> BTW, I guess similar update required for s390, doesn't it?
> 

yes, because i am not familiar with s390, someone else may update this example for s390.

Best Regards
Wang Long

>>
>> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> 
> Thank you!
> 
>> ---
>>  samples/kprobes/kprobe_example.c | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
>> index 366db1a..eba9f1a 100644
>> --- a/samples/kprobes/kprobe_example.c
>> +++ b/samples/kprobes/kprobe_example.c
>> @@ -42,6 +42,11 @@ static int handler_pre(struct kprobe *p, struct pt_regs *regs)
>>  			" ex1 = 0x%lx\n",
>>  		p->addr, regs->pc, regs->ex1);
>>  #endif
>> +#ifdef CONFIG_ARM
>> +	printk(KERN_INFO "pre_handler: p->addr = 0x%p, ARM_pc = 0x%lx,"
>> +			" ARM_cpsr = 0x%lx\n",
>> +		p->addr, regs->ARM_pc, regs->ARM_cpsr);
>> +#endif
>>  
>>  	/* A dump_stack() here will give a stack backtrace */
>>  	return 0;
>> @@ -67,6 +72,10 @@ static void handler_post(struct kprobe *p, struct pt_regs *regs,
>>  	printk(KERN_INFO "post_handler: p->addr = 0x%p, ex1 = 0x%lx\n",
>>  		p->addr, regs->ex1);
>>  #endif
>> +#ifdef CONFIG_ARM
>> +	printk(KERN_INFO "post_handler: p->addr = 0x%p, ARM_cpsr = 0x%lx\n",
>> +		p->addr, regs->ARM_cpsr);
>> +#endif
>>  }
>>  
>>  /*
>>
> 
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-05  1:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-04  2:56 [PATCH] SAMPLES: kprobe_example: Make it print something on ARM Wang Long
2015-02-04  3:17 ` Masami Hiramatsu
2015-02-05  1:09   ` long.wanglong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).