* [PATCH] drm: add missing dependency to DRM_PANEL_EDP
@ 2022-01-23 20:43 Luca Weiss
2022-01-23 21:05 ` Luca Weiss
2022-02-26 10:48 ` Luca Weiss
0 siblings, 2 replies; 3+ messages in thread
From: Luca Weiss @ 2022-01-23 20:43 UTC (permalink / raw)
To: dri-devel
Cc: ~postmarketos/upstreaming, Luca Weiss, Thierry Reding,
Sam Ravnborg, David Airlie, Daniel Vetter, linux-kernel
With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation
fails:
drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to `drm_panel_dp_aux_backlight'
Add a dependency on DRM_KMS_HELPER to fix this.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
I briefly tried "select DRM_KMS_HELPER" but that causes a circular
dependency.
If someone has a better idea how to solve this, feel free correct me.
drivers/gpu/drm/panel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 434c2861bb40..fda97837ecb3 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE
config DRM_PANEL_EDP
tristate "support for simple Embedded DisplayPort panels"
depends on OF
+ depends on DRM_KMS_HELPER
depends on BACKLIGHT_CLASS_DEVICE
depends on PM
select VIDEOMODE_HELPERS
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm: add missing dependency to DRM_PANEL_EDP
2022-01-23 20:43 [PATCH] drm: add missing dependency to DRM_PANEL_EDP Luca Weiss
@ 2022-01-23 21:05 ` Luca Weiss
2022-02-26 10:48 ` Luca Weiss
1 sibling, 0 replies; 3+ messages in thread
From: Luca Weiss @ 2022-01-23 21:05 UTC (permalink / raw)
To: dri-devel
Cc: ~postmarketos/upstreaming, Thierry Reding, Sam Ravnborg,
David Airlie, Daniel Vetter, linux-kernel
On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote:
> With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation
> fails:
>
> drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to
> `drm_panel_dp_aux_backlight'
>
> Add a dependency on DRM_KMS_HELPER to fix this.
>
Forgot to add, this is the closest "Fixes" I can find, before that commit with
arm32 qcom_defconfig both beforementioned options were builtin
Fixes: 9d6366e743f3 ("drm: fb_helper: improve CONFIG_FB dependency")
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> I briefly tried "select DRM_KMS_HELPER" but that causes a circular
> dependency.
> If someone has a better idea how to solve this, feel free correct me.
>
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 434c2861bb40..fda97837ecb3 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE
> config DRM_PANEL_EDP
> tristate "support for simple Embedded DisplayPort panels"
> depends on OF
> + depends on DRM_KMS_HELPER
> depends on BACKLIGHT_CLASS_DEVICE
> depends on PM
> select VIDEOMODE_HELPERS
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm: add missing dependency to DRM_PANEL_EDP
2022-01-23 20:43 [PATCH] drm: add missing dependency to DRM_PANEL_EDP Luca Weiss
2022-01-23 21:05 ` Luca Weiss
@ 2022-02-26 10:48 ` Luca Weiss
1 sibling, 0 replies; 3+ messages in thread
From: Luca Weiss @ 2022-02-26 10:48 UTC (permalink / raw)
To: dri-devel
Cc: ~postmarketos/upstreaming, Thierry Reding, Sam Ravnborg,
David Airlie, Daniel Vetter, linux-kernel
Hi, any feedback on this patch?
On Sonntag, 23. Jänner 2022 21:43:23 CET Luca Weiss wrote:
> With CONFIG_DRM_PANEL_EDP=y and CONFIG_DRM_KMS_HELPER=m the compilation
> fails:
>
> drivers/gpu/drm/panel/panel-edp.c:843: undefined reference to
> `drm_panel_dp_aux_backlight'
>
> Add a dependency on DRM_KMS_HELPER to fix this.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> I briefly tried "select DRM_KMS_HELPER" but that causes a circular
> dependency.
> If someone has a better idea how to solve this, feel free correct me.
>
> drivers/gpu/drm/panel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 434c2861bb40..fda97837ecb3 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -102,6 +102,7 @@ config DRM_PANEL_SIMPLE
> config DRM_PANEL_EDP
> tristate "support for simple Embedded DisplayPort panels"
> depends on OF
> + depends on DRM_KMS_HELPER
> depends on BACKLIGHT_CLASS_DEVICE
> depends on PM
> select VIDEOMODE_HELPERS
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-26 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-23 20:43 [PATCH] drm: add missing dependency to DRM_PANEL_EDP Luca Weiss
2022-01-23 21:05 ` Luca Weiss
2022-02-26 10:48 ` Luca Weiss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).