From: Damien Horsley <Damien.Horsley@imgtec.com>
To: Mark Brown <broonie@kernel.org>
Cc: <alsa-devel@alsa-project.org>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
Date: Tue, 8 Dec 2015 16:04:02 +0000 [thread overview]
Message-ID: <5666FF72.7010206@imgtec.com> (raw)
In-Reply-To: <20151125124728.GT1929@sirena.org.uk>
On 25/11/15 12:47, Mark Brown wrote:
> On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
>
>> + /* The mute state as set by alsa using the digital_mute callback */
>> + bool alsa_mute_state;
>> + /* The mute state as set by the userspace mute control */
>> + bool control_mute_state;
>> + /* The actual mute state is equal to an OR of the above */
>
> Does the device *need* the digital mute to avoid noise? If there's no
> strong need for it then just don't bother which simplifies the code a
> lot.
>
> Otherwise this looks good.
>
It does not seem to make a difference. I will remove and repost.
prev parent reply other threads:[~2015-12-08 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1448299499-18435-1-git-send-email-Damien.Horsley@imgtec.com>
2015-11-25 12:40 ` [alsa-devel] [PATCH 0/2] Add support for Pistachio internal DAC Mark Brown
[not found] ` <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
2015-11-25 12:47 ` [alsa-devel] [PATCH 2/2] ASoC: img: Add driver " Mark Brown
2015-12-08 16:04 ` Damien Horsley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666FF72.7010206@imgtec.com \
--to=damien.horsley@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).