* Re: [alsa-devel] [PATCH 0/2] Add support for Pistachio internal DAC
[not found] <1448299499-18435-1-git-send-email-Damien.Horsley@imgtec.com>
@ 2015-11-25 12:40 ` Mark Brown
[not found] ` <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-11-25 12:40 UTC (permalink / raw)
To: Damien Horsley
Cc: alsa-devel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Mon, Nov 23, 2015 at 05:24:57PM +0000, Damien Horsley wrote:
> From: "Damien.Horsley" <Damien.Horsley@imgtec.com>
>
> Add binding document and driver for Pistachio internal DAC
Please don't add noise like [alsa-devel] to the subject line of mails,
it just consumes space in the subject line which makes it harder to see
what's going on when scanning your inbox (I know that the list does it
for copies that goes to the list).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
[not found] ` <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
@ 2015-11-25 12:47 ` Mark Brown
2015-12-08 16:04 ` Damien Horsley
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2015-11-25 12:47 UTC (permalink / raw)
To: Damien Horsley
Cc: alsa-devel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
> + /* The mute state as set by alsa using the digital_mute callback */
> + bool alsa_mute_state;
> + /* The mute state as set by the userspace mute control */
> + bool control_mute_state;
> + /* The actual mute state is equal to an OR of the above */
Does the device *need* the digital mute to avoid noise? If there's no
strong need for it then just don't bother which simplifies the code a
lot.
Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH 2/2] ASoC: img: Add driver for Pistachio internal DAC
2015-11-25 12:47 ` [alsa-devel] [PATCH 2/2] ASoC: img: Add driver " Mark Brown
@ 2015-12-08 16:04 ` Damien Horsley
0 siblings, 0 replies; 3+ messages in thread
From: Damien Horsley @ 2015-12-08 16:04 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
devicetree, linux-kernel
On 25/11/15 12:47, Mark Brown wrote:
> On Mon, Nov 23, 2015 at 05:24:59PM +0000, Damien Horsley wrote:
>
>> + /* The mute state as set by alsa using the digital_mute callback */
>> + bool alsa_mute_state;
>> + /* The mute state as set by the userspace mute control */
>> + bool control_mute_state;
>> + /* The actual mute state is equal to an OR of the above */
>
> Does the device *need* the digital mute to avoid noise? If there's no
> strong need for it then just don't bother which simplifies the code a
> lot.
>
> Otherwise this looks good.
>
It does not seem to make a difference. I will remove and repost.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-08 16:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1448299499-18435-1-git-send-email-Damien.Horsley@imgtec.com>
2015-11-25 12:40 ` [alsa-devel] [PATCH 0/2] Add support for Pistachio internal DAC Mark Brown
[not found] ` <1448299499-18435-3-git-send-email-Damien.Horsley@imgtec.com>
2015-11-25 12:47 ` [alsa-devel] [PATCH 2/2] ASoC: img: Add driver " Mark Brown
2015-12-08 16:04 ` Damien Horsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).