From: Nishanth Menon <nm@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Sekhar Nori <nsekhar@ti.com>
Subject: Re: [PATCH] regmap: irq: Enable irq retriggering for nested irqs
Date: Fri, 26 Feb 2016 11:05:55 -0600 [thread overview]
Message-ID: <56D085F3.5090603@ti.com> (raw)
In-Reply-To: <1456502037-17036-1-git-send-email-grygorii.strashko@ti.com>
On 02/26/2016 09:53 AM, Grygorii Strashko wrote:
> When nested interrupts are handled with regmap irq framework, we need to
> mark the interrupts to be resend for pending interrupts on enable_irq.
> Else the events might be lost for nested irqs.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/base/regmap/regmap-irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
> index 9b0d202..8d9004d 100644
> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -379,6 +379,7 @@ static int regmap_irq_map(struct irq_domain *h, unsigned int virq,
> irq_set_chip_data(virq, data);
> irq_set_chip(virq, &data->irq_chip);
> irq_set_nested_thread(virq, 1);
> + irq_set_parent(virq, data->irq);
> irq_set_noprobe(virq);
>
> return 0;
>
This is part of the fixes seen to be needed for VBUS irq over Palmas
seen on BeagleBoard-X15.
this patch was part of an internal series which finally resolved the
crash (and associated hang) on X15 resume path.
Tested-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
prev parent reply other threads:[~2016-02-26 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 15:53 [PATCH] regmap: irq: Enable irq retriggering for nested irqs Grygorii Strashko
2016-02-26 17:05 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D085F3.5090603@ti.com \
--to=nm@ti.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).