* [PATCH] regmap: irq: Enable irq retriggering for nested irqs
@ 2016-02-26 15:53 Grygorii Strashko
2016-02-26 17:05 ` Nishanth Menon
0 siblings, 1 reply; 2+ messages in thread
From: Grygorii Strashko @ 2016-02-26 15:53 UTC (permalink / raw)
To: Mark Brown, Greg Kroah-Hartman, linux-kernel
Cc: Lee Jones, Nishanth Menon, Laxman Dewangan, Sekhar Nori,
Grygorii Strashko
When nested interrupts are handled with regmap irq framework, we need to
mark the interrupts to be resend for pending interrupts on enable_irq.
Else the events might be lost for nested irqs.
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/base/regmap/regmap-irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index 9b0d202..8d9004d 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -379,6 +379,7 @@ static int regmap_irq_map(struct irq_domain *h, unsigned int virq,
irq_set_chip_data(virq, data);
irq_set_chip(virq, &data->irq_chip);
irq_set_nested_thread(virq, 1);
+ irq_set_parent(virq, data->irq);
irq_set_noprobe(virq);
return 0;
--
2.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] regmap: irq: Enable irq retriggering for nested irqs
2016-02-26 15:53 [PATCH] regmap: irq: Enable irq retriggering for nested irqs Grygorii Strashko
@ 2016-02-26 17:05 ` Nishanth Menon
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2016-02-26 17:05 UTC (permalink / raw)
To: Grygorii Strashko, Mark Brown, Greg Kroah-Hartman, linux-kernel
Cc: Lee Jones, Laxman Dewangan, Sekhar Nori
On 02/26/2016 09:53 AM, Grygorii Strashko wrote:
> When nested interrupts are handled with regmap irq framework, we need to
> mark the interrupts to be resend for pending interrupts on enable_irq.
> Else the events might be lost for nested irqs.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/base/regmap/regmap-irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
> index 9b0d202..8d9004d 100644
> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -379,6 +379,7 @@ static int regmap_irq_map(struct irq_domain *h, unsigned int virq,
> irq_set_chip_data(virq, data);
> irq_set_chip(virq, &data->irq_chip);
> irq_set_nested_thread(virq, 1);
> + irq_set_parent(virq, data->irq);
> irq_set_noprobe(virq);
>
> return 0;
>
This is part of the fixes seen to be needed for VBUS irq over Palmas
seen on BeagleBoard-X15.
this patch was part of an internal series which finally resolved the
crash (and associated hang) on X15 resume path.
Tested-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-26 17:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-26 15:53 [PATCH] regmap: irq: Enable irq retriggering for nested irqs Grygorii Strashko
2016-02-26 17:05 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).