linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: linmiaohe <linmiaohe@huawei.com>
To: Liran Alon <liran.alon@oracle.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
	"sean.j.christopherson@intel.com"
	<sean.j.christopherson@intel.com>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>,
	"wanpengli@tencent.com" <wanpengli@tencent.com>,
	"jmattson@google.com" <jmattson@google.com>,
	"joro@8bytes.org" <joro@8bytes.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected
Date: Thu, 26 Dec 2019 02:31:27 +0000	[thread overview]
Message-ID: <5744632b88b44369a68c0b0704bfb48e@huawei.com> (raw)

Hi,

Liran Alon <liran.alon@oracle.com> wrote:
>> On 25 Dec 2019, at 4:21, linmiaohe <linmiaohe@huawei.com> wrote:
>> 
>> From: Miaohe Lin <linmiaohe@huawei.com>
>> 
>> We should retry writing guest memory when 
>> kvm_write_guest_virt_system() failed and page fault is injected in handle_vmread().
>> 
>> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
>
>Patch fix seems correct to me:
>Reviewed-by: Liran Alon <liran.alon@oracle.com>

Thanks for your review.

>However, I suggest to rephrase commit title & message as follows:
>
>"""
>KVM: nVMX: vmread should not set rflags to specify success in case of #PF
>
>In case writing to vmread destination operand result in a #PF, vmread should not call nested_vmx_succeed() to set rflags to specify success. Similar to as done in for VMPTRST (See handle_vmptrst()).
>"""

Thanks for your sueestion, I would rephrase commit title & message accordingly.

>
>In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.

I'd like to submit kvm-unit-test that verifies this condition, but I am not familiar with the kvm-unit-test code yet and
also not in my recent todo list. So such a patch may come late. It would be appreciated too if you could submit this
kvm-unit-test patch. :) 
Thanks again.

             reply	other threads:[~2019-12-26  2:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-26  2:31 linmiaohe [this message]
2019-12-26  2:35 ` [PATCH] KVM: nvmx: retry writing guest memory after page fault injected Wanpeng Li
  -- strict thread matches above, loose matches on Subject: below --
2019-12-26  3:09 linmiaohe
2019-12-25  2:21 linmiaohe
2019-12-26  0:20 ` Liran Alon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5744632b88b44369a68c0b0704bfb48e@huawei.com \
    --to=linmiaohe@huawei.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liran.alon@oracle.com \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=tglx@linutronix.de \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).