From: linmiaohe <linmiaohe@huawei.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Liran Alon <liran.alon@oracle.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"sean.j.christopherson@intel.com"
<sean.j.christopherson@intel.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"wanpengli@tencent.com" <wanpengli@tencent.com>,
"jmattson@google.com" <jmattson@google.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected
Date: Thu, 26 Dec 2019 03:09:23 +0000 [thread overview]
Message-ID: <d66b6e479a4e4113a86bee1c0682aa46@huawei.com> (raw)
Hi,
Wanpeng Li <kernellwp@gmail.com> wrote:
> On Thu, 26 Dec 2019 at 10:32, linmiaohe <linmiaohe@huawei.com> wrote:
> >
> > >
> > >In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.
> >
> > I'd like to submit kvm-unit-test that verifies this condition, but I
> > am not familiar with the kvm-unit-test code yet and also not in my
> > recent todo list. So such a patch may come late. It would be
> > appreciated too if you could submit this kvm-unit-test patch. :)
>
> Hmm, did you verify your own patch? Please give the testcase.
>
I'am sorry but this is a code inspection path. And I think this fix is correct from the code logic and
this behavior is similar as handle_vmwrite, handle_vmptrst, handle_invept and so on. Thanks!
next reply other threads:[~2019-12-26 3:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 3:09 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-12-26 2:31 [PATCH] KVM: nvmx: retry writing guest memory after page fault injected linmiaohe
2019-12-26 2:35 ` Wanpeng Li
2019-12-25 2:21 linmiaohe
2019-12-26 0:20 ` Liran Alon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66b6e479a4e4113a86bee1c0682aa46@huawei.com \
--to=linmiaohe@huawei.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liran.alon@oracle.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).