From: Liran Alon <liran.alon@oracle.com>
To: linmiaohe <linmiaohe@huawei.com>
Cc: pbonzini@redhat.com, rkrcmar@redhat.com,
sean.j.christopherson@intel.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected
Date: Thu, 26 Dec 2019 02:20:59 +0200 [thread overview]
Message-ID: <CE1E9880-3812-473F-A38B-2FAC45A95839@oracle.com> (raw)
In-Reply-To: <1577240501-763-1-git-send-email-linmiaohe@huawei.com>
> On 25 Dec 2019, at 4:21, linmiaohe <linmiaohe@huawei.com> wrote:
>
> From: Miaohe Lin <linmiaohe@huawei.com>
>
> We should retry writing guest memory when kvm_write_guest_virt_system()
> failed and page fault is injected in handle_vmread().
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Patch fix seems correct to me:
Reviewed-by: Liran Alon <liran.alon@oracle.com>
However, I suggest to rephrase commit title & message as follows:
"""
KVM: nVMX: vmread should not set rflags to specify success in case of #PF
In case writing to vmread destination operand result in a #PF, vmread should
not call nested_vmx_succeed() to set rflags to specify success. Similar to as
done in for VMPTRST (See handle_vmptrst()).
"""
In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.
-Liran
> ---
> arch/x86/kvm/vmx/nested.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 8edefdc9c0cb..c1ec9f25a417 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -4799,8 +4799,10 @@ static int handle_vmread(struct kvm_vcpu *vcpu)
> instr_info, true, len, &gva))
> return 1;
> /* _system ok, nested_vmx_check_permission has verified cpl=0 */
> - if (kvm_write_guest_virt_system(vcpu, gva, &value, len, &e))
> + if (kvm_write_guest_virt_system(vcpu, gva, &value, len, &e)) {
> kvm_inject_page_fault(vcpu, &e);
> + return 1;
> + }
> }
>
> return nested_vmx_succeed(vcpu);
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-12-26 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 2:21 [PATCH] KVM: nvmx: retry writing guest memory after page fault injected linmiaohe
2019-12-26 0:20 ` Liran Alon [this message]
2019-12-26 2:31 linmiaohe
2019-12-26 2:35 ` Wanpeng Li
2019-12-26 3:09 linmiaohe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CE1E9880-3812-473F-A38B-2FAC45A95839@oracle.com \
--to=liran.alon@oracle.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).