linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* select on non-existing Kconfig option CRC32C
@ 2016-06-15 10:00 Andreas Ziegler
  2016-06-15 14:40 ` Randy Dunlap
  2016-06-15 14:41 ` Hendrik Brueckner
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Ziegler @ 2016-06-15 10:00 UTC (permalink / raw)
  To: Hendrik Brueckner
  Cc: Martin Schwidefsky, Herbert Xu, David S. Miller, linux-crypto,
	linux-kernel

Hi Hendrik,

your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
algorithms" showed up in linux-next today (next-20160615) as commit 	364148e0b195.

The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C.
However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.
Should I prepare a trivial patch to fix this up or would you like to do that on
your side?

I found this issue by comparing yesterday's tree and today's tree using
'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'.

Best regards,

Andreas

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: select on non-existing Kconfig option CRC32C
  2016-06-15 10:00 select on non-existing Kconfig option CRC32C Andreas Ziegler
@ 2016-06-15 14:40 ` Randy Dunlap
  2016-06-15 14:41 ` Hendrik Brueckner
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2016-06-15 14:40 UTC (permalink / raw)
  To: Andreas Ziegler, Hendrik Brueckner
  Cc: Martin Schwidefsky, Herbert Xu, David S. Miller, linux-crypto,
	linux-kernel

On 06/15/16 03:00, Andreas Ziegler wrote:
> Hi Hendrik,
> 
> your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
> algorithms" showed up in linux-next today (next-20160615) as commit 	364148e0b195.
> 
> The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C.
> However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.
> Should I prepare a trivial patch to fix this up or would you like to do that on
> your side?
> 
> I found this issue by comparing yesterday's tree and today's tree using
> 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'.

or should it select CRC32 or LIBCRC32C?  (probably not the LIB... one)

-- 
~Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: select on non-existing Kconfig option CRC32C
  2016-06-15 10:00 select on non-existing Kconfig option CRC32C Andreas Ziegler
  2016-06-15 14:40 ` Randy Dunlap
@ 2016-06-15 14:41 ` Hendrik Brueckner
  1 sibling, 0 replies; 3+ messages in thread
From: Hendrik Brueckner @ 2016-06-15 14:41 UTC (permalink / raw)
  To: Andreas Ziegler
  Cc: Hendrik Brueckner, Martin Schwidefsky, Herbert Xu,
	David S. Miller, linux-crypto, linux-kernel

Hi Andreas,

On Wed, Jun 15, 2016 at 12:00:59PM +0200, Andreas Ziegler wrote:
> 
> your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
> algorithms" showed up in linux-next today (next-20160615) as commit 	364148e0b195.
> 
> The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C.
> However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.

Thanks for informing me.  Actually, the crc32-vx driver requires the
__crc32c_le() function which is available by selecting CONFIG_CRC32. There is
no need for CRYPTO_CRC32C.  So this can be safely removed.

> Should I prepare a trivial patch to fix this up or would you like to do that on
> your side?

Martin have already corrected the patch.

Thanks and kind regards,
  Hendrik

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-15 14:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 10:00 select on non-existing Kconfig option CRC32C Andreas Ziegler
2016-06-15 14:40 ` Randy Dunlap
2016-06-15 14:41 ` Hendrik Brueckner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).