* [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices
@ 2016-06-22 15:38 Joseph Salisbury
2016-06-22 16:14 ` Greg KH
2016-06-22 16:30 ` Alan Stern
0 siblings, 2 replies; 8+ messages in thread
From: Joseph Salisbury @ 2016-06-22 15:38 UTC (permalink / raw)
To: rtatiya
Cc: Greg KH, Robert Ancell, Alan Stern, mathias.nyman,
chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list,
LKML
Hi Rupesh,
A kernel bug report was opened against Ubuntu [0]. After a kernel
bisect, it was found that reverting the following commit resolved this bug:
commit a8425292816ceaa8c49e29d2114e85d85a73e080
Author: Rupesh Tatiya <rtatiya@codeaurora.org>
Date: Tue Apr 14 16:36:55 2015 +0530
usb: Enable LPM for USB 2.01+ full-speed devices
The regression was introduced as of v4.2-rc1.
I was hoping to get your feedback, since you are the patch author. Do
you think gathering any additional data will help diagnose this issue,
or would it be best to submit a revert request?
Thanks,
Joe
[0] http://pad.lv/1498667
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-22 15:38 [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices Joseph Salisbury @ 2016-06-22 16:14 ` Greg KH 2016-06-24 12:06 ` Joseph Salisbury 2016-06-22 16:30 ` Alan Stern 1 sibling, 1 reply; 8+ messages in thread From: Greg KH @ 2016-06-22 16:14 UTC (permalink / raw) To: Joseph Salisbury Cc: rtatiya, Robert Ancell, Alan Stern, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote: > Hi Rupesh, > > A kernel bug report was opened against Ubuntu [0]. After a kernel > bisect, it was found that reverting the following commit resolved this bug: > > commit a8425292816ceaa8c49e29d2114e85d85a73e080 > Author: Rupesh Tatiya <rtatiya@codeaurora.org> > Date: Tue Apr 14 16:36:55 2015 +0530 > > usb: Enable LPM for USB 2.01+ full-speed devices > > > The regression was introduced as of v4.2-rc1. > > I was hoping to get your feedback, since you are the patch author. Do > you think gathering any additional data will help diagnose this issue, > or would it be best to submit a revert request? Does the problem still happen with 4.7-rc4 or even 4.6? 4.2 is pretty old and obsolete you know :) thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-22 16:14 ` Greg KH @ 2016-06-24 12:06 ` Joseph Salisbury 2016-06-28 15:09 ` Joseph Salisbury 0 siblings, 1 reply; 8+ messages in thread From: Joseph Salisbury @ 2016-06-24 12:06 UTC (permalink / raw) To: Greg KH Cc: rtatiya, Robert Ancell, Alan Stern, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On 06/22/2016 12:14 PM, Greg KH wrote: > On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote: >> Hi Rupesh, >> >> A kernel bug report was opened against Ubuntu [0]. After a kernel >> bisect, it was found that reverting the following commit resolved this bug: >> >> commit a8425292816ceaa8c49e29d2114e85d85a73e080 >> Author: Rupesh Tatiya <rtatiya@codeaurora.org> >> Date: Tue Apr 14 16:36:55 2015 +0530 >> >> usb: Enable LPM for USB 2.01+ full-speed devices >> >> >> The regression was introduced as of v4.2-rc1. >> >> I was hoping to get your feedback, since you are the patch author. Do >> you think gathering any additional data will help diagnose this issue, >> or would it be best to submit a revert request? > Does the problem still happen with 4.7-rc4 or even 4.6? > > 4.2 is pretty old and obsolete you know :) > > thanks, > > greg k-h The regression does exist in 4.6-rc2. I'll have the latest mainline 4.7-rc4 kernel tested. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-24 12:06 ` Joseph Salisbury @ 2016-06-28 15:09 ` Joseph Salisbury 2016-06-28 15:40 ` Alan Stern 0 siblings, 1 reply; 8+ messages in thread From: Joseph Salisbury @ 2016-06-28 15:09 UTC (permalink / raw) To: Greg KH Cc: rtatiya, Robert Ancell, Alan Stern, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On 06/24/2016 08:06 AM, Joseph Salisbury wrote: > On 06/22/2016 12:14 PM, Greg KH wrote: >> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote: >>> Hi Rupesh, >>> >>> A kernel bug report was opened against Ubuntu [0]. After a kernel >>> bisect, it was found that reverting the following commit resolved this bug: >>> >>> commit a8425292816ceaa8c49e29d2114e85d85a73e080 >>> Author: Rupesh Tatiya <rtatiya@codeaurora.org> >>> Date: Tue Apr 14 16:36:55 2015 +0530 >>> >>> usb: Enable LPM for USB 2.01+ full-speed devices >>> >>> >>> The regression was introduced as of v4.2-rc1. >>> >>> I was hoping to get your feedback, since you are the patch author. Do >>> you think gathering any additional data will help diagnose this issue, >>> or would it be best to submit a revert request? >> Does the problem still happen with 4.7-rc4 or even 4.6? >> >> 4.2 is pretty old and obsolete you know :) >> >> thanks, >> >> greg k-h > The regression does exist in 4.6-rc2. I'll have the latest mainline > 4.7-rc4 kernel tested. The 4.7-rc4 kernel still exhibits the bug. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-28 15:09 ` Joseph Salisbury @ 2016-06-28 15:40 ` Alan Stern 2016-06-28 15:44 ` Joseph Salisbury 2016-07-06 20:27 ` Joseph Salisbury 0 siblings, 2 replies; 8+ messages in thread From: Alan Stern @ 2016-06-28 15:40 UTC (permalink / raw) To: Joseph Salisbury Cc: Greg KH, rtatiya, Robert Ancell, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On Tue, 28 Jun 2016, Joseph Salisbury wrote: > On 06/24/2016 08:06 AM, Joseph Salisbury wrote: > > On 06/22/2016 12:14 PM, Greg KH wrote: > >> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote: > >>> Hi Rupesh, > >>> > >>> A kernel bug report was opened against Ubuntu [0]. After a kernel > >>> bisect, it was found that reverting the following commit resolved this bug: > >>> > >>> commit a8425292816ceaa8c49e29d2114e85d85a73e080 > >>> Author: Rupesh Tatiya <rtatiya@codeaurora.org> > >>> Date: Tue Apr 14 16:36:55 2015 +0530 > >>> > >>> usb: Enable LPM for USB 2.01+ full-speed devices > >>> > >>> > >>> The regression was introduced as of v4.2-rc1. > >>> > >>> I was hoping to get your feedback, since you are the patch author. Do > >>> you think gathering any additional data will help diagnose this issue, > >>> or would it be best to submit a revert request? > >> Does the problem still happen with 4.7-rc4 or even 4.6? > >> > >> 4.2 is pretty old and obsolete you know :) > >> > >> thanks, > >> > >> greg k-h > > The regression does exist in 4.6-rc2. I'll have the latest mainline > > 4.7-rc4 kernel tested. > The 4.7-rc4 kernel still exhibits the bug. Have you tried adding a NO_LPM quirk entry for this device, as I suggested in an earlier email? I can write a patch for this, if you want. Alan Stern ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-28 15:40 ` Alan Stern @ 2016-06-28 15:44 ` Joseph Salisbury 2016-07-06 20:27 ` Joseph Salisbury 1 sibling, 0 replies; 8+ messages in thread From: Joseph Salisbury @ 2016-06-28 15:44 UTC (permalink / raw) To: Alan Stern Cc: Greg KH, rtatiya, Robert Ancell, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On 06/28/2016 11:40 AM, Alan Stern wrote: > On Tue, 28 Jun 2016, Joseph Salisbury wrote: > >> On 06/24/2016 08:06 AM, Joseph Salisbury wrote: >>> On 06/22/2016 12:14 PM, Greg KH wrote: >>>> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote: >>>>> Hi Rupesh, >>>>> >>>>> A kernel bug report was opened against Ubuntu [0]. After a kernel >>>>> bisect, it was found that reverting the following commit resolved this bug: >>>>> >>>>> commit a8425292816ceaa8c49e29d2114e85d85a73e080 >>>>> Author: Rupesh Tatiya <rtatiya@codeaurora.org> >>>>> Date: Tue Apr 14 16:36:55 2015 +0530 >>>>> >>>>> usb: Enable LPM for USB 2.01+ full-speed devices >>>>> >>>>> >>>>> The regression was introduced as of v4.2-rc1. >>>>> >>>>> I was hoping to get your feedback, since you are the patch author. Do >>>>> you think gathering any additional data will help diagnose this issue, >>>>> or would it be best to submit a revert request? >>>> Does the problem still happen with 4.7-rc4 or even 4.6? >>>> >>>> 4.2 is pretty old and obsolete you know :) >>>> >>>> thanks, >>>> >>>> greg k-h >>> The regression does exist in 4.6-rc2. I'll have the latest mainline >>> 4.7-rc4 kernel tested. >> The 4.7-rc4 kernel still exhibits the bug. > Have you tried adding a NO_LPM quirk entry for this device, as I > suggested in an earlier email? I can write a patch for this, if you > want. > > Alan Stern > Thanks for the suggesting, Alan. I'll give this a try and reply with the result. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-28 15:40 ` Alan Stern 2016-06-28 15:44 ` Joseph Salisbury @ 2016-07-06 20:27 ` Joseph Salisbury 1 sibling, 0 replies; 8+ messages in thread From: Joseph Salisbury @ 2016-07-06 20:27 UTC (permalink / raw) To: Alan Stern Cc: Greg KH, rtatiya, Robert Ancell, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On 06/28/2016 11:40 AM, Alan Stern wrote: > On Tue, 28 Jun 2016, Joseph Salisbury wrote: > >> On 06/24/2016 08:06 AM, Joseph Salisbury wrote: >>> On 06/22/2016 12:14 PM, Greg KH wrote: >>>> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote: >>>>> Hi Rupesh, >>>>> >>>>> A kernel bug report was opened against Ubuntu [0]. After a kernel >>>>> bisect, it was found that reverting the following commit resolved this bug: >>>>> >>>>> commit a8425292816ceaa8c49e29d2114e85d85a73e080 >>>>> Author: Rupesh Tatiya <rtatiya@codeaurora.org> >>>>> Date: Tue Apr 14 16:36:55 2015 +0530 >>>>> >>>>> usb: Enable LPM for USB 2.01+ full-speed devices >>>>> >>>>> >>>>> The regression was introduced as of v4.2-rc1. >>>>> >>>>> I was hoping to get your feedback, since you are the patch author. Do >>>>> you think gathering any additional data will help diagnose this issue, >>>>> or would it be best to submit a revert request? >>>> Does the problem still happen with 4.7-rc4 or even 4.6? >>>> >>>> 4.2 is pretty old and obsolete you know :) >>>> >>>> thanks, >>>> >>>> greg k-h >>> The regression does exist in 4.6-rc2. I'll have the latest mainline >>> 4.7-rc4 kernel tested. >> The 4.7-rc4 kernel still exhibits the bug. > Have you tried adding a NO_LPM quirk entry for this device, as I > suggested in an earlier email? I can write a patch for this, if you > want. > > Alan Stern > Yes, adding a NO_LPM quirk entry resolves the bug. I'll submit a patch shortly, it is basically these lines added to usb_quirk_list[]: + /* ELAN Microelectronics Touchscreen */ + { USB_DEVICE(0x04f3, 0x0381), .driver_info = USB_QUIRK_NO_LPM }, Thanks for the suggestion, Alan! ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices 2016-06-22 15:38 [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices Joseph Salisbury 2016-06-22 16:14 ` Greg KH @ 2016-06-22 16:30 ` Alan Stern 1 sibling, 0 replies; 8+ messages in thread From: Alan Stern @ 2016-06-22 16:30 UTC (permalink / raw) To: Joseph Salisbury Cc: rtatiya, Greg KH, Robert Ancell, mathias.nyman, chasemetzger15, baolu.lu, oneukum, kborer, jun.li, USB list, LKML On Wed, 22 Jun 2016, Joseph Salisbury wrote: > Hi Rupesh, > > A kernel bug report was opened against Ubuntu [0]. After a kernel > bisect, it was found that reverting the following commit resolved this bug: > > commit a8425292816ceaa8c49e29d2114e85d85a73e080 > Author: Rupesh Tatiya <rtatiya@codeaurora.org> > Date: Tue Apr 14 16:36:55 2015 +0530 > > usb: Enable LPM for USB 2.01+ full-speed devices > > > The regression was introduced as of v4.2-rc1. > > I was hoping to get your feedback, since you are the patch author. Do > you think gathering any additional data will help diagnose this issue, > or would it be best to submit a revert request? Another option is to add a NO_LPM quirks entry for the troublesome device. Alan Stern ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-07-06 20:27 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-06-22 15:38 [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed devices Joseph Salisbury 2016-06-22 16:14 ` Greg KH 2016-06-24 12:06 ` Joseph Salisbury 2016-06-28 15:09 ` Joseph Salisbury 2016-06-28 15:40 ` Alan Stern 2016-06-28 15:44 ` Joseph Salisbury 2016-07-06 20:27 ` Joseph Salisbury 2016-06-22 16:30 ` Alan Stern
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).