From: Thara Gopinath <thara.gopinath@linaro.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>,
mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com,
vincent.guittot@linaro.org, rui.zhang@intel.com,
edubezval@gmail.com, qperret@google.com
Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com,
javi.merino@kernel.org, daniel.lezcano@linaro.org
Subject: Re: [Patch v4 3/6] sched/fair: Enable CFS periodic tick to update thermal pressure
Date: Thu, 31 Oct 2019 12:46:45 -0400 [thread overview]
Message-ID: <5DBB0FF5.4040904@linaro.org> (raw)
In-Reply-To: <a303b61e-42f6-dfd7-264b-ead91da5f5ca@arm.com>
On 10/31/2019 12:11 PM, Dietmar Eggemann wrote:
> On 22.10.19 22:34, Thara Gopinath wrote:
>> Introduce support in CFS periodic tick to trigger the process of
>> computing average thermal pressure for a cpu.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>> kernel/sched/fair.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
>> index 682a754..4f9c2cb 100644
>> --- a/kernel/sched/fair.c
>> +++ b/kernel/sched/fair.c
>> @@ -21,6 +21,7 @@
>> * Copyright (C) 2007 Red Hat, Inc., Peter Zijlstra
>> */
>> #include "sched.h"
>> +#include "thermal.h"
>>
>> #include <trace/events/sched.h>
>>
>> @@ -7574,6 +7575,8 @@ static void update_blocked_averages(int cpu)
>> done = false;
>>
>> update_blocked_load_status(rq, !done);
>> +
>> + trigger_thermal_pressure_average(rq);
>> rq_unlock_irqrestore(rq, &rf);
>> }
>
> Since you update the thermal pressure signal in CFS's
> update_blocked_averages() as well, I guess the patch title has to change.
Will do. Thanks.
>
>>
>> @@ -9933,6 +9936,8 @@ static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
>>
>> update_misfit_status(curr, rq);
>> update_overutilized_status(task_rq(curr));
>> +
>> + trigger_thermal_pressure_average(rq);
>> }
>>
>> /*
>>
--
Warm Regards
Thara
next prev parent reply other threads:[~2019-10-31 16:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 20:34 [Patch v4 0/6] Introduce Thermal Pressure Thara Gopinath
2019-10-22 20:34 ` [Patch v4 1/6] sched/pelt.c: Add support to track thermal pressure Thara Gopinath
2019-10-31 9:47 ` Ionela Voinescu
2019-10-22 20:34 ` [Patch v4 2/6] sched: Add infrastructure to store and update instantaneous " Thara Gopinath
2019-10-28 15:21 ` Peter Zijlstra
2019-10-30 21:37 ` Thara Gopinath
2019-11-01 12:17 ` Dietmar Eggemann
2019-11-01 20:57 ` Thara Gopinath
2019-11-04 17:29 ` Dietmar Eggemann
2019-11-04 17:34 ` Vincent Guittot
2019-11-04 17:41 ` Dietmar Eggemann
2019-11-04 17:48 ` Vincent Guittot
2019-10-22 20:34 ` [Patch v4 3/6] sched/fair: Enable CFS periodic tick to update " Thara Gopinath
2019-10-28 15:24 ` Peter Zijlstra
2019-10-28 15:27 ` Peter Zijlstra
2019-10-30 21:41 ` Thara Gopinath
2019-10-31 16:11 ` Dietmar Eggemann
2019-10-31 16:46 ` Thara Gopinath [this message]
2019-10-22 20:34 ` [Patch v4 4/6] sched/fair: update cpu_capcity to reflect " Thara Gopinath
2019-10-23 12:28 ` Qais Yousef
2019-10-28 15:30 ` Peter Zijlstra
2019-10-31 10:53 ` Qais Yousef
2019-10-31 15:38 ` Dietmar Eggemann
2019-10-31 15:48 ` Vincent Guittot
2019-10-31 16:17 ` Dietmar Eggemann
2019-10-31 16:31 ` Vincent Guittot
2019-10-31 16:44 ` Dietmar Eggemann
2019-10-31 16:03 ` Thara Gopinath
2019-10-31 16:56 ` Qais Yousef
2019-10-22 20:34 ` [Patch v4 5/6] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2019-10-28 15:33 ` Peter Zijlstra
2019-10-31 16:29 ` Dietmar Eggemann
2019-10-31 16:38 ` Vincent Guittot
2019-11-01 15:47 ` Ionela Voinescu
2019-11-01 21:04 ` Thara Gopinath
2019-11-04 14:41 ` Ionela Voinescu
2019-10-31 16:46 ` Thara Gopinath
2019-10-22 20:34 ` [Patch v4 6/6] sched: thermal: Enable tuning of decay period Thara Gopinath
2019-10-28 15:42 ` Peter Zijlstra
2019-11-04 16:12 ` Ionela Voinescu
2019-11-05 20:26 ` Thara Gopinath
2019-11-05 21:29 ` Ionela Voinescu
2019-10-29 15:34 ` [Patch v4 0/6] Introduce Thermal Pressure Daniel Lezcano
2019-10-31 10:07 ` Ionela Voinescu
2019-10-31 11:54 ` Daniel Lezcano
2019-10-31 12:57 ` Ionela Voinescu
2019-10-31 17:48 ` Daniel Lezcano
2019-10-31 9:44 ` Ionela Voinescu
2019-10-31 16:41 ` Thara Gopinath
2019-10-31 16:52 ` Thara Gopinath
2019-11-05 21:04 ` Ionela Voinescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DBB0FF5.4040904@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).